Cortex\Auth\Notifications\AuthenticationLockoutNotification

Complexity

Total Complexity

3

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	via()	0	4	1
A	toMail()	0	11	1

<?php

declare(strict_types=1);

namespace Cortex\Auth\Notifications;

use Illuminate\Http\Request;
use Illuminate\Bus\Queueable;
use Illuminate\Notifications\Notification;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\MailMessage;

class AuthenticationLockoutNotification extends Notification implements ShouldQueue
{
    use Queueable;

    /**
     * The request instance.
     *
     * @var \Illuminate\Http\Request
     */
    public $request;

    /**
     * Create a notification instance.
     *
     * @param \Illuminate\Http\Request $request
     */
    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
    }

    /**
     * Get the notification's channels.
     *
     * @param mixed $notifiable
     *
     * @return array|string
     */
    public function via($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return ['mail'];
    }

    /**
     * Build the mail representation of the notification.
     *
     * @param mixed $notifiable
     *
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable): MailMessage

The parameter $notifiable is not used and could be removed.

    {
        return (new MailMessage())
            ->subject(trans('cortex/auth::emails.auth.lockout.subject'))
            ->line(trans('cortex/auth::emails.auth.lockout.intro', [
                'created_at' => now(),
                'ip' => $this->request->ip(),
                'agent' => $this->request->server('HTTP_USER_AGENT'),
            ]))
            ->line(trans('cortex/auth::emails.auth.lockout.outro'));
    }
}