UserFormRequest - Code Metrics - Inspection of "Update attributes rules" - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 87574f...25eb07 )

by Abdelrahman

created 2018-01-04 00:54 UTC

UserFormRequest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	105
rs	10
wmc	24
lcom	1
cbo	2

3 Methods

Rating	Name	Size	Complexity
A	authorize()	4	1
D	prepareForValidation()	48	16
C	rules()	33	7

<?php

declare(strict_types=1);

namespace Cortex\Fort\Http\Requests\Adminarea;

use Carbon\Carbon;
use Illuminate\Foundation\Http\FormRequest;

class UserFormRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @return bool
     */
    public function authorize()
    {
        return true;
    }

    /**
     * Prepare the data for validation.
     *
     * @return void
     */
    protected function prepareForValidation()
    {
        $data = $this->all();

        $user = $this->route('user') ?? app('rinvex.fort.user');
        $country = $data['country_code'] ?? null;
        $twoFactor = $user->getTwoFactor();

        $data['email_verified'] = $this->get('email_verified', false);
        $data['phone_verified'] = $this->get('phone_verified', false);

        if ($user->exists && empty($data['password'])) {
            unset($data['password'], $data['password_confirmation']);
        }

        // Update email verification date
        if ($data['email_verified'] && $user->email_verified !== $data['email_verified']) {
            $data['email_verified_at'] = Carbon::now();
        }

        // Update phone verification date
        if ($data['phone_verified'] && $user->phone_verified !== $data['phone_verified']) {
            $data['phone_verified_at'] = Carbon::now();
        }

        // Set abilities
        if ($this->user()->can('grant-abilities') && $data['abilities']) {
            $data['abilities'] = $this->user()->isSuperadmin() ? $data['abilities']
                : array_intersect($this->user()->allAbilities->pluck('id')->toArray(), $data['abilities']);
        } else {
            unset($data['abilities']);
        }

        // Set roles
        if ($this->user()->can('assign-roles') && $data['roles']) {
            $data['roles'] = $this->user()->isSuperadmin() ? $data['roles']
                : array_intersect($this->user()->roles->pluck('id')->toArray(), $data['roles']);
        } else {
            unset($data['roles']);
        }

        if ($twoFactor && (isset($data['phone_verified_at']) || $country !== $user->country_code)) {
            array_set($twoFactor, 'phone.enabled', false);
            $data['two_factor'] = $twoFactor;
        }

        $this->replace($data);
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array

     */
    public function rules()
    {
        $user = $this->route('user') ?? app('rinvex.fort.user');
        $user->updateRulesUniques();
        $rules = $user->getRules();

        // Attach attribute rules
        $user->getEntityAttributes()->each(function ($attribute, $attributeSlug) use (&$rules) {
            switch ($attribute->type) {
                case 'datetime':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $type = 'date';
                    break;
                case 'text':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                case 'varchar':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $type = 'string';
                    break;
                default:
switch ($expr) {
    default: { //wrong
        doSomething();
        break;
    }
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
                    $type = $attribute->type;
                    break;
            }

            $rule = ($attribute->is_required ? 'required|' : 'nullable|').$type;
            $rules[$attributeSlug.($attribute->is_collection ? '.*' : '')] = $rule;
        });

        $rules['roles'] = 'nullable|array';
        $rules['abilities'] = 'nullable|array';
        $rules['password'] = $user->exists
            ? 'confirmed|min:'.config('rinvex.fort.password_min_chars')
            : 'required|confirmed|min:'.config('rinvex.fort.password_min_chars');

        return $rules;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Fort\Http\Requests\Adminarea;
6
7			use Carbon\Carbon;
8			use Illuminate\Foundation\Http\FormRequest;
9
10			class UserFormRequest extends FormRequest
11			{
12			/**
13			* Determine if the user is authorized to make this request.
14			*
15			* @return bool
16			*/
17			public function authorize()
18			{
19			return true;
20			}
21
22			/**
23			* Prepare the data for validation.
24			*
25			* @return void
26			*/
27			protected function prepareForValidation()
28			{
29			$data = $this->all();
30
31			$user = $this->route('user') ?? app('rinvex.fort.user');
32			$country = $data['country_code'] ?? null;
33			$twoFactor = $user->getTwoFactor();
34
35			$data['email_verified'] = $this->get('email_verified', false);
36			$data['phone_verified'] = $this->get('phone_verified', false);
37
38			if ($user->exists && empty($data['password'])) {
39			unset($data['password'], $data['password_confirmation']);
40			}
41
42			// Update email verification date
43			if ($data['email_verified'] && $user->email_verified !== $data['email_verified']) {
44			$data['email_verified_at'] = Carbon::now();
45			}
46
47			// Update phone verification date
48			if ($data['phone_verified'] && $user->phone_verified !== $data['phone_verified']) {
49			$data['phone_verified_at'] = Carbon::now();
50			}
51
52			// Set abilities
53			if ($this->user()->can('grant-abilities') && $data['abilities']) {
54			$data['abilities'] = $this->user()->isSuperadmin() ? $data['abilities']
55			: array_intersect($this->user()->allAbilities->pluck('id')->toArray(), $data['abilities']);
56			} else {
57			unset($data['abilities']);
58			}
59
60			// Set roles
61			if ($this->user()->can('assign-roles') && $data['roles']) {
62			$data['roles'] = $this->user()->isSuperadmin() ? $data['roles']
63			: array_intersect($this->user()->roles->pluck('id')->toArray(), $data['roles']);
64			} else {
65			unset($data['roles']);
66			}
67
68			if ($twoFactor && (isset($data['phone_verified_at']) \|\| $country !== $user->country_code)) {
69			array_set($twoFactor, 'phone.enabled', false);
70			$data['two_factor'] = $twoFactor;
71			}
72
73			$this->replace($data);
74			}
75
76			/**
77			* Get the validation rules that apply to the request.
78			*
79			* @return array
			0 ignored issues – show Documentation introduced 2017-03-07 05:11 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `array<string,string>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
80			*/
81			public function rules()
82			{
83			$user = $this->route('user') ?? app('rinvex.fort.user');
84			$user->updateRulesUniques();
85			$rules = $user->getRules();
86
87			// Attach attribute rules
88			$user->getEntityAttributes()->each(function ($attribute, $attributeSlug) use (&$rules) {
89			switch ($attribute->type) {
90			case 'datetime':
			0 ignored issues – show Coding Style introduced 2018-01-04 01:06 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
91			$type = 'date';
92			break;
93			case 'text':
			0 ignored issues – show Coding Style introduced 2018-01-04 01:06 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
94			case 'varchar':
			0 ignored issues – show Coding Style introduced 2018-01-04 01:06 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
95			$type = 'string';
96			break;
97			default:
			0 ignored issues – show Coding Style introduced 2018-01-04 01:06 UTC by Report Bug Copy Issue Report DEFAULT statements must be defined using a colon As per the PSR-2 coding standard, default statements should not be wrapped in curly braces. switch ($expr) { default: { //wrong doSomething(); break; } } switch ($expr) { default: //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
98			$type = $attribute->type;
99			break;
100			}
101
102			$rule = ($attribute->is_required ? 'required\|' : 'nullable\|').$type;
103			$rules[$attributeSlug.($attribute->is_collection ? '.*' : '')] = $rule;
104			});
105
106			$rules['roles'] = 'nullable\|array';
107			$rules['abilities'] = 'nullable\|array';
108			$rules['password'] = $user->exists
109			? 'confirmed\|min:'.config('rinvex.fort.password_min_chars')
110			: 'required\|confirmed\|min:'.config('rinvex.fort.password_min_chars');
111
112			return $rules;
113			}
114			}
115

rinvex / cortex-auth

Push — develop ( 87574f...25eb07 )

UserFormRequest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like