SocialAuthenticationController::handleProviderCallback() - Code Metrics - Inspection of "Merge branch 'release/v0.0.3'" - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 20a6e3...887da8 )

by Abdelrahman

created 2018-09-21 21:54 UTC

handleProviderCallback() B

↳ Parent: SocialAuthenticationController

Complexity

Conditions	7
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	46
rs	8.2448
c	0
b	0
f	0
cc	7
nc	12
nop	2

<?php

declare(strict_types=1);

namespace Cortex\Auth\Http\Controllers\Adminarea;

use Illuminate\Http\Request;
use Illuminate\Auth\Events\Registered;
use Laravel\Socialite\Facades\Socialite;
use Illuminate\Database\Eloquent\Builder;
use Cortex\Foundation\Http\Controllers\AbstractController;

class SocialAuthenticationController extends AbstractController
{
    /**
     * Redirect the user to the provider authentication page.
     *
     * @param string $provider
     *
     * @return \Illuminate\Http\Response
     */
    public function redirectToProvider(string $provider)
    {
        return Socialite::driver($provider)->redirect();
    }

    /**
     * Obtain the user information from Provider.
     *
     * @param \Illuminate\Http\Request $request
     * @param string                   $provider
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function handleProviderCallback(Request $request, string $provider)

    {
        $providerUser = Socialite::driver($provider)->user();
        $fullName = explode(' ', $providerUser->name);

        $attributes = [
            'id' => $providerUser->id,
            'email' => $providerUser->email,
            'username' => $providerUser->nickname ?? trim(mb_strstr($providerUser->email, '@', true)),
            'given_name' => current($fullName),
            'family_name' => end($fullName),
        ];

        switch ($provider) {
            case 'twitter':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                $attributes['title'] = $providerUser->user['description'];
                $attributes['profile_picture'] = $providerUser->avatar_original;
                break;
            case 'github':
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                $attributes['title'] = $providerUser->user['bio'];
                $attributes['profile_picture'] = $providerUser->avatar;
                break;
            case 'facebook':
                $attributes['profile_picture'] = $providerUser->avatar_original;
                break;
            case 'linkedin':
                $attributes['title'] = $providerUser->headline;
                $attributes['profile_picture'] = $providerUser->avatar_original;
                break;
            case 'google':
                $attributes['title'] = $providerUser->tagline;
                $attributes['profile_picture'] = $providerUser->avatar_original;
                break;
        }

        if (! ($localUser = $this->getLocalUser($provider, $providerUser->id))) {
            $localUser = $this->createLocalUser($provider, $attributes);
        }

        auth()->guard($this->getGuard())->login($localUser, true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return intend([
            'intended' => route('adminarea.home'),
            'with' => ['success' => trans('cortex/auth::messages.auth.login')],
        ]);
    }

    /**
     * Get local user for the given provider.
     *
     * @param string $provider
     * @param string $providerUserId
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    protected function getLocalUser(string $provider, string $providerUserId)
    {
        return app('cortex.auth.admin')->whereHas('socialites', function (Builder $builder) use ($provider, $providerUserId) {

            $builder->where('provider', $provider)->where('provider_uid', $providerUserId);
        })->first();
    }

    /**
     * Create local user for the given provider.
     *
     * @param string $provider
     * @param array  $attributes
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    protected function createLocalUser(string $provider, array $attributes)
    {
        $localUser = app('cortex.auth.admin');

        $attributes['password'] = str_random();
        $attributes['email_verified'] = true;
        $attributes['email_verified_at'] = now();
        $attributes['is_active'] = ! config('cortex.auth.registration.moderated');

        $localUser->fill($attributes)->save();

        // Fire the register success event
        event(new Registered($localUser));

        $localUser->socialites()->create([
            'provider' => $provider,
            'provider_uid' => $attributes['id'],
        ]);

        return $localUser;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Auth\Http\Controllers\Adminarea;
6
7			use Illuminate\Http\Request;
8			use Illuminate\Auth\Events\Registered;
9			use Laravel\Socialite\Facades\Socialite;
10			use Illuminate\Database\Eloquent\Builder;
11			use Cortex\Foundation\Http\Controllers\AbstractController;
12
13			class SocialAuthenticationController extends AbstractController
14			{
15			/**
16			* Redirect the user to the provider authentication page.
17			*
18			* @param string $provider
19			*
20			* @return \Illuminate\Http\Response
21			*/
22			public function redirectToProvider(string $provider)
23			{
24			return Socialite::driver($provider)->redirect();
25			}
26
27			/**
28			* Obtain the user information from Provider.
29			*
30			* @param \Illuminate\Http\Request $request
31			* @param string $provider
32			*
33			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
34			*/
35			public function handleProviderCallback(Request $request, string $provider)
			0 ignored issues – show Unused Code introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
36			{
37			$providerUser = Socialite::driver($provider)->user();
38			$fullName = explode(' ', $providerUser->name);
39
40			$attributes = [
41			'id' => $providerUser->id,
42			'email' => $providerUser->email,
43			'username' => $providerUser->nickname ?? trim(mb_strstr($providerUser->email, '@', true)),
44			'given_name' => current($fullName),
45			'family_name' => end($fullName),
46			];
47
48			switch ($provider) {
49			case 'twitter':
			0 ignored issues – show Coding Style introduced 2018-01-05 07:46 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
50			$attributes['title'] = $providerUser->user['description'];
51			$attributes['profile_picture'] = $providerUser->avatar_original;
52			break;
53			case 'github':
			0 ignored issues – show Coding Style introduced 2018-01-05 07:46 UTC by Report Bug Copy Issue Report `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
54			$attributes['title'] = $providerUser->user['bio'];
55			$attributes['profile_picture'] = $providerUser->avatar;
56			break;
57			case 'facebook':
58			$attributes['profile_picture'] = $providerUser->avatar_original;
59			break;
60			case 'linkedin':
61			$attributes['title'] = $providerUser->headline;
62			$attributes['profile_picture'] = $providerUser->avatar_original;
63			break;
64			case 'google':
65			$attributes['title'] = $providerUser->tagline;
66			$attributes['profile_picture'] = $providerUser->avatar_original;
67			break;
68			}
69
70			if (! ($localUser = $this->getLocalUser($provider, $providerUser->id))) {
71			$localUser = $this->createLocalUser($provider, $attributes);
72			}
73
74			auth()->guard($this->getGuard())->login($localUser, true);
			0 ignored issues – show Bug introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report The method `guard` does only exist in `Illuminate\Contracts\Auth\Factory`, but not in `Illuminate\Contracts\Auth\Guard`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
75
76			return intend([
77			'intended' => route('adminarea.home'),
78			'with' => ['success' => trans('cortex/auth::messages.auth.login')],
79			]);
80			}
81
82			/**
83			* Get local user for the given provider.
84			*
85			* @param string $provider
86			* @param string $providerUserId
87			*
88			* @return \Illuminate\Database\Eloquent\Model\|null
89			*/
90			protected function getLocalUser(string $provider, string $providerUserId)
91			{
92			return app('cortex.auth.admin')->whereHas('socialites', function (Builder $builder) use ($provider, $providerUserId) {
			0 ignored issues – show Coding Style introduced 2018-01-05 07:46 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 126 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
93			$builder->where('provider', $provider)->where('provider_uid', $providerUserId);
94			})->first();
95			}
96
97			/**
98			* Create local user for the given provider.
99			*
100			* @param string $provider
101			* @param array $attributes
102			*
103			* @return \Illuminate\Database\Eloquent\Model\|null
104			*/
105			protected function createLocalUser(string $provider, array $attributes)
106			{
107			$localUser = app('cortex.auth.admin');
108
109			$attributes['password'] = str_random();
110			$attributes['email_verified'] = true;
111			$attributes['email_verified_at'] = now();
112			$attributes['is_active'] = ! config('cortex.auth.registration.moderated');
113
114			$localUser->fill($attributes)->save();
115
116			// Fire the register success event
117			event(new Registered($localUser));
118
119			$localUser->socialites()->create([
120			'provider' => $provider,
121			'provider_uid' => $attributes['id'],
122			]);
123
124			return $localUser;
125			}
126			}
127

rinvex / cortex-auth

Push — master ( 20a6e3...887da8 )

handleProviderCallback() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like