rinvex /
cortex-auth
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 71 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 14 | public function run() |
||
| 15 | { |
||
| 16 | Bouncer::allow('superadmin')->everything(); |
||
| 17 | |||
| 18 | Bouncer::allow('admin')->to('list', config('cortex.auth.models.ability')); |
||
| 19 | Bouncer::allow('admin')->to('import', config('cortex.auth.models.ability')); |
||
| 20 | Bouncer::allow('admin')->to('create', config('cortex.auth.models.ability')); |
||
| 21 | Bouncer::allow('admin')->to('update', config('cortex.auth.models.ability')); |
||
| 22 | Bouncer::allow('admin')->to('delete', config('cortex.auth.models.ability')); |
||
| 23 | Bouncer::allow('admin')->to('audit', config('cortex.auth.models.ability')); |
||
| 24 | Bouncer::allow('admin')->to('grant', config('cortex.auth.models.ability')); |
||
| 25 | |||
| 26 | Bouncer::allow('admin')->to('list', config('cortex.auth.models.role')); |
||
| 27 | Bouncer::allow('admin')->to('import', config('cortex.auth.models.role')); |
||
| 28 | Bouncer::allow('admin')->to('create', config('cortex.auth.models.role')); |
||
| 29 | Bouncer::allow('admin')->to('update', config('cortex.auth.models.role')); |
||
| 30 | Bouncer::allow('admin')->to('delete', config('cortex.auth.models.role')); |
||
| 31 | Bouncer::allow('admin')->to('audit', config('cortex.auth.models.role')); |
||
| 32 | Bouncer::allow('admin')->to('assign', config('cortex.auth.models.role')); |
||
| 33 | |||
| 34 | Bouncer::allow('admin')->to('list', config('cortex.auth.models.admin')); |
||
| 35 | Bouncer::allow('admin')->to('import', config('cortex.auth.models.admin')); |
||
| 36 | Bouncer::allow('admin')->to('create', config('cortex.auth.models.admin')); |
||
| 37 | Bouncer::allow('admin')->to('update', config('cortex.auth.models.admin')); |
||
| 38 | Bouncer::allow('admin')->to('delete', config('cortex.auth.models.admin')); |
||
| 39 | Bouncer::allow('admin')->to('audit', config('cortex.auth.models.admin')); |
||
| 40 | |||
| 41 | Bouncer::allow('admin')->to('list', config('cortex.auth.models.member')); |
||
| 42 | Bouncer::allow('admin')->to('import', config('cortex.auth.models.member')); |
||
| 43 | Bouncer::allow('admin')->to('create', config('cortex.auth.models.member')); |
||
| 44 | Bouncer::allow('admin')->to('update', config('cortex.auth.models.member')); |
||
| 45 | Bouncer::allow('admin')->to('delete', config('cortex.auth.models.member')); |
||
| 46 | Bouncer::allow('admin')->to('audit', config('cortex.auth.models.member')); |
||
| 47 | |||
| 48 | Bouncer::allow('admin')->to('list', config('cortex.auth.models.manager')); |
||
| 49 | Bouncer::allow('admin')->to('import', config('cortex.auth.models.manager')); |
||
| 50 | Bouncer::allow('admin')->to('create', config('cortex.auth.models.manager')); |
||
| 51 | Bouncer::allow('admin')->to('update', config('cortex.auth.models.manager')); |
||
| 52 | Bouncer::allow('admin')->to('delete', config('cortex.auth.models.manager')); |
||
| 53 | Bouncer::allow('admin')->to('audit', config('cortex.auth.models.manager')); |
||
| 54 | |||
| 55 | Bouncer::allow('admin')->to('list', config('cortex.auth.models.guardian')); |
||
| 56 | Bouncer::allow('admin')->to('import', config('cortex.auth.models.guardian')); |
||
| 57 | Bouncer::allow('admin')->to('create', config('cortex.auth.models.guardian')); |
||
| 58 | Bouncer::allow('admin')->to('update', config('cortex.auth.models.guardian')); |
||
| 59 | Bouncer::allow('admin')->to('delete', config('cortex.auth.models.guardian')); |
||
| 60 | Bouncer::allow('admin')->to('audit', config('cortex.auth.models.guardian')); |
||
| 61 | |||
| 62 | Bouncer::allow('owner')->to('list', config('cortex.auth.models.role')); |
||
| 63 | Bouncer::allow('owner')->to('import', config('cortex.auth.models.role')); |
||
| 64 | Bouncer::allow('owner')->to('create', config('cortex.auth.models.role')); |
||
| 65 | Bouncer::allow('owner')->to('update', config('cortex.auth.models.role')); |
||
| 66 | Bouncer::allow('owner')->to('delete', config('cortex.auth.models.role')); |
||
| 67 | Bouncer::allow('owner')->to('audit', config('cortex.auth.models.role')); |
||
| 68 | Bouncer::allow('owner')->to('assign', config('cortex.auth.models.role')); |
||
| 69 | |||
| 70 | Bouncer::allow('owner')->to('list', config('cortex.auth.models.member')); |
||
| 71 | Bouncer::allow('owner')->to('import', config('cortex.auth.models.member')); |
||
| 72 | Bouncer::allow('owner')->to('create', config('cortex.auth.models.member')); |
||
| 73 | Bouncer::allow('owner')->to('update', config('cortex.auth.models.member')); |
||
| 74 | Bouncer::allow('owner')->to('delete', config('cortex.auth.models.member')); |
||
| 75 | Bouncer::allow('owner')->to('audit', config('cortex.auth.models.member')); |
||
| 76 | |||
| 77 | Bouncer::allow('owner')->to('list', config('cortex.auth.models.manager')); |
||
| 78 | Bouncer::allow('owner')->to('import', config('cortex.auth.models.manager')); |
||
| 79 | Bouncer::allow('owner')->to('create', config('cortex.auth.models.manager')); |
||
| 80 | Bouncer::allow('owner')->to('update', config('cortex.auth.models.manager')); |
||
| 81 | Bouncer::allow('owner')->to('delete', config('cortex.auth.models.manager')); |
||
| 82 | Bouncer::allow('owner')->to('audit', config('cortex.auth.models.manager')); |
||
| 83 | Bouncer::allow('owner')->to('grant', config('cortex.auth.models.ability')); |
||
| 84 | } |
||
| 85 | } |
||
| 86 |
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.