Cortex\Fort\Http\Controllers\Managerarea\UsersController

Complexity

Total Complexity

19

Size/Duplication

Total Lines	176
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes	6
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	7	1
A	logs()	0	6	3
A	activities()	0	6	3
B	process()	0	27	3
B	form()	0	21	5
A	store()	0	4	1
A	update()	0	4	1
A	delete()	0	9	1
A	deleteMedia()	0	9	1

<?php

declare(strict_types=1);

namespace Cortex\Fort\Http\Controllers\Managerarea;

use Illuminate\Http\Request;
use Spatie\MediaLibrary\Models\Media;
use Rinvex\Fort\Contracts\UserContract;
use Illuminate\Foundation\Http\FormRequest;
use Cortex\Foundation\DataTables\LogsDataTable;
use Cortex\Foundation\DataTables\ActivitiesDataTable;
use Cortex\Fort\DataTables\Managerarea\UsersDataTable;
use Cortex\Fort\Http\Requests\Managerarea\UserFormRequest;
use Cortex\Foundation\Http\Controllers\AuthorizedController;

class UsersController extends AuthorizedController
{
    /**
     * {@inheritdoc}
     */
    protected $resource = 'users';

    /**
     * Display a listing of the resource.
     *
     * @param \Cortex\Fort\DataTables\Managerarea\UsersDataTable $usersDataTable
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View
     */
    public function index(UsersDataTable $usersDataTable)
    {
        return $usersDataTable->with([
            'id' => 'cortex-users',
            'phrase' => trans('cortex/fort::common.users'),
        ])->render('cortex/tenants::managerarea.pages.datatable');
    }

    /**
     * Get a listing of the resource logs.
     *
     * @param \Rinvex\Fort\Contracts\UserContract $user
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function logs(UserContract $user)
    {
        return request()->ajax() && request()->wantsJson()
            ? app(LogsDataTable::class)->with(['resource' => $user])->ajax()
            : intend(['url' => route('adminarea.users.edit', ['user' => $user]).'#logs-tab']);
    }

    /**
     * Get a listing of the resource activities.
     *
     * @param \Rinvex\Fort\Contracts\UserContract $user
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function activities(UserContract $user)
    {
        return request()->ajax() && request()->wantsJson()
            ? app(ActivitiesDataTable::class)->with(['resource' => $user])->ajax()
            : intend(['url' => route('adminarea.users.edit', ['user' => $user]).'#activities-tab']);
    }

    /**
     * Show the form for create/update of the given resource.
     *
     * @param \Illuminate\Http\Request            $request
     * @param \Rinvex\Fort\Contracts\UserContract $user
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function form(Request $request, UserContract $user)
    {
        $countries = countries();
        $authUser = $request->user($this->getGuard());
        $languages = collect(languages())->pluck('name', 'iso_639_1');
        $genders = ['m' => trans('cortex/fort::common.male'), 'f' => trans('cortex/fort::common.female')];
        $owner = optional(optional(config('rinvex.tenants.active'))->owner)->id;

The property id does not seem to exist in Illuminate\Support\Optional.

        $roles = $authUser->isSuperadmin() || $authUser->id === $owner
            ? app('rinvex.fort.role')->all()->pluck('name', 'id')->toArray()
            : $authUser->roles->pluck('name', 'id')->toArray();

        $abilities = $authUser->isSuperadmin() || $authUser->id === $owner
            ? app('rinvex.fort.role')->forAllTenants()->where('slug', 'manager')->first()->abilities->groupBy('resource')->map->pluck('name', 'id')->toArray()

This line exceeds maximum limit of 120 characters; contains 158 characters

            : $authUser->allAbilities->groupBy('resource')->map->pluck('name', 'id')->toArray();

        $logs = app(LogsDataTable::class)->with(['id' => 'logs-table'])->html()->minifiedAjax(route('managerarea.users.logs', ['user' => $user]));

This line exceeds maximum limit of 120 characters; contains 146 characters

        $activities = app(ActivitiesDataTable::class)->with(['id' => 'activities-table'])->html()->minifiedAjax(route('managerarea.users.activities', ['user' => $user]));

This line exceeds maximum limit of 120 characters; contains 170 characters

        return view('cortex/fort::managerarea.pages.user', compact('user', 'abilities', 'roles', 'countries', 'languages', 'genders', 'logs', 'activities'));

This line exceeds maximum limit of 120 characters; contains 157 characters

    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \Cortex\Fort\Http\Requests\Managerarea\UserFormRequest $request
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse?

     */
    public function store(UserFormRequest $request)
    {
        return $this->process($request, app('rinvex.fort.user'));
    }

    /**
     * Update the given resource in storage.
     *
     * @param \Cortex\Fort\Http\Requests\Managerarea\UserFormRequest $request
     * @param \Rinvex\Fort\Contracts\UserContract                    $user
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse?

     */
    public function update(UserFormRequest $request, UserContract $user)
    {
        return $this->process($request, $user);
    }

    /**
     * Process the form for store/update of the given resource.
     *
     * @param \Illuminate\Foundation\Http\FormRequest $request
     * @param \Rinvex\Fort\Contracts\UserContract     $user
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse?

     */
    protected function process(FormRequest $request, UserContract $user)
    {
        // Prepare required input fields
        $data = $request->validated();

        ! $request->hasFile('profile_picture')
        || $user->addMediaFromRequest('profile_picture')

It seems like you code against a concrete implementation and not the interface Rinvex\Fort\Contracts\UserContract as the method addMediaFromRequest() does only exist in the following implementations of said interface: Cortex\Fort\Models\User.

                ->sanitizingFileName(function ($fileName) {
                    return md5($fileName).'.'.pathinfo($fileName, PATHINFO_EXTENSION);
                })
                ->toMediaCollection('profile_picture', config('cortex.fort.media.disk'));

        ! $request->hasFile('cover_photo')
        || $user->addMediaFromRequest('cover_photo')

It seems like you code against a concrete implementation and not the interface Rinvex\Fort\Contracts\UserContract as the method addMediaFromRequest() does only exist in the following implementations of said interface: Cortex\Fort\Models\User.

                ->sanitizingFileName(function ($fileName) {
                    return md5($fileName).'.'.pathinfo($fileName, PATHINFO_EXTENSION);
                })
                ->toMediaCollection('cover_photo', config('cortex.fort.media.disk'));

        // Save user
        $user->fill($data)->save();

        return intend([
            'url' => route('managerarea.users.index'),
            'with' => ['success' => trans('cortex/fort::messages.user.saved', ['username' => $user->username])],

Accessing username on the interface Rinvex\Fort\Contracts\UserContract suggest that you code against a concrete implementation. How about adding an instanceof check?

        ]);
    }

    /**
     * Delete the given resource from storage.
     *
     * @param \Rinvex\Fort\Contracts\UserContract $user
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse?

     */
    public function delete(UserContract $user)
    {
        $user->delete();

        return intend([
            'url' => route('managerarea.users.index'),
            'with' => ['warning' => trans('cortex/fort::messages.user.deleted', ['username' => $user->username])],

Accessing username on the interface Rinvex\Fort\Contracts\UserContract suggest that you code against a concrete implementation. How about adding an instanceof check?

        ]);
    }

    /**
     * Delete the given resource from storage.
     *
     * @param \Rinvex\Fort\Contracts\UserContract $user
     * @param \Spatie\MediaLibrary\Models\Media   $media
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\Http\JsonResponse
     */
    public function deleteMedia(UserContract $user, Media $media)
    {
        $user->media()->where('id', $media->id)->first()->delete();

It seems like you code against a concrete implementation and not the interface Rinvex\Fort\Contracts\UserContract as the method media() does only exist in the following implementations of said interface: Cortex\Fort\Models\User.

        return intend([
            'url' => route('adminarea.users.edit', ['user' => $user]),
            'with' => ['warning' => trans('cortex/fort::messages.user.media_deleted')],
        ]);
    }
}