AbilityFormRequest::authorize() - Code Metrics - Inspection of "Check role/ability existence in form request befor..." - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 508664...7b00fe )

by Abdelrahman

created 2018-02-21 20:06 UTC

AbilityFormRequest::authorize() A

↳ Parent: AbilityFormRequest

Complexity

Conditions	4
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.2
c	0
b	0
f	0
cc	4
eloc	5
nc	2
nop	0

<?php

declare(strict_types=1);

namespace Cortex\Auth\Http\Requests\Adminarea;

use Illuminate\Foundation\Http\FormRequest;
use Cortex\Foundation\Exceptions\GenericException;

class AbilityFormRequest extends FormRequest
{
    /**
     * Determine if the user is authorized to make this request.
     *
     * @throws \Cortex\Foundation\Exceptions\GenericException
     *
     * @return bool
     */
    public function authorize(): bool
    {
        $currentUser = $this->user($this->route('guard'));

        if (optional($this->route('ability'))->exists && ! $currentUser->can('superadmin') && ! $currentUser->getAbilities()->contains($this->route('ability'))) {

            throw new GenericException(trans('cortex/auth::messages.action_unauthorized'), route('adminarea.abilities.index'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return true;
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules(): array
    {
        return [];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Auth\Http\Requests\Adminarea;
6
7			use Illuminate\Foundation\Http\FormRequest;
8			use Cortex\Foundation\Exceptions\GenericException;
9
10			class AbilityFormRequest extends FormRequest
11			{
12			/**
13			* Determine if the user is authorized to make this request.
14			*
15			* @throws \Cortex\Foundation\Exceptions\GenericException
16			*
17			* @return bool
18			*/
19			public function authorize(): bool
20			{
21			$currentUser = $this->user($this->route('guard'));
22
23			if (optional($this->route('ability'))->exists && ! $currentUser->can('superadmin') && ! $currentUser->getAbilities()->contains($this->route('ability'))) {
			0 ignored issues – show Coding Style introduced 2018-02-21 20:07 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 162 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
24			throw new GenericException(trans('cortex/auth::messages.action_unauthorized'), route('adminarea.abilities.index'));
			0 ignored issues – show Documentation introduced 2018-02-21 20:07 UTC by Report Bug Copy Issue Report `route('adminarea.abilities.index')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Coding Style introduced 2018-02-21 20:07 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 127 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
25			}
26
27			return true;
28			}
29
30			/**
31			* Get the validation rules that apply to the request.
32			*
33			* @return array
34			*/
35			public function rules(): array
36			{
37			return [];
38			}
39			}
40

rinvex / cortex-auth

Push — develop ( 508664...7b00fe )

AbilityFormRequest::authorize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like