Authenticate::handle() - Code Metrics - Inspection of "Remove useless imports" - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 10b573...34b970 )

by Abdelrahman

created 2018-01-31 14:16 UTC

Authenticate::handle() A

↳ Parent: Authenticate

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	6
nc	2
nop	3
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Cortex\Fort\Http\Middleware;

use Closure;

class Authenticate
{
    /**
     * Handle an incoming request.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Closure                 $next
     * @param string|null              $guard
     *
     * @return mixed
     */
    public function handle($request, Closure $next, $guard = null)
    {
        if (auth()->guard($guard)->guest()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            return intend([
                'url' => route('frontarea.login'),
                'with' => ['warning' => trans('cortex/foundation::messages.session_required')],
            ]);
        }

        return $next($request);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Fort\Http\Middleware;
6
7			use Closure;
8
9			class Authenticate
10			{
11			/**
12			* Handle an incoming request.
13			*
14			* @param \Illuminate\Http\Request $request
15			* @param \Closure $next
16			* @param string\|null $guard
17			*
18			* @return mixed
19			*/
20			public function handle($request, Closure $next, $guard = null)
21			{
22			if (auth()->guard($guard)->guest()) {
			0 ignored issues – show Bug introduced 2018-01-31 14:25 UTC by Report Bug Copy Issue Report The method `guard` does only exist in `Illuminate\Contracts\Auth\Factory`, but not in `Illuminate\Contracts\Auth\Guard`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
23			return intend([
24			'url' => route('frontarea.login'),
25			'with' => ['warning' => trans('cortex/foundation::messages.session_required')],
26			]);
27			}
28
29			return $next($request);
30			}
31			}
32

rinvex / cortex-auth

Push — develop ( 10b573...34b970 )

Authenticate::handle() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like