ManagerFormRequest::prepareForValidation() - Code Metrics - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

ManagerFormRequest::prepareForValidation() C
last analyzed 2019-09-03 21:54 UTC

↳ Parent: ManagerFormRequest

Complexity

Conditions	13
Paths	64

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	41
rs	6.6166
c	0
b	0
f	0
cc	13
nc	64
nop	0

How to fix Complexity

<?php

declare(strict_types=1);

namespace Cortex\Auth\Http\Requests\Managerarea;

use Rinvex\Support\Traits\Escaper;
use Illuminate\Foundation\Http\FormRequest;
use Cortex\Foundation\Exceptions\GenericException;

class ManagerFormRequest extends FormRequest
{
    use Escaper;

    /**
     * Determine if the user is authorized to make this request.
     *
     * @throws \Cortex\Foundation\Exceptions\GenericException
     *
     * @return bool
     */
    public function authorize(): bool
    {
        $currentUser = $this->user($this->route('guard'));

        if (! $currentUser->isA('supermanager') && $currentUser !== $this->route('manager')) {
            throw new GenericException(trans('cortex/auth::messages.action_unauthorized'), route('managerarea.managers.index'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }

        return true;
    }

    /**
     * Prepare the data for validation.
     *
     * @return void
     */
    protected function prepareForValidation(): void
    {
        $data = $this->all();

        $manager = $this->route('manager') ?? app('cortex.auth.manager');
        $country = $data['country_code'] ?? null;
        $twoFactor = $manager->getTwoFactor();

        if ($manager->exists && empty($data['password'])) {
            unset($data['password'], $data['password_confirmation']);
        }

        // Set abilities
        if (! empty($data['abilities'])) {
            if ($this->user($this->route('guard'))->can('grant', \Cortex\Auth\Models\Ability::class)) {
                $abilities = array_map('intval', $this->get('abilities', []));
                $data['abilities'] = $this->user($this->route('guard'))->isA('superadmin') ? $abilities
                    : $this->user($this->route('guard'))->getAbilities()->pluck('id')->intersect($abilities)->toArray();
            } else {
                unset($data['abilities']);
            }
        }

        // Set roles
        if (! empty($data['roles'])) {
            if ($data['roles'] && $this->user($this->route('guard'))->can('assign', \Cortex\Auth\Models\Role::class)) {
                $roles = array_map('intval', $this->get('roles', []));
                $data['roles'] = $this->user($this->route('guard'))->isA('superadmin') ? $roles
                    : $this->user($this->route('guard'))->roles->pluck('id')->intersect($roles)->toArray();
            } else {
                unset($data['roles']);
            }
        }

        if ($twoFactor && (isset($data['phone_verified_at']) || $country !== $manager->country_code)) {
            array_set($twoFactor, 'phone.enabled', false);

            $data['two_factor'] = $twoFactor;
        }

        $this->replace($data);
    }

    /**
     * Get the validation rules that apply to the request.
     *
     * @return array
     */
    public function rules(): array
    {
        $manager = $this->route('manager') ?? app('cortex.auth.manager');
        $manager->updateRulesUniques();
        $rules = $manager->getRules();

        $rules['roles'] = 'nullable|array';
        $rules['abilities'] = 'nullable|array';
        $rules['password'] = $manager->exists
            ? 'confirmed|min:'.config('cortex.auth.password_min_chars')
            : 'required|confirmed|min:'.config('cortex.auth.password_min_chars');

        return $this->isMethod('POST') ? $rules : [];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Auth\Http\Requests\Managerarea;
6
7			use Rinvex\Support\Traits\Escaper;
8			use Illuminate\Foundation\Http\FormRequest;
9			use Cortex\Foundation\Exceptions\GenericException;
10
11			class ManagerFormRequest extends FormRequest
12			{
13			use Escaper;
14
15			/**
16			* Determine if the user is authorized to make this request.
17			*
18			* @throws \Cortex\Foundation\Exceptions\GenericException
19			*
20			* @return bool
21			*/
22			public function authorize(): bool
23			{
24			$currentUser = $this->user($this->route('guard'));
25
26			if (! $currentUser->isA('supermanager') && $currentUser !== $this->route('manager')) {
27			throw new GenericException(trans('cortex/auth::messages.action_unauthorized'), route('managerarea.managers.index'));
			0 ignored issues – show Documentation introduced 2019-08-02 21:42 UTC by Report Bug Copy Issue Report `route('managerarea.managers.index')` is of type `string`, but the function expects a `array\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			}
29
30			return true;
31			}
32
33			/**
34			* Prepare the data for validation.
35			*
36			* @return void
37			*/
38			protected function prepareForValidation(): void
39			{
40			$data = $this->all();
41
42			$manager = $this->route('manager') ?? app('cortex.auth.manager');
43			$country = $data['country_code'] ?? null;
44			$twoFactor = $manager->getTwoFactor();
45
46			if ($manager->exists && empty($data['password'])) {
47			unset($data['password'], $data['password_confirmation']);
48			}
49
50			// Set abilities
51			if (! empty($data['abilities'])) {
52			if ($this->user($this->route('guard'))->can('grant', \Cortex\Auth\Models\Ability::class)) {
53			$abilities = array_map('intval', $this->get('abilities', []));
54			$data['abilities'] = $this->user($this->route('guard'))->isA('superadmin') ? $abilities
55			: $this->user($this->route('guard'))->getAbilities()->pluck('id')->intersect($abilities)->toArray();
56			} else {
57			unset($data['abilities']);
58			}
59			}
60
61			// Set roles
62			if (! empty($data['roles'])) {
63			if ($data['roles'] && $this->user($this->route('guard'))->can('assign', \Cortex\Auth\Models\Role::class)) {
64			$roles = array_map('intval', $this->get('roles', []));
65			$data['roles'] = $this->user($this->route('guard'))->isA('superadmin') ? $roles
66			: $this->user($this->route('guard'))->roles->pluck('id')->intersect($roles)->toArray();
67			} else {
68			unset($data['roles']);
69			}
70			}
71
72			if ($twoFactor && (isset($data['phone_verified_at']) \|\| $country !== $manager->country_code)) {
73			array_set($twoFactor, 'phone.enabled', false);
			0 ignored issues – show Deprecated Code introduced 2019-08-02 21:42 UTC by Report Bug Copy Issue Report The function `array_set()` has been deprecated with message: Arr::set() should be used directly instead. Will be removed in Laravel 6.0. This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
74			$data['two_factor'] = $twoFactor;
75			}
76
77			$this->replace($data);
78			}
79
80			/**
81			* Get the validation rules that apply to the request.
82			*
83			* @return array
84			*/
85			public function rules(): array
86			{
87			$manager = $this->route('manager') ?? app('cortex.auth.manager');
88			$manager->updateRulesUniques();
89			$rules = $manager->getRules();
90
91			$rules['roles'] = 'nullable\|array';
92			$rules['abilities'] = 'nullable\|array';
93			$rules['password'] = $manager->exists
94			? 'confirmed\|min:'.config('cortex.auth.password_min_chars')
95			: 'required\|confirmed\|min:'.config('cortex.auth.password_min_chars');
96
97			return $this->isMethod('POST') ? $rules : [];
98			}
99			}
100

rinvex / cortex-auth

ManagerFormRequest::prepareForValidation() C last analyzed 2019-09-03 21:54 UTC

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

ManagerFormRequest::prepareForValidation() C
last analyzed 2019-09-03 21:54 UTC