SocialAuthenticationController::handleProviderCallback() - Code Metrics - rinvex/cortex-auth - Measure and Improve Code Quality continuously with Scrutinizer

handleProviderCallback() B
last analyzed 2019-09-03 21:54 UTC

↳ Parent: SocialAuthenticationController

Complexity

Conditions	7
Paths	12

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	46
rs	8.2448
c	0
b	0
f	0
cc	7
nc	12
nop	2

<?php

declare(strict_types=1);

namespace Cortex\Auth\Http\Controllers\Adminarea;

use Illuminate\Http\Request;
use Illuminate\Auth\Events\Registered;
use Laravel\Socialite\Facades\Socialite;
use Illuminate\Database\Eloquent\Builder;
use Cortex\Foundation\Http\Controllers\AbstractController;

class SocialAuthenticationController extends AbstractController
{
    /**
     * Redirect the user to the provider authentication page.
     *
     * @param string $provider
     *
     * @return \Illuminate\Http\Response
     */
    public function redirectToProvider(string $provider)
    {
        return Socialite::driver($provider)->redirect();
    }

    /**
     * Obtain the user information from Provider.
     *
     * @param \Illuminate\Http\Request $request
     * @param string                   $provider
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse
     */
    public function handleProviderCallback(Request $request, string $provider)

    {
        $providerUser = Socialite::driver($provider)->user();
        $fullName = explode(' ', $providerUser->name);

        $attributes = [
            'id' => $providerUser->id,
            'email' => $providerUser->email,
            'username' => $providerUser->nickname ?? trim(mb_strstr($providerUser->email, '@', true)),
            'given_name' => current($fullName),
            'family_name' => end($fullName),
        ];

        switch ($provider) {
            case 'twitter':
                $attributes['title'] = $providerUser->user['description'];
                $attributes['profile_picture'] = $providerUser->avatar_original;
                break;
            case 'github':
                $attributes['title'] = $providerUser->user['bio'];
                $attributes['profile_picture'] = $providerUser->avatar;
                break;
            case 'facebook':
                $attributes['profile_picture'] = $providerUser->avatar_original;
                break;
            case 'linkedin':
                $attributes['title'] = $providerUser->headline;
                $attributes['profile_picture'] = $providerUser->avatar_original;
                break;
            case 'google':
                $attributes['title'] = $providerUser->tagline;
                $attributes['profile_picture'] = $providerUser->avatar_original;
                break;
        }

        if (! ($localUser = $this->getLocalUser($provider, $providerUser->id))) {
            $localUser = $this->createLocalUser($provider, $attributes);
        }

        auth()->guard($this->getGuard())->login($localUser, true);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return intend([
            'intended' => route('adminarea.home'),
            'with' => ['success' => trans('cortex/auth::messages.auth.login')],
        ]);
    }

    /**
     * Get local user for the given provider.
     *
     * @param string $provider
     * @param string $providerUserId
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    protected function getLocalUser(string $provider, string $providerUserId)
    {
        return app('cortex.auth.admin')->whereHas('socialites', function (Builder $builder) use ($provider, $providerUserId) {
            $builder->where('provider', $provider)->where('provider_uid', $providerUserId);
        })->first();
    }

    /**
     * Create local user for the given provider.
     *
     * @param string $provider
     * @param array  $attributes
     *
     * @return \Illuminate\Database\Eloquent\Model|null
     */
    protected function createLocalUser(string $provider, array $attributes)
    {
        $localUser = app('cortex.auth.admin');

        $attributes['password'] = str_random();

        $attributes['email_verified_at'] = now();
        $attributes['is_active'] = ! config('cortex.auth.registration.moderated');

        $localUser->fill($attributes)->save();

        // Fire the register success event
        event(new Registered($localUser));

        $localUser->socialites()->create([
            'provider' => $provider,
            'provider_uid' => $attributes['id'],
        ]);

        return $localUser;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Auth\Http\Controllers\Adminarea;
6
7			use Illuminate\Http\Request;
8			use Illuminate\Auth\Events\Registered;
9			use Laravel\Socialite\Facades\Socialite;
10			use Illuminate\Database\Eloquent\Builder;
11			use Cortex\Foundation\Http\Controllers\AbstractController;
12
13			class SocialAuthenticationController extends AbstractController
14			{
15			/**
16			* Redirect the user to the provider authentication page.
17			*
18			* @param string $provider
19			*
20			* @return \Illuminate\Http\Response
21			*/
22			public function redirectToProvider(string $provider)
23			{
24			return Socialite::driver($provider)->redirect();
25			}
26
27			/**
28			* Obtain the user information from Provider.
29			*
30			* @param \Illuminate\Http\Request $request
31			* @param string $provider
32			*
33			* @return \Illuminate\Http\JsonResponse\|\Illuminate\Http\RedirectResponse
34			*/
35			public function handleProviderCallback(Request $request, string $provider)
			0 ignored issues – show Unused Code introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
36			{
37			$providerUser = Socialite::driver($provider)->user();
38			$fullName = explode(' ', $providerUser->name);
39
40			$attributes = [
41			'id' => $providerUser->id,
42			'email' => $providerUser->email,
43			'username' => $providerUser->nickname ?? trim(mb_strstr($providerUser->email, '@', true)),
44			'given_name' => current($fullName),
45			'family_name' => end($fullName),
46			];
47
48			switch ($provider) {
49			case 'twitter':
50			$attributes['title'] = $providerUser->user['description'];
51			$attributes['profile_picture'] = $providerUser->avatar_original;
52			break;
53			case 'github':
54			$attributes['title'] = $providerUser->user['bio'];
55			$attributes['profile_picture'] = $providerUser->avatar;
56			break;
57			case 'facebook':
58			$attributes['profile_picture'] = $providerUser->avatar_original;
59			break;
60			case 'linkedin':
61			$attributes['title'] = $providerUser->headline;
62			$attributes['profile_picture'] = $providerUser->avatar_original;
63			break;
64			case 'google':
65			$attributes['title'] = $providerUser->tagline;
66			$attributes['profile_picture'] = $providerUser->avatar_original;
67			break;
68			}
69
70			if (! ($localUser = $this->getLocalUser($provider, $providerUser->id))) {
71			$localUser = $this->createLocalUser($provider, $attributes);
72			}
73
74			auth()->guard($this->getGuard())->login($localUser, true);
			0 ignored issues – show Bug introduced 2018-01-26 04:59 UTC by Report Bug Copy Issue Report The method `guard` does only exist in `Illuminate\Contracts\Auth\Factory`, but not in `Illuminate\Contracts\Auth\Guard`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
75
76			return intend([
77			'intended' => route('adminarea.home'),
78			'with' => ['success' => trans('cortex/auth::messages.auth.login')],
79			]);
80			}
81
82			/**
83			* Get local user for the given provider.
84			*
85			* @param string $provider
86			* @param string $providerUserId
87			*
88			* @return \Illuminate\Database\Eloquent\Model\|null
89			*/
90			protected function getLocalUser(string $provider, string $providerUserId)
91			{
92			return app('cortex.auth.admin')->whereHas('socialites', function (Builder $builder) use ($provider, $providerUserId) {
93			$builder->where('provider', $provider)->where('provider_uid', $providerUserId);
94			})->first();
95			}
96
97			/**
98			* Create local user for the given provider.
99			*
100			* @param string $provider
101			* @param array $attributes
102			*
103			* @return \Illuminate\Database\Eloquent\Model\|null
104			*/
105			protected function createLocalUser(string $provider, array $attributes)
106			{
107			$localUser = app('cortex.auth.admin');
108
109			$attributes['password'] = str_random();
			0 ignored issues – show Deprecated Code introduced 2019-08-02 21:42 UTC by Report Bug Copy Issue Report The function `str_random()` has been deprecated with message: Str::random() should be used directly instead. Will be removed in Laravel 6.0. This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
110			$attributes['email_verified_at'] = now();
111			$attributes['is_active'] = ! config('cortex.auth.registration.moderated');
112
113			$localUser->fill($attributes)->save();
114
115			// Fire the register success event
116			event(new Registered($localUser));
117
118			$localUser->socialites()->create([
119			'provider' => $provider,
120			'provider_uid' => $attributes['id'],
121			]);
122
123			return $localUser;
124			}
125			}
126

rinvex / cortex-auth

handleProviderCallback() B last analyzed 2019-09-03 21:54 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

handleProviderCallback() B
last analyzed 2019-09-03 21:54 UTC