Attribute - Code Metrics - Inspection of "Tweak attribute rendering and add checkbox missing..." - rinvex/cortex-attributes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 4cd93e...f54798 )

by Abdelrahman

created 2018-05-30 12:46 UTC

Attribute A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	15
c	1
b	0
f	0
lcom	1
cbo	6
dl	0
loc	118
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
C	render()	0	67	14
A	getRouteKeyName()	0	4	1

<?php

declare(strict_types=1);

namespace Cortex\Attributes\Models;

use Rinvex\Tenants\Traits\Tenantable;
use Cortex\Foundation\Traits\Auditable;
use Illuminate\Database\Eloquent\Model;
use Rinvex\Support\Traits\HashidsTrait;
use Spatie\Activitylog\Traits\LogsActivity;
use Rinvex\Attributes\Models\Attribute as BaseAttribute;

/**
 * Cortex\Attributes\Models\Attribute.
 *
 * @property int                                                                               $id
 * @property string                                                                            $slug
 * @property string                                                                            $name
 * @property array                                                                             $description
 * @property int                                                                               $sort_order
 * @property string                                                                            $group
 * @property string                                                                            $type
 * @property bool                                                                              $is_required
 * @property bool                                                                              $is_collection
 * @property string                                                                            $default
 * @property \Carbon\Carbon|null                                                               $created_at
 * @property \Carbon\Carbon|null                                                               $updated_at
 * @property-read \Illuminate\Database\Eloquent\Collection|\Cortex\Foundation\Models\Log[]     $activity
 * @property array                                                                             $entities
 * @property-read \Rinvex\Attributes\Support\ValueCollection|\Rinvex\Attributes\Models\Value[] $values
 *
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute ordered($direction = 'asc')
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereCreatedAt($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereDefault($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereDescription($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereGroup($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereId($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereIsCollection($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereIsRequired($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereSlug($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereSortOrder($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereName($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereType($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereUpdatedAt($value)
 * @mixin \Eloquent
 */
class Attribute extends BaseAttribute
{
    use Auditable;
    use Tenantable;
    use HashidsTrait;
    use LogsActivity;

    /**
     * Indicates whether to log only dirty attributes or all.
     *
     * @var bool
     */
    protected static $logOnlyDirty = true;

    /**
     * The attributes that are logged on change.
     *
     * @var array
     */
    protected static $logFillable = true;

    /**
     * The attributes that are ignored on change.
     *
     * @var array
     */
    protected static $ignoreChangedAttributes = [
        'created_at',
        'updated_at',
        'deleted_at',
    ];

    /**
     * Get the route key for the model.
     *
     * @param \Illuminate\Database\Eloquent\Model $entity
     * @param string                              $accessArea
     *
     * @return \Illuminate\View\View

     */
    public function render(Model $entity, string $accessArea): string
    {
        $default = '';
        $selected = '';

        switch ($this->type) {
            case 'select':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                $default = collect(array_map('trans', array_map('trim', explode("\n", $this->default))))->map(function ($item) use (&$selected) {

                    if (mb_strpos($item, '=')) {
                        $key = mb_strstr($item, '=', true);
                        $value = str_replace_first('=', '', mb_strstr($item, '='));

                        // Check for SELECTED itmes (marked by asterisk)
                        ! str_contains($value, '*') || $selected = $key;
                        ! str_contains($value, '*') || $value = str_replace_last('*', '', $value);
                    } else {
                        $key = $value = $item;

                        // Check for SELECTED itmes (marked by asterisk)
                        ! str_contains($value, '*') || $key = $value = $selected = str_replace_last('*', '', $value);
                    }

                    return [$key => $value];
                })->collapse();

                return view("cortex/attributes::$accessArea.types.".$this->type, ['attribute' => $this, 'entity' => $entity, 'default' => $default, 'selected' => $selected])->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            case 'check':
switch ($expr) {
case "A":
    doSomething(); //right
    break;
case "B":

    doSomethingElse(); //wrong
    break;

                $default = collect(array_map('trans', array_map('trim', explode("\n", $this->default))))->map(function ($item) use ($entity) {

                    $details = [
                        'label' => '',
                        'status' => false,
                    ];

                    if (mb_strpos($item, '=')) {
                        $details['label'] = mb_strstr($item, '=', true);
                        $item = str_replace_first('=', '', mb_strstr($item, '='));

                        // Check for SELECTED itmes (marked by asterisk)
                        ! str_contains($item, '*') || $details['status'] = true;
                        ! str_contains($item, '*') || $item = str_replace_last('*', '', $item);

                        ! $entity->exists || $details['status'] = $entity->{$this->slug}->search($item) !== false;
                    } else {
                        $details['label'] = $item;

                        // Check for SELECTED itmes (marked by asterisk)
                        ! str_contains($item, '*') || $details['status'] = true;
                        ! str_contains($item, '*') || $details['label'] = $item = str_replace_last('*', '', $item);

                        ! $entity->exists || $details['status'] = $entity->{$this->slug}->search($item) !== false;
                    }

                    return [$item => $details];
                })->collapse();

                return view("cortex/attributes::$accessArea.types.".$this->type, ['attribute' => $this, 'entity' => $entity, 'default' => $default])->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}

            default:
                return view("cortex/attributes::$accessArea.types.".$this->type, ['attribute' => $this, 'entity' => $entity, 'default' => $default])->render();

                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }
    }

    /**
     * Get the route key for the model.
     *
     * @return string
     */
    public function getRouteKeyName()
    {
        return 'slug';
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Attributes\Models;
6
7			use Rinvex\Tenants\Traits\Tenantable;
8			use Cortex\Foundation\Traits\Auditable;
9			use Illuminate\Database\Eloquent\Model;
10			use Rinvex\Support\Traits\HashidsTrait;
11			use Spatie\Activitylog\Traits\LogsActivity;
12			use Rinvex\Attributes\Models\Attribute as BaseAttribute;
13
14			/**
15			* Cortex\Attributes\Models\Attribute.
16			*
17			* @property int $id
18			* @property string $slug
19			* @property string $name
20			* @property array $description
21			* @property int $sort_order
22			* @property string $group
23			* @property string $type
24			* @property bool $is_required
25			* @property bool $is_collection
26			* @property string $default
27			* @property \Carbon\Carbon\|null $created_at
28			* @property \Carbon\Carbon\|null $updated_at
29			* @property-read \Illuminate\Database\Eloquent\Collection\|\Cortex\Foundation\Models\Log[] $activity
30			* @property array $entities
31			* @property-read \Rinvex\Attributes\Support\ValueCollection\|\Rinvex\Attributes\Models\Value[] $values
32			*
33			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute ordered($direction = 'asc')
34			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereCreatedAt($value)
35			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereDefault($value)
36			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereDescription($value)
37			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereGroup($value)
38			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereId($value)
39			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereIsCollection($value)
40			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereIsRequired($value)
41			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereSlug($value)
42			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereSortOrder($value)
43			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereName($value)
44			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereType($value)
45			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereUpdatedAt($value)
46			* @mixin \Eloquent
47			*/
48			class Attribute extends BaseAttribute
49			{
50			use Auditable;
51			use Tenantable;
52			use HashidsTrait;
53			use LogsActivity;
54
55			/**
56			* Indicates whether to log only dirty attributes or all.
57			*
58			* @var bool
59			*/
60			protected static $logOnlyDirty = true;
61
62			/**
63			* The attributes that are logged on change.
64			*
65			* @var array
66			*/
67			protected static $logFillable = true;
68
69			/**
70			* The attributes that are ignored on change.
71			*
72			* @var array
73			*/
74			protected static $ignoreChangedAttributes = [
75			'created_at',
76			'updated_at',
77			'deleted_at',
78			];
79
80			/**
81			* Get the route key for the model.
82			*
83			* @param \Illuminate\Database\Eloquent\Model $entity
84			* @param string $accessArea
85			*
86			* @return \Illuminate\View\View
			0 ignored issues – show Documentation introduced 2018-01-21 14:35 UTC by Report Bug Copy Issue Report Should the return type not be `string`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
87			*/
88			public function render(Model $entity, string $accessArea): string
89			{
90			$default = '';
91			$selected = '';
92
93			switch ($this->type) {
94			case 'select':
			0 ignored issues – show Coding Style introduced 2018-03-22 20:37 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
95
96			$default = collect(array_map('trans', array_map('trim', explode("\n", $this->default))))->map(function ($item) use (&$selected) {
			0 ignored issues – show Coding Style introduced 2018-03-22 20:37 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 145 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
97			if (mb_strpos($item, '=')) {
98			$key = mb_strstr($item, '=', true);
99			$value = str_replace_first('=', '', mb_strstr($item, '='));
100
101			// Check for SELECTED itmes (marked by asterisk)
102			! str_contains($value, '*') \|\| $selected = $key;
103			! str_contains($value, '') \|\| $value = str_replace_last('', '', $value);
104			} else {
105			$key = $value = $item;
106
107			// Check for SELECTED itmes (marked by asterisk)
108			! str_contains($value, '') \|\| $key = $value = $selected = str_replace_last('', '', $value);
109			}
110
111			return [$key => $value];
112			})->collapse();
113
114			return view("cortex/attributes::$accessArea.types.".$this->type, ['attribute' => $this, 'entity' => $entity, 'default' => $default, 'selected' => $selected])->render();
			0 ignored issues – show Bug introduced 2018-03-22 20:37 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history... Coding Style introduced 2018-03-22 20:37 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 184 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
115			break;
			0 ignored issues – show Unused Code introduced 2018-05-30 12:52 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
116
117			case 'check':
			0 ignored issues – show Coding Style introduced 2018-05-30 12:52 UTC by Report Bug Copy Issue Report The case body in a switch statement must start on the line following the statement. According to the PSR-2, the body of a case statement must start on the line immediately following the case statement. switch ($expr) { case "A": doSomething(); //right break; case "B": doSomethingElse(); //wrong break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
118
119			$default = collect(array_map('trans', array_map('trim', explode("\n", $this->default))))->map(function ($item) use ($entity) {
			0 ignored issues – show Coding Style introduced 2018-05-30 12:52 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 142 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
120			$details = [
121			'label' => '',
122			'status' => false,
123			];
124
125			if (mb_strpos($item, '=')) {
126			$details['label'] = mb_strstr($item, '=', true);
127			$item = str_replace_first('=', '', mb_strstr($item, '='));
128
129			// Check for SELECTED itmes (marked by asterisk)
130			! str_contains($item, '*') \|\| $details['status'] = true;
131			! str_contains($item, '') \|\| $item = str_replace_last('', '', $item);
132
133			! $entity->exists \|\| $details['status'] = $entity->{$this->slug}->search($item) !== false;
134			} else {
135			$details['label'] = $item;
136
137			// Check for SELECTED itmes (marked by asterisk)
138			! str_contains($item, '*') \|\| $details['status'] = true;
139			! str_contains($item, '') \|\| $details['label'] = $item = str_replace_last('', '', $item);
140
141			! $entity->exists \|\| $details['status'] = $entity->{$this->slug}->search($item) !== false;
142			}
143
144			return [$item => $details];
145			})->collapse();
146
147			return view("cortex/attributes::$accessArea.types.".$this->type, ['attribute' => $this, 'entity' => $entity, 'default' => $default])->render();
			0 ignored issues – show Bug introduced 2018-05-30 12:52 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history... Coding Style introduced 2018-05-30 12:52 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 159 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
148			break;
			0 ignored issues – show Unused Code introduced 2018-05-30 12:52 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
149
150			default:
151			return view("cortex/attributes::$accessArea.types.".$this->type, ['attribute' => $this, 'entity' => $entity, 'default' => $default])->render();
			0 ignored issues – show Coding Style introduced 2018-05-30 12:52 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 159 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
152			break;
			0 ignored issues – show Unused Code introduced 2018-05-30 12:52 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
153			}
154			}
155
156			/**
157			* Get the route key for the model.
158			*
159			* @return string
160			*/
161			public function getRouteKeyName()
162			{
163			return 'slug';
164			}
165			}
166

rinvex / cortex-attributes

Push — develop ( 4cd93e...f54798 )

Attribute A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like