Attribute::getRouteKeyName() - Code Metrics - Inspection of "Add tenantable support for attributes" - rinvex/cortex-attributes - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 0bf16e...bc1225 )

by Abdelrahman

created 2017-12-22 19:39 UTC

Attribute::getRouteKeyName() A

↳ Parent: Attribute

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

declare(strict_types=1);

namespace Cortex\Attributes\Models;

use Rinvex\Tenants\Traits\Tenantable;
use Illuminate\Database\Eloquent\Model;
use Spatie\Activitylog\Traits\LogsActivity;
use Rinvex\Attributes\Models\Attribute as BaseAttribute;

/**
 * Cortex\Attributes\Models\Attribute.
 *
 * @property int                                                                               $id
 * @property string                                                                            $slug
 * @property array                                                                             $name
 * @property array                                                                             $description
 * @property int                                                                               $sort_order
 * @property string                                                                            $group
 * @property string                                                                            $type
 * @property bool                                                                              $is_required
 * @property bool                                                                              $is_collection
 * @property string                                                                            $default
 * @property \Carbon\Carbon|null                                                               $created_at
 * @property \Carbon\Carbon|null                                                               $updated_at
 * @property-read \Illuminate\Database\Eloquent\Collection|\Cortex\Foundation\Models\Log[]     $activity
 * @property array                                                                             $entities
 * @property-read \Rinvex\Attributes\Support\ValueCollection|\Rinvex\Attributes\Models\Value[] $values
 *
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute ordered($direction = 'asc')
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereCreatedAt($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereDefault($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereDescription($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereGroup($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereId($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereIsCollection($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereIsRequired($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereName($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereSlug($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereSortOrder($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereType($value)
 * @method static \Illuminate\Database\Eloquent\Builder|\Cortex\Attributes\Models\Attribute whereUpdatedAt($value)
 * @mixin \Eloquent
 */
class Attribute extends BaseAttribute
{
    use Tenantable;
    use LogsActivity;

    /**
     * Indicates whether to log only dirty attributes or all.
     *
     * @var bool
     */
    protected static $logOnlyDirty = true;

    /**
     * The attributes that are logged on change.
     *
     * @var array
     */
    protected static $logAttributes = [
        'name',
        'slug',
        'description',
        'sort_order',
        'group',
        'type',
        'entities',
        'is_required',
        'is_collection',
        'default',
    ];

    /**
     * The attributes that are ignored on change.
     *
     * @var array
     */
    protected static $ignoreChangedAttributes = [

        'created_at',
        'updated_at',
        'deleted_at',
    ];

    /**
     * Get the route key for the model.
     *
     * @return string
     */
    public function getRouteKeyName()
    {
        return 'slug';
    }

    /**
     * Get the route key for the model.
     *
     * @param \Illuminate\Database\Eloquent\Model $entity
     * @param string                              $accessArea
     *
     * @return string
     */
    public function render(Model $entity, string $accessArea)
    {
        return view("cortex/attributes::$accessArea.types.".$this->type, ['attribute' => $this, 'entity' => $entity])->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cortex\Attributes\Models;
6
7			use Rinvex\Tenants\Traits\Tenantable;
8			use Illuminate\Database\Eloquent\Model;
9			use Spatie\Activitylog\Traits\LogsActivity;
10			use Rinvex\Attributes\Models\Attribute as BaseAttribute;
11
12			/**
13			* Cortex\Attributes\Models\Attribute.
14			*
15			* @property int $id
16			* @property string $slug
17			* @property array $name
18			* @property array $description
19			* @property int $sort_order
20			* @property string $group
21			* @property string $type
22			* @property bool $is_required
23			* @property bool $is_collection
24			* @property string $default
25			* @property \Carbon\Carbon\|null $created_at
26			* @property \Carbon\Carbon\|null $updated_at
27			* @property-read \Illuminate\Database\Eloquent\Collection\|\Cortex\Foundation\Models\Log[] $activity
28			* @property array $entities
29			* @property-read \Rinvex\Attributes\Support\ValueCollection\|\Rinvex\Attributes\Models\Value[] $values
30			*
31			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute ordered($direction = 'asc')
32			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereCreatedAt($value)
33			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereDefault($value)
34			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereDescription($value)
35			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereGroup($value)
36			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereId($value)
37			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereIsCollection($value)
38			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereIsRequired($value)
39			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereName($value)
40			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereSlug($value)
41			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereSortOrder($value)
42			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereType($value)
43			* @method static \Illuminate\Database\Eloquent\Builder\|\Cortex\Attributes\Models\Attribute whereUpdatedAt($value)
44			* @mixin \Eloquent
45			*/
46			class Attribute extends BaseAttribute
47			{
48			use Tenantable;
49			use LogsActivity;
50
51			/**
52			* Indicates whether to log only dirty attributes or all.
53			*
54			* @var bool
55			*/
56			protected static $logOnlyDirty = true;
57
58			/**
59			* The attributes that are logged on change.
60			*
61			* @var array
62			*/
63			protected static $logAttributes = [
64			'name',
65			'slug',
66			'description',
67			'sort_order',
68			'group',
69			'type',
70			'entities',
71			'is_required',
72			'is_collection',
73			'default',
74			];
75
76			/**
77			* The attributes that are ignored on change.
78			*
79			* @var array
80			*/
81			protected static $ignoreChangedAttributes = [
			0 ignored issues – show Comprehensibility Naming introduced 2017-09-09 19:21 UTC by Report Bug Copy Issue Report The variable name `$ignoreChangedAttributes` exceeds the maximum configured length of `20`. Very long variable names usually make code harder to read. It is therefore recommended not to make variable names too verbose. Loading history...
82			'created_at',
83			'updated_at',
84			'deleted_at',
85			];
86
87			/**
88			* Get the route key for the model.
89			*
90			* @return string
91			*/
92			public function getRouteKeyName()
93			{
94			return 'slug';
95			}
96
97			/**
98			* Get the route key for the model.
99			*
100			* @param \Illuminate\Database\Eloquent\Model $entity
101			* @param string $accessArea
102			*
103			* @return string
104			*/
105			public function render(Model $entity, string $accessArea)
106			{
107			return view("cortex/attributes::$accessArea.types.".$this->type, ['attribute' => $this, 'entity' => $entity])->render();
			0 ignored issues – show Bug introduced 2017-12-22 19:41 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history... Coding Style introduced 2017-12-22 19:41 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 128 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
108			}
109			}
110

rinvex / cortex-attributes

Push — develop ( 0bf16e...bc1225 )

Attribute::getRouteKeyName() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like