GroupBy::setType() - Code Metrics - Inspection of "Merge pull request #9 from friartuck6000/pr/groupb..." - rikbruil/Doctrine-Specification - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f54b59...2b88e7 )

by Rik

created 2016-09-04 08:22 UTC

GroupBy::setType() A

↳ Parent: GroupBy

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	12
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	12
loc	12
c	1
b	0
f	1
rs	9.4285
cc	2
eloc	7
nc	2
nop	1

<?php

namespace Rb\Specification\Doctrine\Query;

use Doctrine\ORM\QueryBuilder;
use Rb\Specification\Doctrine\AbstractSpecification;
use Rb\Specification\Doctrine\Exception\InvalidArgumentException;


/**
 * @author  Kyle Tucker <[email protected]>
 */
class GroupBy extends AbstractSpecification
{
    const GROUP_BY     = 'groupBy';
    const ADD_GROUP_BY = 'addGroupBy';

    /** @var  string[]  */
    protected static $types = [self::GROUP_BY, self::ADD_GROUP_BY];

    /** @var  string */
    protected $type;

    /**
     * Constructor.
     *
     * @param  string       $field
     * @param  string       $type
     * @param  string|null  $dqlAlias
     */
    public function __construct($field, $type = self::ADD_GROUP_BY, $dqlAlias = null)
    {
        $this->setType($type);
        parent::__construct($field, $dqlAlias);
    }

    /**
     * {@inheritdoc}
     */
    public function modify(QueryBuilder $queryBuilder, $dqlAlias)
    {
        call_user_func_array(
            [$queryBuilder, $this->type],
            [
                $this->createPropertyWithAlias($dqlAlias),
            ]
        );
    }

    /**
     * @param  string  $type
     *
     * @throws  InvalidArgumentException
     */
    public function setType($type)

    {
        if (!in_array($type, self::$types)) {
            throw new InvalidArgumentException(sprintf(
                '"%s" is not a valid type! Valid types: %s',
                $type,
                implode(', ', self::$types)
            ));
        }

        $this->type = $type;
    }
}


1		<?php
2
3		namespace Rb\Specification\Doctrine\Query;
4
5		use Doctrine\ORM\QueryBuilder;
6		use Rb\Specification\Doctrine\AbstractSpecification;
7		use Rb\Specification\Doctrine\Exception\InvalidArgumentException;
8
9
10		/**
11		* @author Kyle Tucker <[email protected]>
12		*/
13		class GroupBy extends AbstractSpecification
14		{
15		const GROUP_BY = 'groupBy';
16		const ADD_GROUP_BY = 'addGroupBy';
17
18		/** @var string[] */
19		protected static $types = [self::GROUP_BY, self::ADD_GROUP_BY];
20
21		/** @var string */
22		protected $type;
23
24		/**
25		* Constructor.
26		*
27		* @param string $field
28		* @param string $type
29		* @param string\|null $dqlAlias
30		*/
31		public function __construct($field, $type = self::ADD_GROUP_BY, $dqlAlias = null)
32		{
33		$this->setType($type);
34		parent::__construct($field, $dqlAlias);
35		}
36
37		/**
38		* {@inheritdoc}
39		*/
40		public function modify(QueryBuilder $queryBuilder, $dqlAlias)
41		{
42		call_user_func_array(
43		[$queryBuilder, $this->type],
44		[
45		$this->createPropertyWithAlias($dqlAlias),
46		]
47		);
48		}
49
50		/**
51		* @param string $type
52		*
53		* @throws InvalidArgumentException
54		*/
55	View Code Duplication	public function setType($type)
		0 ignored issues – show Duplication introduced 2016-06-09 14:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		if (!in_array($type, self::$types)) {
58		throw new InvalidArgumentException(sprintf(
59		'"%s" is not a valid type! Valid types: %s',
60		$type,
61		implode(', ', self::$types)
62		));
63		}
64
65		$this->type = $type;
66		}
67		}
68

rikbruil / Doctrine-Specification

GitHub Access Token became invalid

Push — master ( f54b59...2b88e7 )

GroupBy::setType() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like