Nexmo::send() - Code Metrics - Inspection of "add Exception" - ridvanbaluyos/sms-providers - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (8efd2a)

by Ridvan Lakas ng Bayan

created 2016-12-20 12:11 UTC

Nexmo::send() B

↳ Parent: Nexmo

Complexity

Conditions	3
Paths	16

Size

Total Lines	33
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	33
rs	8.8571
cc	3
eloc	23
nc	16
nop	2

<?php
namespace ridvanbaluyos\sms\providers;

use ridvanbaluyos\sms\SmsProviderServicesInterface as SmsProviderServicesInterface;
use ridvanbaluyos\sms\Sms as Sms;
use Exception as Exception;

/**
 * Class Nexmo
 * @package ridvanbaluyos\sms\providers
 */
class Nexmo extends Sms implements SmsProviderServicesInterface
{
    /**
     * @var string
     */
    protected $className;

    /**
     * Nexmo constructor.
     */
    public function __construct()
    {
        $this->className = substr(get_called_class(), strrpos(get_called_class(), '\\') + 1);
    }

    /**
     * This function sends the SMS.
     *
     * @param $phoneNumber
     * @param $message
     * @return string
     */
    public function send($phoneNumber, $message)
    {
        try {
            $conf = Config::load(__DIR__ . '/../config/providers.json')[$this->className];

            $query = array(
                'api_key' => $conf['api_key'],
                'api_secret' => $conf['api_secret'],
                'from' => $conf['from'],
                'to' => $phoneNumber,
                'text' => $message,
            );

            $query = http_build_query($query);
            $ch = curl_init();
            curl_setopt($ch, CURLOPT_URL, $conf['url'] . '/sms/json');
            curl_setopt($ch, CURLOPT_POST, count($query));
            curl_setopt($ch, CURLOPT_POSTFIELDS, $query);
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
            $result = curl_exec($ch);
            curl_close($ch);

            $result = json_decode($result);

            if (intval($result->messages[0]->status) === 0) {
                return $this->response(200, $result, null, $this->className);
            } else {
                return $this->response(500, $result, null, $this->className);
            }
        } catch (Exception $e) {


        }
    }

    /**
     * This function gets the account balance.
     *
     */
    public function balance()

    {
        try {
            $conf = Config::load(__DIR__ . '/../config/providers.json')[$this->className];

            $query = array(
                'api_key' => $conf['api_key'],
                'api_secret' => $conf['api_secret']
            );

            $query = http_build_query($query);

            $ch = curl_init();
            curl_setopt($ch, CURLOPT_URL, $conf['url'] . '/account/get-balance?' . $query);
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
            $result = curl_exec($ch);
            curl_close($ch);

            $result = json_decode($result);

            if (is_float($result->value) || is_integer($result->value)) {
                return $this->response(200, $result, null, $this->className);
            } else {
                return $this->response(500, $result, null, $this->className);
            }
        } catch (Exception $e) {


        }
    }
}


1		<?php
2		namespace ridvanbaluyos\sms\providers;
3
4		use ridvanbaluyos\sms\SmsProviderServicesInterface as SmsProviderServicesInterface;
5		use ridvanbaluyos\sms\Sms as Sms;
6		use Exception as Exception;
7
8		/**
9		* Class Nexmo
10		* @package ridvanbaluyos\sms\providers
11		*/
12		class Nexmo extends Sms implements SmsProviderServicesInterface
13		{
14		/**
15		* @var string
16		*/
17		protected $className;
18
19		/**
20		* Nexmo constructor.
21		*/
22		public function __construct()
23		{
24		$this->className = substr(get_called_class(), strrpos(get_called_class(), '\\') + 1);
25		}
26
27		/**
28		* This function sends the SMS.
29		*
30		* @param $phoneNumber
31		* @param $message
32		* @return string
33		*/
34		public function send($phoneNumber, $message)
35		{
36		try {
37		$conf = Config::load(__DIR__ . '/../config/providers.json')[$this->className];
38
39		$query = array(
40		'api_key' => $conf['api_key'],
41		'api_secret' => $conf['api_secret'],
42		'from' => $conf['from'],
43		'to' => $phoneNumber,
44		'text' => $message,
45		);
46
47		$query = http_build_query($query);
48		$ch = curl_init();
49		curl_setopt($ch, CURLOPT_URL, $conf['url'] . '/sms/json');
50		curl_setopt($ch, CURLOPT_POST, count($query));
51		curl_setopt($ch, CURLOPT_POSTFIELDS, $query);
52		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
53		$result = curl_exec($ch);
54		curl_close($ch);
55
56		$result = json_decode($result);
57
58		if (intval($result->messages[0]->status) === 0) {
59		return $this->response(200, $result, null, $this->className);
60		} else {
61		return $this->response(500, $result, null, $this->className);
62		}
63		} catch (Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-12 07:37 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
64
65		}
66		}
67
68		/**
69		* This function gets the account balance.
70		*
71		*/
72	View Code Duplication	public function balance()
		0 ignored issues – show Duplication introduced 2016-12-20 12:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		{
74		try {
75		$conf = Config::load(__DIR__ . '/../config/providers.json')[$this->className];
76
77		$query = array(
78		'api_key' => $conf['api_key'],
79		'api_secret' => $conf['api_secret']
80		);
81
82		$query = http_build_query($query);
83
84		$ch = curl_init();
85		curl_setopt($ch, CURLOPT_URL, $conf['url'] . '/account/get-balance?' . $query);
86		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
87		$result = curl_exec($ch);
88		curl_close($ch);
89
90		$result = json_decode($result);
91
92		if (is_float($result->value) \|\| is_integer($result->value)) {
93		return $this->response(200, $result, null, $this->className);
94		} else {
95		return $this->response(500, $result, null, $this->className);
96		}
97		} catch (Exception $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-20 12:18 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
98
99		}
100		}
101		}
102

ridvanbaluyos / sms-providers

Branch — master (8efd2a)

Nexmo::send() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like