SendSmsTest

Complexity

Total Complexity

16

Size/Duplication

Total Lines	154
Duplicated Lines	28.57 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

16 Methods

Rating	Name	Duplication	Size	Complexity
A	_before()	0	3	1
A	_after()	0	3	1
A	sendSuccess()	22	22	1
A	sendFail()	22	22	1
A	testSendViaPromoTexterSuccess()	0	6	1
A	testSendViaPromoTexterFail()	0	6	1
A	testSendViaRisingTideSuccess()	0	5	1
A	testSendViaRisingTideFail()	0	6	1
A	testSendViaSemaphoreSuccess()	0	5	1
A	testSendViaSemaphoreFail()	0	6	1
A	testSendViaChikkaSuccess()	0	5	1
A	testSendViaChikkaFail()	0	6	1
A	testSendViaNexmoSuccess()	0	5	1
A	testSendViaNexmoFail()	0	6	1
A	testSendViaTwilioSuccess()	0	5	1
A	testSendViaTwilioFail()	0	6	1

<?php
use ridvanbaluyos\sms\SmsProviderServicesInterface as SmsProviderServicesInterface;
use ridvanbaluyos\sms\Sms as Sms;
use ridvanbaluyos\sms\providers\PromoTexter as PromoTexter;
use ridvanbaluyos\sms\providers\RisingTide as RisingTide;
use ridvanbaluyos\sms\providers\Semaphore as Semaphore;
use ridvanbaluyos\sms\providers\Chikka as Chikka;
use ridvanbaluyos\sms\providers\Nexmo as Nexmo;
use ridvanbaluyos\sms\providers\Twilio as Twilio;

class SendSmsTest extends \Codeception\Test\Unit

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    /**
     * @var \UnitTester
     */
    protected $tester;
    protected $phoneNumber = '639989764990';
    protected $message = 'Unit Testing for SendSmsTest';

    protected function _before()
    {
    }

    protected function _after()
    {
    }

    protected function sendSuccess(SmsProviderServicesInterface $provider)

This method seems to be duplicated in your project.

    {
        $sms = new Sms($provider);
//        if ($sms->getSmsProviderName() != 'Chikka') return;

62% of this comment could be valid code. Did you maybe forget this after debugging?

        $response = $sms->send($this->phoneNumber, $this->message);

        $this->assertJson($response);
        $response = json_decode($response, true);

        $this->assertArrayHasKey('data', $response);
        $this->assertArrayHasKey('code', $response['data']);
        $this->assertArrayHasKey('message', $response['data']);
        $this->assertArrayHasKey('provider', $response['data']);
        $this->assertArrayHasKey('metadata', $response['data']);

        $this->assertTrue(is_int($response['data']['code']));
        $this->assertEquals($sms->getSmsProviderName(), $response['data']['provider']);
        $this->assertLessThanOrEqual(299, $response['data']['code']);
        $this->assertGreaterThanOrEqual(200, $response['data']['code']);
        $this->assertNotEmpty($response['data']['metadata']);
    }

    protected function sendFail(SmsProviderServicesInterface $provider)

This method seems to be duplicated in your project.

    {
        $sms = new Sms($provider);
//        if ($sms->getSmsProviderName() != 'Chikka') return;

62% of this comment could be valid code. Did you maybe forget this after debugging?

        $response = $sms->send($this->phoneNumber, $this->message);

        $this->assertJson($response);
        $response = json_decode($response, true);

        $this->assertArrayHasKey('error', $response);
        $this->assertArrayHasKey('code', $response['error']);
        $this->assertArrayHasKey('message', $response['error']);
        $this->assertArrayHasKey('provider', $response['error']);
        $this->assertArrayHasKey('metadata', $response['error']);

        $this->assertTrue(is_int($response['error']['code']));
        $this->assertEquals($sms->getSmsProviderName(), $response['error']['provider']);
        $this->assertLessThanOrEqual(599, $response['error']['code']);
        $this->assertGreaterThanOrEqual(400, $response['error']['code']);
        $this->assertNotEmpty($response['error']['metadata']);
    }

    // Send via PromoTexter Success
    public function testSendViaPromoTexterSuccess()
    {
        $provider = new PromoTexter();
        $this->sendSuccess($provider);

    }

    // Send via PromoTexter Fail (Incorrect Phone Number Format)
    public function testSendViaPromoTexterFail()
    {
        $this->phoneNumber = 'AAA';
        $provider = new PromoTexter();
        $this->sendFail($provider);
    }

    // Send via RisingTide Success
    public function testSendViaRisingTideSuccess()
    {
        $provider = new RisingTide();
        $this->sendSuccess($provider);
    }

    // Send via RisingTide Fail
    public function testSendViaRisingTideFail()
    {
        $this->phoneNumber = 'AAA';
        $provider = new RisingTide();
        $this->sendFail($provider);
    }

    // Send via Semaphore Success
    public function testSendViaSemaphoreSuccess()
    {
        $provider = new Semaphore();
        $this->sendSuccess($provider);
    }

    // Send via Semaphore Fail
    public function testSendViaSemaphoreFail()
    {
        $this->phoneNumber = 'AAA';
        $provider = new Semaphore();
        $this->sendFail($provider);
    }

    // Send via Chikka Success
    public function testSendViaChikkaSuccess()
    {
        $provider = new Chikka();
        $this->sendSuccess($provider);
    }

    // Send via Chikka Fail
    public function testSendViaChikkaFail()
    {
        $this->phoneNumber = 'AAA';
        $provider = new Chikka();
        $this->sendFail($provider);
    }

    // Send via Chikka Success
    public function testSendViaNexmoSuccess()
    {
        $provider = new Nexmo();
        $this->sendSuccess($provider);
    }

    // Send via Nexmo Fail
    public function testSendViaNexmoFail()
    {
        $this->phoneNumber = 'AAA';
        $provider = new Nexmo();
        $this->sendFail($provider);
    }

    // Send via Twilio Success
    public function testSendViaTwilioSuccess()
    {
        $provider = new Twilio();
        $this->sendSuccess($provider);
    }

    // Send via Nexmo Fail
    public function testSendViaTwilioFail()
    {
        $this->phoneNumber = 'AAA';
        $provider = new Twilio();
        $this->sendFail($provider);
    }
}