skchem.descriptors.AtomFeatureCalculator.__call__() - Code Metrics - Inspection of "fixed python 27 and 34 compatability issue with at..." - richlewis42/scikit-chem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 34460a...5674aa )

by Rich

created 2016-01-19 23:06 UTC

call() A

↳ Parent: skchem.descriptors.AtomFeatureCalculator

Complexity

Conditions

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Metric	Value
cc	1
dl	0
loc	2
rs	10

#! /usr/bin/env python
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
#
# Copyright (C) 2015 Rich Lewis <[email protected]>
# License: 3-clause BSD

import pandas as pd
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from rdkit import Chem
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from rdkit.Chem import Crippen
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from rdkit.Chem import Lipinski
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from rdkit.Chem import rdMolDescriptors
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
from rdkit.Chem.rdchem import HybridizationType
# .scrutinizer.yml
before_commands:
    - sudo pip install abc # Python2
    - sudo pip3 install abc # Python3
import skchem

import functools
from skchem.data import periodic_table

from .filters import organic

def is_element(a, element=0):


    """ Is the atom of a given element """
    return a.GetSymbol() == element

element_features = {'is_{}'.format(e): functools.partial(is_element, element=e) for e in organic}


def is_h_acceptor(a):


    """ Is an H acceptor? """

    m = a.GetOwningMol()
    idx = a.GetIdx()
    return idx in [i[0] for i in Lipinski._HAcceptors(m)]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

def is_h_donor(a):


    """ Is an H donor? """

    m = a.GetOwningMol()
    idx = a.GetIdx()
    return idx in [i[0] for i in Lipinski._HDonors(m)]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

def is_hetero(a):


    """ Is a heteroatom? """

    m = a.GetOwningMol()
    idx = a.GetIdx()
    return idx in [i[0] for i in Lipinski._Heteroatoms(m)]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

def atomic_number(a):


    """ Atomic number of atom """

    return a.GetAtomicNum()

def atomic_mass(a):


    """ Atomic mass of atom """

    return a.GetMass()

def explicit_valence(a):


    """ Explicit valence of atom """
    return a.GetExplicitValence()

def implicit_valence(a):


    """ Implicit valence of atom """

    return a.GetImplicitValence()

def valence(a):


    """ returns the valence of the atom """

    return explicit_valence(a) + implicit_valence(a)

def formal_charge(a):


    """ Formal charge of atom """

    return a.GetFormalCharge()

def is_aromatic(a):


    """ Boolean if atom is aromatic"""

    return a.GetIsAromatic()

def num_implicit_hydrogens(a):


    """ Number of implicit hydrogens """

    return a.GetNumImplicitHs()

def num_explicit_hydrogens(a):


    """ Number of explicit hydrodgens """

    return a.GetNumExplicitHs()

def num_hydrogens(a):


    """ Number of hydrogens """

    return num_implicit_hydrogens(a) + num_explicit_hydrogens(a)

def is_in_ring(a):


    """ Whether the atom is in a ring """

    return a.IsInRing()

def crippen_log_p_contrib(a):


    """ Hacky way of getting logP contribution. """

    idx = a.GetIdx()
    m = a.GetOwningMol()
    return Crippen._GetAtomContribs(m)[idx][0]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

def crippen_molar_refractivity_contrib(a):


    """ Hacky way of getting molar refractivity contribution. """

    idx = a.GetIdx()
    m = a.GetOwningMol()
    return Crippen._GetAtomContribs(m)[idx][1]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

def tpsa_contrib(a):


    """ Hacky way of getting total polar surface area contribution. """

    idx = a.GetIdx()
    m = a.GetOwningMol()
    return rdMolDescriptors._CalcTPSAContribs(m)[idx]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

def labute_asa_contrib(a):


    """ Hacky way of getting accessible surface area contribution. """

    idx = a.GetIdx()
    m = a.GetOwningMol()
    return rdMolDescriptors._CalcLabuteASAContribs(m)[0][idx]
class MyParent:
    def __init__(self):
        self._x = 1;
        self.y = 2;

class MyChild(MyParent):
    def some_method(self):
        return self._x    # Ok, since accessed from a child class

class AnotherClass:
    def some_method(self, instance_of_my_child):
        return instance_of_my_child._x   # Would be flagged as AnotherClass is not
                                         # a child class of MyParent

def is_hybridized(a, hybrid_type=HybridizationType.SP3):


    """ Hybridized as type hybrid_type, default SP3 """

    return a.GetHybridization() is hybrid_type

pt = periodic_table()


def electronegativity(a):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    return a.GetSymbol()


hybridization_features = {'is_' + n + '_hybridized': functools.partial(is_hybridized, hybrid_type=n) for n in HybridizationType.names}


atom_features = {

    'atomic_number': atomic_number,
    'atomic_mass': atomic_mass,
    'formal_charge': formal_charge,
    'valence': valence,
    'is_aromatic': is_aromatic,
    'num_hydrogens': num_hydrogens,
    'is_in_ring': is_in_ring,
    'log_p_contrib': crippen_log_p_contrib,
    'molar_refractivity_contrib': crippen_molar_refractivity_contrib,
    'is_h_acceptor': is_h_acceptor,
    'is_h_donor': is_h_donor,
    'is_heteroatom': is_hetero,
    'total_polar_surface_area_contrib': tpsa_contrib,
    'total_labute_accessible_surface_area': labute_asa_contrib,
}
atom_features.update(element_features)
atom_features.update(hybridization_features)

class AtomFeatureCalculator(object):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    def __init__(self, features=atom_features):
# Bad:
# If array_param is modified inside the function, the next invocation will
# receive the modified object.
def some_function(array_param=[]):
    # ...

# Better: Create an array on each invocation
def some_function(array_param=None):
    array_param = array_param or []
    # ...
        self.features = pd.Series(features)

    @property
    def feature_names(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return self.features.index

    def calculate(self, obj):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        if isinstance(obj, skchem.core.Atom):
            return self._calculate_atom(obj)
        elif isinstance(obj, skchem.core.Mol):
            return self._calculate_mol(obj)

    def _calculate_atom(self, atom):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return self.features.apply(lambda f: f(atom))

    def _calculate_mol(self, mol):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return pd.DataFrame(self(a) for a in mol.atoms)

    def __call__(self, *args, **kwargs):
        return self.calculate(*args, **kwargs)


Push — master ( 34460a...5674aa )

call() A

Complexity

Size

Duplication

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1. Missing Dependencies

2. Missing init.py files

1			#! /usr/bin/env python
			0 ignored issues – show Coding Style introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			#
3			# Copyright (C) 2015 Rich Lewis <[email protected]>
4			# License: 3-clause BSD
5
6			import pandas as pd
			0 ignored issues – show Configuration introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The import `pandas` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
7			from rdkit import Chem
			0 ignored issues – show Configuration introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The import `rdkit` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history... Unused Code introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report Unused Chem imported from rdkit Loading history...
8			from rdkit.Chem import Crippen
			0 ignored issues – show Configuration introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The import `rdkit.Chem` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
9			from rdkit.Chem import Lipinski
			0 ignored issues – show Configuration introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The import `rdkit.Chem` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
10			from rdkit.Chem import rdMolDescriptors
			0 ignored issues – show Configuration introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The import `rdkit.Chem` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
11			from rdkit.Chem.rdchem import HybridizationType
			0 ignored issues – show Configuration introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The import `rdkit.Chem.rdchem` could not be resolved. This can be caused by one of the following: 1. Missing Dependencies This error could indicate a configuration issue of Pylint. Make sure that your libraries are available by adding the necessary commands. # .scrutinizer.yml before_commands: - sudo pip install abc # Python2 - sudo pip3 install abc # Python3 Tip: We are currently not using virtualenv to run pylint, when installing your modules make sure to use the command for the correct version. 2. Missing __init__.py files This error could also result from missing `__init__.py` files in your module folders. Make sure that you place one file in each sub-folder. Loading history...
12			import skchem
13
14			import functools
15			from skchem.data import periodic_table
16
17			from .filters import organic
18
19			def is_element(a, element=0):
			0 ignored issues – show Coding Style Naming introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The name `a` does not conform to the argument naming conventions (`[a-z_][a-z0-9_]{2,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
20
21			""" Is the atom of a given element """
22			return a.GetSymbol() == element
23
24			element_features = {'is_{}'.format(e): functools.partial(is_element, element=e) for e in organic}
			0 ignored issues – show Coding Style Naming introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The name `element_features` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
25
26			def is_h_acceptor(a):
			0 ignored issues – show Coding Style Naming introduced 2016-01-19 23:07 UTC by Report Bug Copy Issue Report The name `a` does not conform to the argument naming conventions (`[a-z_][a-z0-9_]{2,30}$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
27
28			""" Is an H acceptor? """
29
30			m = a.GetOwningMol()

richlewis42 / scikit-chem

Push — master ( 34460a...5674aa )

__call__() A

Complexity

Size

Duplication

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

1. Missing Dependencies

2. Missing __init__.py files

Duplication Side-by-Side

Filter issues like

call() A

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files

2. Missing init.py files