ChEMBLConverter

Complexity

Total Complexity

2

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

17.65%

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__init__()	0	33	1
A	parse_infile()	0	5	1

#! /usr/bin/env python
#
# Copyright (C) 2016 Rich Lewis <rl403@cam.ac.uk>
# License: 3-clause BSD

"""
# skchem.data.converters.chembl

Dataset constructor for ChEMBL
"""
import logging
import pandas as pd

The import pandas could not be resolved.

import os

from .base import Converter, default_pipeline, contiguous_order, Feature
from ...cross_validation import SimThresholdSplit
from ... import features

LOGGER = logging.getLogger(__name__)


class ChEMBLConverter(Converter):

    """ Converter for the ChEMBL dataset. """

    def __init__(self, directory, output_directory, output_filename='chembl.h5'):

The __init__ method of the super-class Converter is not called.

        output_path = os.path.join(output_directory, output_filename)

        infile = os.path.join(directory, 'chembl_raw.h5')
        ms, y = self.parse_infile(infile)

The name ms does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

The name y does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        pipeline = default_pipeline()

        ms, y = pipeline.transform_filter(ms, y)

The name ms does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

The name y does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        cv = SimThresholdSplit(min_threshold=0.6, n_jobs=-1).fit(ms)

The name cv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        train, valid, test = cv.split((70, 15, 15))
        (ms, y, train, valid, test) = contiguous_order((ms, y, train, valid, test), (train, valid, test))

This line is too long as per the coding-style (105/100).

The name ms does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

The name y does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        splits = (('train', train), ('valid', valid), ('test', test))

        feats = (
        Feature(fper=features.MorganFeaturizer(),

Wrong hanging indentation.
Feature(fper=features.MorganFeaturizer(),
^ |

                key='X_morg',
                axis_names=['batch', 'features']),
        Feature(fper=features.PhysicochemicalFeaturizer(),

Wrong hanging indentation.
Feature(fper=features.PhysicochemicalFeaturizer(),
^ |

                key='X_pc',
                axis_names=['batch', 'features']),
        Feature(fper=features.AtomFeaturizer(max_atoms=100),

Wrong hanging indentation.
Feature(fper=features.AtomFeaturizer(max_atoms=100),
^ |

The keyword max_atoms does not seem to exist for the constructor call.

                key='A',
                axis_names=['batch', 'atom_idx', 'features']),
        Feature(fper=features.GraphDistanceTransformer(max_atoms=100),

Wrong hanging indentation.
Feature(fper=features.GraphDistanceTransformer(max_atoms=100),
^ |

The keyword max_atoms does not seem to exist for the constructor call.

                key='G',
                axis_names=['batch', 'atom_idx', 'atom_idx']),
        Feature(fper=features.SpacialDistanceTransformer(max_atoms=100),

Wrong hanging indentation.
Feature(fper=features.SpacialDistanceTransformer(max_atoms=100),
^ |

The keyword max_atoms does not seem to exist for the constructor call.

                key='G_d'))

        self.run(ms, y, output_path, features=feats, splits=splits)


    def parse_infile(self, filename):

This method should have a docstring.

This method could be written as a function/class method.

        ms = pd.read_hdf(filename, 'structure')

The name ms does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        y = pd.read_hdf(filename, 'targets/Y')

The name y does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        return ms, y

if __name__ == '__main__':
    logging.basicConfig(level=logging.DEBUG)
    LOGGER.info('Converting ChEMBL...')
    ChEMBLConverter.convert()