BradleyOpenMPConverter

Complexity

Total Complexity

6

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Test Coverage

Coverage

16.13%

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
B	__init__()	0	25	3
A	filter_bad()	0	6	1
A	parse_smiles()	0	5	2
A	parse_data()	0	4	1
A	fix_mp()	0	4	1

#! /usr/bin/env python

This module should have a docstring.

#
# Copyright (C) 2016 Rich Lewis <rl403@cam.ac.uk>
# License: 3-clause BSD

import os
import logging
logger = logging.getLogger(__name__)

The name logger does not conform to the constant naming conventions ((([A-Z_][A-Z0-9_]*)|(__.*__))$).

import pandas as pd

The import pandas could not be resolved.

from .base import Converter, default_pipeline, contiguous_order
from ...core import Mol
from ...cross_validation import SimThresholdSplit

class BradleyOpenMPConverter(Converter):

This class should have a docstring.

    def __init__(self, directory, output_directory, output_filename='bradley_open_mp.h5'):

The __init__ method of the super-class Converter is not called.

        output_path = os.path.join(output_directory, output_filename)
        data = self.parse_data(os.path.join(directory, 'bradley_melting_point_dataset.xlsx'))
        data = self.filter_bad(data)

        def parse_smiles(smi):

This function should have a docstring.

            try:
                return Mol.from_smiles(smi)

The Class Mol does not seem to have a member named from_smiles.

            except ValueError:
                return None

        data['structure'] = data.smiles.apply(parse_smiles)
        data = data[data.structure.notnull()]
        ms, y = data.structure, self.fix_mp(data)

The name ms does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

The name y does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        pipeline = default_pipeline()
        ms, y = pipeline.transform_filter(ms, y)

The name ms does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

The name y does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        cv = SimThresholdSplit(min_threshold=0.6, n_jobs=-1).fit(ms)

The name cv does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        train, valid, test = cv.split((70, 15, 15))
        (ms, y, train, valid, test) = contiguous_order((ms, y, train, valid, test), (train, valid, test))

This line is too long as per the coding-style (105/100).

The name ms does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

The name y does not conform to the variable naming conventions ([a-z_][a-z0-9_]{2,30}$).

        splits = (('train', train), ('valid', valid), ('test', test))

        self.run(ms, y, output_path=output_path, splits=splits)

    @staticmethod
    def parse_data(path):

This method should have a docstring.

        logger.info('Parsing data at %s...', path)
        return pd.read_excel(path, index_col=0)

    @staticmethod
    def filter_bad(data):

This method should have a docstring.

        logger.info('Removing manually annotated errors...')
        bad_data = data.donotuse.notnull()
        logger.debug('Removed %s', bad_data.sum())
        return data[~bad_data]

    @staticmethod
    def fix_mp(data):

This method should have a docstring.

        logger.info('Converting temperature to Kelvin...')
        return data.mpC + 278.15

if __name__ == '__main__':
    logging.basicConfig(level=logging.DEBUG)
    LOGGER.info('Converting Bradley Open Melting Point Dataset...')

Undefined variable 'LOGGER'

    BradleyOpenMPConverter.convert()