Richdynamix\PersonalisedProducts\Controller\Products\ProductView

Complexity

Total Complexity

4

Size/Duplication

Total Lines	60
Duplicated Lines	25 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	3
Bugs	1	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	15	15	1
A	execute()	0	19	3

<?php

namespace Richdynamix\PersonalisedProducts\Controller\Products;

use \Magento\Framework\App\Action\Action;
use \Magento\Framework\Session\SessionManager;
use \Magento\Customer\Model\Session as CustomerSession;
use \Magento\Framework\Controller\Result\JsonFactory;
use \Magento\Framework\App\Action\Context;
use \Richdynamix\PersonalisedProducts\Model\PredictionIO\EventClient\Client;
use \Richdynamix\PersonalisedProducts\Model\ProductView as ProductViewModel;

/**
 * Class ProductView
 *
 * @category  Richdynamix
 * @package   PersonalisedProducts
 * @author    Steven Richardson (steven@richdynamix.com) @mage_gizmo
 */
class ProductView extends Action {

    /**
     * @var SessionManager
     */
    protected $_sessionManager;

    /**
     * @var JsonFactory
     */
    protected $_resultJsonFactory;

    /**
     * ProductView constructor.
     * @param Context $context
     * @param JsonFactory $resultJsonFactory
     * @param SessionManager $sessionManager
     * @param CustomerSession $customerSession
     * @param Client $eventClient
     * @param ProductViewModel $productView
     */
    public function __construct(

This method seems to be duplicated in your project.

        Context $context,
        JsonFactory $resultJsonFactory,
        SessionManager $sessionManager,
        CustomerSession $customerSession,
        Client $eventClient,
        ProductViewModel $productView
    ) {
        $this->_resultJsonFactory = $resultJsonFactory;
        $this->_sessionManager = $sessionManager;
        $this->_customerSession = $customerSession;
        $this->_eventClient = $eventClient;
        $this->_productView = $productView;
        parent::__construct($context);
    }

    /**
     * @return $this
     */
    public function execute()
    {
        $this->_sessionManager->start();

        $result = $this->_resultJsonFactory->create();

        $productId = $this->getRequest()->getParam('id');
        if (empty($productId)) {
            return $result->setData(['error' => true, 'message' => 'Product ID has not been supplied']);
        }

        $pageViewResult = $this->_productView->processViews($productId);

        if (!$pageViewResult) {
            return $result->setData(['error' => true, 'message' => 'There was an error processing the product view.']);
        }

        return $result->setData(['success' => true, 'message' => 'Product view logged in PredictionIO']);
    }
}