Options - Code Metrics - Inspection of "feature/folder-permissions" - richdynamix/magestead - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — epic/2.0.0 (#37)

by Steven

created 2016-05-08 19:08 UTC

Options A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	247
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	8
Bugs	2	Features	7

Metric	Value
wmc	19
c	8
b	2
f	7
lcom	1
cbo	4
dl	0
loc	247
rs	10

13 Methods

Rating	Name	Size	Complexity
A	__construct()	13	1
A	getAllOptions()	19	1
A	setVagrantSettings()	13	1
A	setApplicationSettings()	21	2
A	setMagento2Settings()	8	2
A	setVersionControlSettings()	9	2
A	askForAuth()	8	1
B	verifyAuth()	22	4
A	setPhp()	11	1
A	setVagrantBox()	4	1
A	setServerConfig()	7	1
A	setWebServer()	9	1
A	setOperatingSystem()	9	1

<?php namespace Magestead\Helper;

use Symfony\Component\Console\Question\Question;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;
use Symfony\Component\Console\Question\ConfirmationQuestion;

/**
 * Class Options
 * @package Magestead\Helper
 */
class Options
{
    const BOX_PREFIX = 'richdynamix/magestead-';
    protected $_app = 'magento2';
$a = "a";
$ab = "ab";
$abc = "abc";
    protected $_server;

    protected $_phpVer = '56';

    protected $_os = 'centos65';
$a = "a";
$ab = "ab";
$abc = "abc";
    protected $_box;

    protected $_m2Username;

    protected $_m2Password;

    protected $_ipAddress;

    protected $_memorylimit;

    protected $_cpus;

    protected $_locale;

    protected $_currency;

    protected $_baseUrl;

    protected $_repoUrl = '';


    /**
     * Options constructor.
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    public function __construct($helper, InputInterface $input, OutputInterface $output)
    {
        $this->setVagrantSettings($helper, $input, $output);

        $this->setServerConfig($helper, $input, $output);

        $this->setApplicationSettings($helper, $input, $output);
        $this->setMagento2Settings($helper, $input, $output);
        $this->setVersionControlSettings($helper, $input, $output);

        $this->setVagrantBox();

    }
    /**
     * @return array
     */
    public function getAllOptions()
    {
        return [
          'app' => $this->_app,
          'server' => $this->_server,
          'phpver' => $this->_phpVer,
          'os' => $this->_os,
          'box' => $this->_box,
          'm2user' => $this->_m2Username,
          'm2pass' => $this->_m2Password,
          'repo_url' => $this->_repoUrl,
          'ip_address' => $this->_ipAddress,
          'cpus' => $this->_cpus,
          'memory_limit' => $this->_memorylimit,
          'locale' => $this->_locale,
          'default_currency' => $this->_currency,
          'base_url' => $this->_baseUrl,
        ];
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function setVagrantSettings($helper, InputInterface $input, OutputInterface $output)
    {
        $output->writeln('<comment>Lets configure your project\'s VM</comment>');

        $ipQuestion = new Question("Configure the IP for your VM (192.168.47.47): ", '192.168.47.47');
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->_ipAddress = strtolower($helper->ask($input, $output, $ipQuestion));

        $cpuQuestion = new Question("How many CPU's would you like to use? (1): ", '1');
        $this->_cpus = strtolower($helper->ask($input, $output, $cpuQuestion));

        $memoryQuestion = new Question("Define the VM memory limit (2048): ", '2048');
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->_memorylimit = strtolower($helper->ask($input, $output, $memoryQuestion));
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function setApplicationSettings($helper, InputInterface $input, OutputInterface $output)
    {
        $output->writeln('<comment>Lets configure your project\'s application</comment>');
        if ($this->_phpVer !== '70') {
            $appQuestion = new ChoiceQuestion(
                "Which application do you want to install?",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                ['Magento', 'Magento 2'],
                0
            );

            $this->_app = strtolower($helper->ask($input, $output, $appQuestion));
        }
        $baseUrlQuestion = new Question("Enter your application's base_url (magestead.dev): ", 'magestead.dev');
        $this->_baseUrl = strtolower($helper->ask($input, $output, $baseUrlQuestion));
$a = "a";
$ab = "ab";
$abc = "abc";

        $currenyQuestion = new Question("Enter your application's default currency (GBP): ", 'GBP');
        $this->_currency = $helper->ask($input, $output, $currenyQuestion);

        $localeQuestion = new Question("Enter your application's default locale (en_GB): ", 'en_GB');
        $this->_locale = $helper->ask($input, $output, $localeQuestion);
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return bool

     */
    protected function setMagento2Settings($helper, InputInterface $input, OutputInterface $output)
    {
        if ($this->_app === 'magento2') {
            return $this->verifyAuth($helper, $input, $output);
        }

        return true;
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function setVersionControlSettings($helper, InputInterface $input, OutputInterface $output)
    {
        $versionControl = new ConfirmationQuestion("Would you like to add your project to GIT? (no/yes) ", false);
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
        $versioning = $helper->ask($input, $output, $versionControl);
$a = "a";
$ab = "ab";
$abc = "abc";
        if ($versioning) {
            $repoQuestion = new Question("Enter your full GitHub/BitBucket repo URL: ", '');
$a = "a";
$ab = "ab";
$abc = "abc";
            $this->_repoUrl = strtolower($helper->ask($input, $output, $repoQuestion));
        }
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function askForAuth($helper, InputInterface $input, OutputInterface $output)
    {
        $username = new Question("Please enter your Magento username (public key): ", '');
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->_m2Username = $helper->ask($input, $output, $username);

        $password = new Question("Please enter your Magento password (private key): ", '');
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->_m2Password = $helper->ask($input, $output, $password);
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return bool

     */
    protected function verifyAuth($helper, InputInterface $input, OutputInterface $output)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $authFile = $_SERVER['HOME'] . "/.composer/auth.json";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

        $authObj = [];
        if (file_exists($authFile)) {
            $authJson = file_get_contents($authFile);
            $authObj = (array)json_decode($authJson);
$a = "a";
$ab = "ab";
$abc = "abc";

            if (isset($authObj['http-basic']) && isset($authObj['http-basic']->{'repo.magento.com'})) {
                return true;
            }
        }

        $this->askForAuth($helper, $input, $output);

        $authObj['http-basic']['repo.magento.com']['username'] = $this->_m2Username;
        $authObj['http-basic']['repo.magento.com']['password'] = $this->_m2Password;

        $authJson = json_encode($authObj);
        return file_put_contents($authFile, $authJson);
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function setPhp($helper, InputInterface $input, OutputInterface $output)
    {
        $output->writeln('<info>Keep in mind PHP7 is only available for Magento 2</info>');
        $phpVerQuestion = new ChoiceQuestion(
            "Which version of PHP should be installed?",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ['56', '70'],
            0
        );

        $this->_phpVer = $helper->ask($input, $output, $phpVerQuestion);
    }

    /**
     * Set box name from concat user options
     */
    protected function setVagrantBox()
    {
        $this->_box = self::BOX_PREFIX . $this->_os . "-$this->_server-php$this->_phpVer";
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function setServerConfig($helper, InputInterface $input, OutputInterface $output)
    {
        $output->writeln('<comment>Lets configure your server</comment>');
        $this->setOperatingSystem($helper, $input, $output);
        $this->setWebServer($helper, $input, $output);
        $this->setPhp($helper, $input, $output);
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function setWebServer($helper, InputInterface $input, OutputInterface $output)
    {
        $serverQuestion = new ChoiceQuestion(
            "Which webserver would you like?",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ['NGINX', 'Apache'],
            0
        );
        $this->_server = strtolower($helper->ask($input, $output, $serverQuestion));
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    /**
     * @param $helper
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    protected function setOperatingSystem($helper, InputInterface $input, OutputInterface $output)
    {
        $osQuestion = new ChoiceQuestion(
            "Which OS would you like to install?",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            ['CentOS 6.5', 'Ubuntu 14'],
            0
        );
        $this->_os = str_replace(' ', '', str_replace('.', '', strtolower($helper->ask($input, $output, $osQuestion))));
$a = "a";
$ab = "ab";
$abc = "abc";
    }
}

1			<?php namespace Magestead\Helper;
2
3			use Symfony\Component\Console\Question\Question;
4			use Symfony\Component\Console\Input\InputInterface;
5			use Symfony\Component\Console\Output\OutputInterface;
6			use Symfony\Component\Console\Question\ChoiceQuestion;
7			use Symfony\Component\Console\Question\ConfirmationQuestion;
8
9			/**
10			* Class Options
11			* @package Magestead\Helper
12			*/
13			class Options
14			{
15			const BOX_PREFIX = 'richdynamix/magestead-';
16			protected $_app = 'magento2';
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_app` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 2 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
17			protected $_server;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_server` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
18			protected $_phpVer = '56';
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_phpVer` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
19			protected $_os = 'centos65';
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_os` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20			protected $_box;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_box` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
21			protected $_m2Username;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_m2Username` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
22			protected $_m2Password;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_m2Password` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
23			protected $_ipAddress;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_ipAddress` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
24			protected $_memorylimit;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_memorylimit` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
25			protected $_cpus;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_cpus` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
26			protected $_locale;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_locale` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
27			protected $_currency;
			0 ignored issues – show Coding Style introduced 2016-05-08 19:11 UTC by Report Bug Copy Issue Report `$_currency` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
28			protected $_baseUrl;

richdynamix / magestead

Pull Request — epic/2.0.0 (#37)

Options A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

Duplication Side-by-Side

Filter issues like