Inspection of "Add options to use Ubuntu OS. Configure difference..." - richdynamix/magestead - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — feature/folder-permissions (74f61c)

by Steven

created 2016-05-08 20:32 UTC

Status

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:status");
         $this->setDescription("Checks cache status");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Checking cache status</info>');
 
-        $command = $this->getCommand(new Config($output));
-        $passedCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $passedCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($passedCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

Please login to merge, or discard this patch.

src/Magestead/Command/Cache/CleanCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:clean");
         $this->setDescription("Cleans cache types");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Cleaning all cache types</info>');
 
-        $command = $this->getCommand(new Config($output));
-        $passedCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $passedCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($passedCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:clean";

Please login to merge, or discard this patch.

src/Magestead/Command/Cache/DisableCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:disable");
         $this->setDescription("Disable cache types");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Disabling all cache types</info>');
 
-        $command = $this->getCommand(new Config($output));
-        $passedCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $passedCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($passedCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:disable";

Please login to merge, or discard this patch.

src/Magestead/Command/Cache/EnableCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:enable");
         $this->setDescription("Enable cache types");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Enabling all cache types</info>');
 
-        $command = $this->getCommand(new Config($output));
-        $passedCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $passedCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($passedCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:enable";

Please login to merge, or discard this patch.

src/Magestead/Command/Cache/FlushCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:flush");
         $this->setDescription("Flushes cache storage used by cache types");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Flushing cache storage</info>');
 
-        $command = $this->getCommand(new Config($output));
-        $passedCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $passedCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($passedCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:flush";

Please login to merge, or discard this patch.

src/Magestead/Command/Index/InfoCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("index:info");
         $this->setDescription("Show available indexes");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Getting index information</info>');
 
-        $command = $this->getCommand(new Config($output));
-        $passedCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $passedCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($passedCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar index:list";

Please login to merge, or discard this patch.

src/Magestead/Command/Index/StatusCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("index:status");
         $this->setDescription("Show status of index");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Getting index status</info>');
 
-        $command = $this->getCommand(new Config($output));
-        $passedCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $passedCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($passedCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 // todo add magerun commands

Please login to merge, or discard this patch.

src/Magestead/Installers/Project.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -9,8 +9,8 @@
 block discarded – undo
     /**
      * @param array $options
      * @param array $config
-     * @param $projectPath
-     * @param $output
+     * @param string $projectPath
+     * @param \Symfony\Component\Console\Output\OutputInterface $output
      * @return Magento2Project|MagentoProject
      */
     public static function create(array $options, array $config, $projectPath, $output)

Please login to merge, or discard this patch.

provision/puphpet/magestead/magento2/add_redis_env.php 1 patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,17 +1,17 @@  discard block
 block discarded – undo
 <?php
 
-$file = "$argv[1]/magento2/app/etc/env.php";
-$env = include $file;
+$file="$argv[1]/magento2/app/etc/env.php";
+$env=include $file;
 
-$env['cache'] =  
-	array (
+$env['cache']=  
+	array(
 		'frontend' => 
-		array (
+		array(
 			'default' => 
-			array (
+			array(
 				'backend' => 'Cm_Cache_Backend_Redis',
     		'backend_options' => 
-    		array (
+    		array(
 					'server' => '127.0.0.1',
 					'port' => '6379',
 					'persistent' => '',
@@ -27,10 +27,10 @@  discard block
 block discarded – undo
         )
 			),
 			'page_cache' => 
-			array (
+			array(
 	      'backend' => 'Cm_Cache_Backend_Redis',
 	      'backend_options' => 
-		    array (
+		    array(
 					'server' => '127.0.0.1',
 					'port' => '6379',
 					'persistent' => '',
@@ -48,4 +48,4 @@  discard block
 block discarded – undo
 		)
 	);
 
-file_put_contents($file, "<?php \n \n return ".var_export($env,true).";");
+file_put_contents($file, "<?php \n \n return ".var_export($env, true).";");

Please login to merge, or discard this patch.

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34
35	35	/**
36	36	* @param Config $config
37		- * @return bool\|string
	37	+ * @return string\|false
38	38	*/
39	39	protected function getCommand(Config $config)
40	40	{

		@@ -17,7 +17,7 @@ discard block
		block discarded – undo
17	17
18	18	protected function configure()
19	19	{
20		- $this->_projectPath = getcwd();
	20	+ $this->_projectPath=getcwd();
21	21	$this->setName("cache:status");
22	22	$this->setDescription("Checks cache status");
23	23	}
		@@ -31,8 +31,8 @@ discard block
		block discarded – undo
31	31	{
32	32	$output->writeln('<info>Checking cache status</info>');
33	33
34		- $command = $this->getCommand(new Config($output));
35		- $passedCommand = "vagrant ssh -c '". $command ."'";
	34	+ $command=$this->getCommand(new Config($output));
	35	+ $passedCommand="vagrant ssh -c '".$command."'";
36	36	return new ProcessCommand($passedCommand, $this->_projectPath, $output);
37	37	}
38	38
		@@ -42,7 +42,7 @@ discard block
		block discarded – undo
42	42	*/
43	43	protected function getCommand(Config $config)
44	44	{
45		- $type = $config->type;
	45	+ $type=$config->type;
46	46	switch ($type) {
47	47	case 'magento':
48	48	return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

		@@ -9,8 +9,8 @@
		block discarded – undo
9	9	/**
10	10	* @param array $options
11	11	* @param array $config
12		- * @param $projectPath
13		- * @param $output
	12	+ * @param string $projectPath
	13	+ * @param \Symfony\Component\Console\Output\OutputInterface $output
14	14	* @return Magento2Project\|MagentoProject
15	15	*/
16	16	public static function create(array $options, array $config, $projectPath, $output)

		@@ -1,17 +1,17 @@ discard block
		block discarded – undo
1	1	<?php
2	2
3		-$file = "$argv[1]/magento2/app/etc/env.php";
4		-$env = include $file;
	3	+$file="$argv[1]/magento2/app/etc/env.php";
	4	+$env=include $file;
5	5
6		-$env['cache'] =
7		- array (
	6	+$env['cache']=
	7	+ array(
8	8	'frontend' =>
9		- array (
	9	+ array(
10	10	'default' =>
11		- array (
	11	+ array(
12	12	'backend' => 'Cm_Cache_Backend_Redis',
13	13	'backend_options' =>
14		- array (
	14	+ array(
15	15	'server' => '127.0.0.1',
16	16	'port' => '6379',
17	17	'persistent' => '',
		@@ -27,10 +27,10 @@ discard block
		block discarded – undo
27	27	)
28	28	),
29	29	'page_cache' =>
30		- array (
	30	+ array(
31	31	'backend' => 'Cm_Cache_Backend_Redis',
32	32	'backend_options' =>
33		- array (
	33	+ array(
34	34	'server' => '127.0.0.1',
35	35	'port' => '6379',
36	36	'persistent' => '',
		@@ -48,4 +48,4 @@ discard block
		block discarded – undo
48	48	)
49	49	);
50	50
51		-file_put_contents($file, "<?php \n \n return ".var_export($env,true).";");
	51	+file_put_contents($file, "<?php \n \n return ".var_export($env, true).";");

richdynamix / magestead

Branch — feature/folder-permissions (74f61c)

Status

Category

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch