Inspection of "Fix missing bin and licence info in composer file" - richdynamix/magestead - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f501c7...46bbe1 )

by Steven

created 2016-05-12 09:10 UTC

Status

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:status");
         $this->setDescription("Checks cache status");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Checking cache status</info>');
 
-        $command  = $this->getCommand(new Config($output));
-        $pCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $pCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($pCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

Please login to merge, or discard this patch.

src/Magestead/Command/Cache/CleanCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:status");
         $this->setDescription("Checks cache status");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Checking cache status</info>');
 
-        $command  = $this->getCommand(new Config($output));
-        $pCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $pCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($pCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

Please login to merge, or discard this patch.

src/Magestead/Command/Cache/DisableCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:status");
         $this->setDescription("Checks cache status");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Checking cache status</info>');
 
-        $command  = $this->getCommand(new Config($output));
-        $pCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $pCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($pCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

Please login to merge, or discard this patch.

src/Magestead/Command/Cache/EnableCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:status");
         $this->setDescription("Checks cache status");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Checking cache status</info>');
 
-        $command  = $this->getCommand(new Config($output));
-        $pCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $pCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($pCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

Please login to merge, or discard this patch.

src/Magestead/Command/Cache/FlushCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:status");
         $this->setDescription("Checks cache status");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Checking cache status</info>');
 
-        $command  = $this->getCommand(new Config($output));
-        $pCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $pCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($pCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

Please login to merge, or discard this patch.

src/Magestead/Command/Index/InfoCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:status");
         $this->setDescription("Checks cache status");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Checking cache status</info>');
 
-        $command  = $this->getCommand(new Config($output));
-        $pCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $pCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($pCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

Please login to merge, or discard this patch.

src/Magestead/Command/Index/StatusCommand.php 2 patches

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@
 block discarded – undo
 
     /**
      * @param Config $config
-     * @return bool|string
+     * @return string|false
      */
     protected function getCommand(Config $config)
     {

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -17,7 +17,7 @@  discard block
 block discarded – undo
 
     protected function configure()
     {
-        $this->_projectPath = getcwd();
+        $this->_projectPath=getcwd();
         $this->setName("cache:status");
         $this->setDescription("Checks cache status");
     }
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
     {
         $output->writeln('<info>Checking cache status</info>');
 
-        $command  = $this->getCommand(new Config($output));
-        $pCommand = "vagrant ssh -c '". $command ."'";
+        $command=$this->getCommand(new Config($output));
+        $pCommand="vagrant ssh -c '".$command."'";
         return new ProcessCommand($pCommand, $this->_projectPath, $output);
     }
 
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
      */
     protected function getCommand(Config $config)
     {
-        $type = $config->type;
+        $type=$config->type;
         switch ($type) {
             case 'magento':
                 return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

Please login to merge, or discard this patch.

src/Magestead/Installers/Project.php 1 patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -9,8 +9,8 @@
 block discarded – undo
     /**
      * @param array $options
      * @param array $config
-     * @param $projectPath
-     * @param $output
+     * @param string $projectPath
+     * @param \Symfony\Component\Console\Output\OutputInterface $output
      * @return Magento2Project|MagentoProject
      */
     public static function create(array $options, array $config, $projectPath, $output)

Please login to merge, or discard this patch.

src/Magestead/Helper/HostsPluginChecker.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@  discard block
 block discarded – undo
      */
     public static function verify(array $options, OutputInterface $output)
     {
-        $hostPlugin = `vagrant plugin list | grep vagrant-hostsupdater`;
+        $hostPlugin=`vagrant plugin list | grep vagrant-hostsupdater`;
         if (is_null($hostPlugin)) {
             self::editHostsInstructions($options, $output);
 
@@ -29,8 +29,8 @@  discard block
 block discarded – undo
     protected static function editHostsInstructions(array $options, OutputInterface $output)
     {
         $output->writeln('<comment>NOTE: You will need to add the following to your hosts file!</comment>');
-        $comment = $options['vagrantfile']['vm']['network']['private_network'] .
-            ' ' . $options['magestead']['apps']['mba_12345']['base_url'];
-        $output->writeln('<info>' . $comment . '</info>');
+        $comment=$options['vagrantfile']['vm']['network']['private_network'].
+            ' '.$options['magestead']['apps']['mba_12345']['base_url'];
+        $output->writeln('<info>'.$comment.'</info>');
     }
 }
\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34
35	35	/**
36	36	* @param Config $config
37		- * @return bool\|string
	37	+ * @return string\|false
38	38	*/
39	39	protected function getCommand(Config $config)
40	40	{

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34
35	35	/**
36	36	* @param Config $config
37		- * @return bool\|string
	37	+ * @return string\|false
38	38	*/
39	39	protected function getCommand(Config $config)
40	40	{

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34
35	35	/**
36	36	* @param Config $config
37		- * @return bool\|string
	37	+ * @return string\|false
38	38	*/
39	39	protected function getCommand(Config $config)
40	40	{

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34
35	35	/**
36	36	* @param Config $config
37		- * @return bool\|string
	37	+ * @return string\|false
38	38	*/
39	39	protected function getCommand(Config $config)
40	40	{

		@@ -34,7 +34,7 @@
		block discarded – undo
34	34
35	35	/**
36	36	* @param Config $config
37		- * @return bool\|string
	37	+ * @return string\|false
38	38	*/
39	39	protected function getCommand(Config $config)
40	40	{

		@@ -17,7 +17,7 @@ discard block
		block discarded – undo
17	17
18	18	protected function configure()
19	19	{
20		- $this->_projectPath = getcwd();
	20	+ $this->_projectPath=getcwd();
21	21	$this->setName("cache:status");
22	22	$this->setDescription("Checks cache status");
23	23	}
		@@ -31,8 +31,8 @@ discard block
		block discarded – undo
31	31	{
32	32	$output->writeln('<info>Checking cache status</info>');
33	33
34		- $command = $this->getCommand(new Config($output));
35		- $pCommand = "vagrant ssh -c '". $command ."'";
	34	+ $command=$this->getCommand(new Config($output));
	35	+ $pCommand="vagrant ssh -c '".$command."'";
36	36	return new ProcessCommand($pCommand, $this->_projectPath, $output);
37	37	}
38	38
		@@ -42,7 +42,7 @@ discard block
		block discarded – undo
42	42	*/
43	43	protected function getCommand(Config $config)
44	44	{
45		- $type = $config->type;
	45	+ $type=$config->type;
46	46	switch ($type) {
47	47	case 'magento':
48	48	return "cd /var/www/public;../bin/n98-magerun.phar cache:list";

		@@ -9,8 +9,8 @@
		block discarded – undo
9	9	/**
10	10	* @param array $options
11	11	* @param array $config
12		- * @param $projectPath
13		- * @param $output
	12	+ * @param string $projectPath
	13	+ * @param \Symfony\Component\Console\Output\OutputInterface $output
14	14	* @return Magento2Project\|MagentoProject
15	15	*/
16	16	public static function create(array $options, array $config, $projectPath, $output)

		@@ -14,7 +14,7 @@ discard block
		block discarded – undo
14	14	*/
15	15	public static function verify(array $options, OutputInterface $output)
16	16	{
17		- $hostPlugin = `vagrant plugin list \| grep vagrant-hostsupdater`;
	17	+ $hostPlugin=`vagrant plugin list \| grep vagrant-hostsupdater`;
18	18	if (is_null($hostPlugin)) {
19	19	self::editHostsInstructions($options, $output);
20	20
		@@ -29,8 +29,8 @@ discard block
		block discarded – undo
29	29	protected static function editHostsInstructions(array $options, OutputInterface $output)
30	30	{
31	31	$output->writeln('<comment>NOTE: You will need to add the following to your hosts file!</comment>');
32		- $comment = $options['vagrantfile']['vm']['network']['private_network'] .
33		- ' ' . $options['magestead']['apps']['mba_12345']['base_url'];
34		- $output->writeln('<info>' . $comment . '</info>');
	32	+ $comment=$options['vagrantfile']['vm']['network']['private_network'].
	33	+ ' '.$options['magestead']['apps']['mba_12345']['base_url'];
	34	+ $output->writeln('<info>'.$comment.'</info>');
35	35	}
36	36	}
37	37	\ No newline at end of file

richdynamix / magestead

Push — master ( f501c7...46bbe1 )

Status

Category

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Doc Comments +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch