Config::readConfigFile() - Code Metrics - Inspection of "Add better exception handling for config file" - richdynamix/magestead - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/add-cli-installers ( 2e79ad...9d1cba )

by Steven

created 2016-04-18 21:17 UTC

Config::readConfigFile() A

↳ Parent: Config

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	8
rs	9.4285
cc	2
eloc	4
nc	2
nop	0

<?php namespace Magestead\Helper;

use Magestead\Exceptions\MissingConfigFileException;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Yaml\Exception\ParseException;
use Symfony\Component\Yaml\Parser;

class Config
{
    protected $_projectPath;

    /**
     * Config constructor.
     * @param OutputInterface $output
     */
    public function __construct(OutputInterface $output)
    {
        $this->_projectPath = getcwd();
        $this->_config = $this->getConfigFile($output);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param $name
     * @return mixed
     */
    function __get($name)

    {
        return $this->_config['magestead']['apps']['mba_12345'][$name];
    }

    /**
     * @param OutputInterface $output
     * @return bool|mixed
     */
    protected function getConfigFile(OutputInterface $output)
    {
        $config = new Parser();
        try {
            return $config->parse($this->readConfigFile());
        } catch (ParseException $e) {
            $output->writeln('<error>Unable to parse the config file</error>');
        }

        return false;
    }

    protected function readConfigFile()
    {
        if (!file_exists($this->_projectPath . '/magestead.yaml')) {
            throw new MissingConfigFileException('No config file was found, are you in the project root?');
        }

        return file_get_contents($this->_projectPath . '/magestead.yaml');
    }
}


1			<?php namespace Magestead\Helper;
2
3			use Magestead\Exceptions\MissingConfigFileException;
4			use Symfony\Component\Console\Output\OutputInterface;
5			use Symfony\Component\Yaml\Exception\ParseException;
6			use Symfony\Component\Yaml\Parser;
7
8			class Config
9			{
10			protected $_projectPath;
11
12			/**
13			* Config constructor.
14			* @param OutputInterface $output
15			*/
16			public function __construct(OutputInterface $output)
17			{
18			$this->_projectPath = getcwd();
19			$this->_config = $this->getConfigFile($output);
			0 ignored issues – show Bug introduced 2016-04-17 16:10 UTC by Report Bug Copy Issue Report The property `_config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20			}
21
22			/**
23			* @param $name
24			* @return mixed
25			*/
26			function __get($name)
			0 ignored issues – show Best Practice introduced 2016-04-17 16:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
27			{
28			return $this->_config['magestead']['apps']['mba_12345'][$name];
29			}
30
31			/**
32			* @param OutputInterface $output
33			* @return bool\|mixed
34			*/
35			protected function getConfigFile(OutputInterface $output)
36			{
37			$config = new Parser();
38			try {
39			return $config->parse($this->readConfigFile());
40			} catch (ParseException $e) {
41			$output->writeln('<error>Unable to parse the config file</error>');
42			}
43
44			return false;
45			}
46
47			protected function readConfigFile()
48			{
49			if (!file_exists($this->_projectPath . '/magestead.yaml')) {
50			throw new MissingConfigFileException('No config file was found, are you in the project root?');
51			}
52
53			return file_get_contents($this->_projectPath . '/magestead.yaml');
54			}
55			}
56

richdynamix / magestead

Push — feature/add-cli-installers ( 2e79ad...9d1cba )

Config::readConfigFile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like