Config::getConfigFile() - Code Metrics - Inspection of "Add commands for VM management, cache management" - richdynamix/magestead - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/add-cli-installers ( 115549...a5e20d )

by Steven

created 2016-04-17 15:56 UTC

Config::getConfigFile() A

↳ Parent: Config

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	11
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	11
loc	11
rs	9.4285
cc	2
eloc	7
nc	2
nop	1

<?php namespace Magestead\Helper;

use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Yaml\Exception\ParseException;
use Symfony\Component\Yaml\Parser;

class Config
{
    protected $_projectPath;

    /**
     * Config constructor.
     * @param OutputInterface $output
     */
    public function __construct(OutputInterface $output)
    {
        $this->_projectPath = getcwd();
        $this->_config = $this->getConfigFile($output);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * @param $name
     * @return mixed
     */
    function __get($name)

    {
        return $this->_config['magestead']['apps']['mba_12345'][$name];
    }

    /**
     * @param OutputInterface $output
     * @return bool|mixed
     */
    protected function getConfigFile(OutputInterface $output)

    {
        $config = new Parser();
        try {
            return $config->parse(file_get_contents($this->_projectPath . '/magestead.yaml'));
        } catch (ParseException $e) {
            $output->writeln('<error>Unable to parse the config file</error>');
        }

        return false;
    }
}


1		<?php namespace Magestead\Helper;
2
3		use Symfony\Component\Console\Output\OutputInterface;
4		use Symfony\Component\Yaml\Exception\ParseException;
5		use Symfony\Component\Yaml\Parser;
6
7		class Config
8		{
9		protected $_projectPath;
10
11		/**
12		* Config constructor.
13		* @param OutputInterface $output
14		*/
15		public function __construct(OutputInterface $output)
16		{
17		$this->_projectPath = getcwd();
18		$this->_config = $this->getConfigFile($output);
		0 ignored issues – show Bug introduced 2016-04-17 16:10 UTC by Report Bug Copy Issue Report The property `_config` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19		}
20
21		/**
22		* @param $name
23		* @return mixed
24		*/
25		function __get($name)
		0 ignored issues – show Best Practice introduced 2016-04-17 16:10 UTC by Report Bug Copy Issue Report It is generally recommended to explicitly declare the visibility for methods. Adding explicit visibility (`private`, `protected`, or `public`) is generally recommend to communicate to other developers how, and from where this method is intended to be used. Loading history...
26		{
27		return $this->_config['magestead']['apps']['mba_12345'][$name];
28		}
29
30		/**
31		* @param OutputInterface $output
32		* @return bool\|mixed
33		*/
34	View Code Duplication	protected function getConfigFile(OutputInterface $output)
		0 ignored issues – show Duplication introduced 2016-04-17 16:10 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		$config = new Parser();
37		try {
38		return $config->parse(file_get_contents($this->_projectPath . '/magestead.yaml'));
39		} catch (ParseException $e) {
40		$output->writeln('<error>Unable to parse the config file</error>');
41		}
42
43		return false;
44		}
45		}
46

richdynamix / magestead

Push — feature/add-cli-installers ( 115549...a5e20d )

Config::getConfigFile() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like