RMiller\BehatSpec\Extension\PhpSpecExtension\Process\CommandRunner\CliFunctionChecker

Complexity

Total Complexity

4

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	functionCanBeUsed()	0	6	3

<?php

namespace RMiller\BehatSpec\Extension\PhpSpecExtension\Process\CommandRunner;

use RMiller\BehatSpec\Extension\PhpSpecExtension\Process\CachingExecutableFinder;

class CliFunctionChecker
{
    /**
     * @var \RMiller\BehatSpec\Extension\PhpSpecExtension\Process\CachingExecutableFinder
     */
    private $executableFinder;

    /**
     * @param \RMiller\BehatSpec\Extension\PhpSpecExtension\Process\CachingExecutableFinder $executableFinder
     */
    public function __construct(CachingExecutableFinder $executableFinder)
    {
        $this->executableFinder = $executableFinder;
    }

    /**
     * @param string $function
     *
     * @return bool
     */
    public function functionCanBeUsed($function)
    {
        return (php_sapi_name() == 'cli')
            && $this->executableFinder->getExecutablePath()

The expression $this->executableFinder->getExecutablePath() of type string|false is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== false instead.

            && function_exists($function);
    }
}