TranslatedRouteCommandContext::getLocaleEnvKey() - Code Metrics - Inspection of "refer to issue #15" - richan-fongdasen/laravel-i18n - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

unknown

created 2020-01-16 11:05 UTC

TranslatedRouteCommandContext::getLocaleEnvKey() A

↳ Parent: TranslatedRouteCommandContext

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace RichanFongdasen\I18n\Traits;

use RichanFongdasen\I18n\I18nService;

trait TranslatedRouteCommandContext
{
    /**
     * Returns whether a given locale is supported.
     *
     * @param string $locale
     * 
     * @return bool
     */
    protected function isSupportedLocale($locale)
    {
        return $this->getI18nService()->getLocale($locale) !== null;
    }

    /**
     * @return string[]
     */
    protected function getSupportedLocales()
    {
        return $this->getI18nService()->getLocale()->toArray();
    }

    /**
     * @return \RichanFongdasen\I18n\I18nService
     */
    protected function getI18nService()
    {
        return app(I18nService::class);
    }

    /**
     * @return string
     */
    protected function getBootstrapPath()
    {
        if (method_exists($this->laravel, 'bootstrapPath')) {
            return $this->laravel->bootstrapPath();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }
        return $this->laravel->basePath().DIRECTORY_SEPARATOR.'bootstrap';
    }

    /**
     * @param string $locale

     * 
     * @return string
     */
    protected function makeLocaleRoutesPath($locale = null)

    {
        $path = $this->laravel->getCachedRoutesPath();
        if (!$locale) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $path;
        }
        $path = substr($path, 0, -4).'_'.$locale.'.php';

        return $path;
    }

    protected function getLocaleEnvKey()

    {
        return I18nService::ENV_ROUTE_KEY;
    }
}


1		<?php
2
3		namespace RichanFongdasen\I18n\Traits;
4
5		use RichanFongdasen\I18n\I18nService;
6
7		trait TranslatedRouteCommandContext
8		{
9		/**
10		* Returns whether a given locale is supported.
11		*
12		* @param string $locale
13		*
14		* @return bool
15		*/
16		protected function isSupportedLocale($locale)
17		{
18		return $this->getI18nService()->getLocale($locale) !== null;
19		}
20
21		/**
22		* @return string[]
23		*/
24		protected function getSupportedLocales()
25		{
26		return $this->getI18nService()->getLocale()->toArray();
27		}
28
29		/**
30		* @return \RichanFongdasen\I18n\I18nService
31		*/
32		protected function getI18nService()
33		{
34		return app(I18nService::class);
35		}
36
37		/**
38		* @return string
39		*/
40		protected function getBootstrapPath()
41		{
42		if (method_exists($this->laravel, 'bootstrapPath')) {
43		return $this->laravel->bootstrapPath();
		0 ignored issues – show Bug introduced 2020-01-16 10:23 UTC by Report Bug Copy Issue Report The property `laravel` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44		}
45		return $this->laravel->basePath().DIRECTORY_SEPARATOR.'bootstrap';
46		}
47
48		/**
49		* @param string $locale
		0 ignored issues – show Documentation introduced 2020-01-16 10:23 UTC by Report Bug Copy Issue Report Should the type for parameter `$locale` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
50		*
51		* @return string
52		*/
53	View Code Duplication	protected function makeLocaleRoutesPath($locale = null)
		0 ignored issues – show Duplication introduced 2020-01-16 10:23 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		{
55		$path = $this->laravel->getCachedRoutesPath();
56		if (!$locale) {
		0 ignored issues – show Bug Best Practice introduced 2020-01-16 10:23 UTC by Report Bug Copy Issue Report The expression `$locale` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
57		return $path;
58		}
59		$path = substr($path, 0, -4).'_'.$locale.'.php';
60
61		return $path;
62		}
63
64		protected function getLocaleEnvKey()
		0 ignored issues – show Documentation introduced 2020-01-16 10:23 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
65		{
66		return I18nService::ENV_ROUTE_KEY;
67		}
68		}
69

richan-fongdasen / laravel-i18n

Pull Request — master (#16)

TranslatedRouteCommandContext::getLocaleEnvKey() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like