Validate\Traits\GetDataTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	foundInFile()	0	10	3
A	getFileUrl()	0	4	1
A	getListFromFile()	0	3	1

<?php

namespace Validate\Traits;

/**
 * Undocumented trait
 */
trait GetDataTrait
{

    /**
     * Get full file url
     *
     * @param string $file
     * @return string
     */
    public static function getFileUrl($file)
    {
        $rootDir = DIRECTORY_SEPARATOR."..".DIRECTORY_SEPARATOR."..".DIRECTORY_SEPARATOR."..".DIRECTORY_SEPARATOR."data";
        return dirname(__FILE__).$rootDir.DIRECTORY_SEPARATOR.$file;
    }

    /**
     * Return array from file
     *
     * @param string $file
     * @return array
     */
    public static function getListFromFile($file)
    {
        return file(self::getFileUrl($file));

The expression return file(self::getFileUrl($file)) could also return false which is incompatible with the documented return type array. Did you maybe forget to handle an error condition?

    }

    /**
     * Found string inside file
     *
     * @param string $string
     * @param string $file
     * @return bool
     */
    public static function foundInFile($string, $file)
    {
        $fileHandle = fopen(self::getFileUrl($file), "r");
        while (!feof($fileHandle)) {

It seems like $fileHandle can also be of type false; however, parameter $handle of feof() does only seem to accept resource, maybe add an additional type check?

            if (trim($string) === trim(fgets($fileHandle))){

It seems like $fileHandle can also be of type false; however, parameter $handle of fgets() does only seem to accept resource, maybe add an additional type check?

                return true;
            }
        }
        fclose($fileHandle);

It seems like $fileHandle can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        return false;
    }
}