ricardosierra / translation

src/Http/Middleware/LocaleMiddleware.php

<?php

namespace Translation\Http\Middleware;

use Closure;
use Illuminate\Http\Request;

The type Illuminate\Http\Request was not found. Maybe you did not declare it correctly or list all dependencies?

use Translation\Facades\Translation;
use Illuminate\Contracts\Auth\Guard;
use Illuminate\Contracts\Routing\ResponseFactory;
use Illuminate\Support\Facades\Config;
use Illuminate\Support\Facades\Cookie;

class LocaleMiddleware
{
    /**
     * The Guard implementation.
     *
     * @var Guard
     */
    protected $auth;

    /**
     * The response factory implementation.
     *
     * @var ResponseFactory
     */
    protected $response;

    /**
     * Create a new filter instance.
     *
     * @param  Guard           $auth
     * @param  ResponseFactory $response
     * @return void
     */
    public function __construct(Guard $auth,
        ResponseFactory $response
    ) {
        $this->auth = $auth;
        $this->response = $response;
    }

    /**
     * Sets the locale cookie on every request depending
     * on the locale supplied in the route prefix.
     *
     * @param Request $request
     * @param Closure $next
     *
     * @return mixed
     */
    public function handle(Request $request, Closure $next)
    {
        if ($this->auth->check()) {
            $language = (int) $this->auth->user()->language;

The assignment to $language is dead and can be removed.

Accessing language on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        if (Cookie::has('locale')) {
            Config::set('app.locale', Cookie::get('locale'));
            app()->setLocale(Cookie::get('locale'));

The function app was not found. Maybe you did not declare it correctly or list all dependencies?

        }

        if ($request->session()->has('locale')) {
            Config::set('app.locale', $request->session()->get('locale'));
            app()->setLocale($request->session()->get('locale'));
        }
        $request->cookies->set('locale', Translation::detectLocale($request));

The method detectLocale() does not exist on Translation\Facades\Translation. Since you implemented __callStatic, consider adding a @method annotation.

        return $next($request);
    }
}