phpspider\core\requests::request()

Complexity

Conditions	32
Paths	> 20000

Size

Total Lines	199
Code Lines	91

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public static function request($url, $method = 'GET', $fields = array(), $files = array(), $allow_redirects = true, $cert = NULL)

The parameter $cert is not used and could be removed.

    {
        $method = strtoupper($method);
        if(!self::_is_url($url))
        {
            self::$error = "You have requested URL ({$url}) is not a valid HTTP address";
            return false;

The expression return false returns the type false which is incompatible with the documented return type void.

        }

        // 如果是 get 方式，直接拼凑一个 url 出来
        if ($method == 'GET' && !empty($fields)) 
        {
            $url = $url.(strpos($url, '?') === false ? '?' : '&').http_build_query($fields);
        }

        $parse_url = parse_url($url);
        if (empty($parse_url) || empty($parse_url['host']) || !in_array($parse_url['scheme'], array('http', 'https'))) 
        {
            self::$error = "No connection adapters were found for '{$url}'";
            return false;

The expression return false returns the type false which is incompatible with the documented return type void.

        }
        $scheme = $parse_url['scheme'];
        $domain = $parse_url['host'];

        // 随机绑定 hosts，做负载均衡
        if (self::$hosts) 

The expression self::hosts of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        {
            if (isset(self::$hosts[$domain]))
            {
                $hosts = self::$hosts[$domain];
                $key = rand(0, count($hosts)-1);
                $ip = $hosts[$key];
                $url = str_replace($domain, $ip, $url);
                self::$rawheaders['Host'] = $domain;
            }
        }

        curl_setopt( self::$ch, CURLOPT_URL, $url );

        if ($method != 'GET')
        {
            // 如果是 post 方式
            if ($method == 'POST')
            {
                //curl_setopt( self::$ch, CURLOPT_POST, true );
                $tmpheaders = array_change_key_case(self::$rawheaders, CASE_LOWER);
                // 有些RESTful服务只接受JSON形态的数据
                // CURLOPT_POST会把上傳的文件类型设为 multipart/form-data
                // 把CURLOPT_POSTFIELDS的内容按multipart/form-data 的形式编码
                // CURLOPT_CUSTOMREQUEST可以按指定内容上传
                if ( isset($tmpheaders['content-type']) && $tmpheaders['content-type'] == 'application/json' ) 
                {
                    curl_setopt( self::$ch, CURLOPT_CUSTOMREQUEST, $method ); 
                }
                else 
                {
                    curl_setopt( self::$ch, CURLOPT_POST, true );
                }

                $file_fields = array();
                if (!empty($files)) 
                {
                    foreach ($files as $postname => $file) 
                    {
                        $filepath = realpath($file);
                        // 如果文件不存在
                        if (!file_exists($filepath)) 
                        {
                            continue;
                        }

                        $filename = basename($filepath);
                        $type = self::get_mimetype($filepath);
                        $file_fields[$postname] = curl_file_create($filepath, $type, $filename);
                        // curl -F "name=seatle&file=@/absolute/path/to/image.png" htt://localhost/uploadfile.php
                        //$cfile = '@'.realpath($filename).";type=".$type.";filename=".$filename;
                    }
                }
            }
            else
            {
                self::$rawheaders['X-HTTP-Method-Override'] = $method;
                curl_setopt( self::$ch, CURLOPT_CUSTOMREQUEST, $method ); 
            }

            if ( $method == 'POST' ) 
            {
                // 不是上传文件的，用http_build_query, 能实现更好的兼容性，更小的请求数据包
                if ( empty($file_fields) ) 
                {
                    // post方式
                    if ( is_array($fields) ) 
                    {
                        $fields = http_build_query($fields);
                    }
                }
                else 
                {
                    // 有post数据
                    if ( is_array($fields) && !empty($fields) ) 
                    {
                        // 某些server可能会有问题
                        $fields = array_merge($fields, $file_fields);
                    }
                    else 
                    {
                        $fields = $file_fields;
                    }
                }

                // 不能直接传数组，不知道是什么Bug，会非常慢
                curl_setopt( self::$ch, CURLOPT_POSTFIELDS, $fields );
            }
        }

        $cookies = self::get_cookies();

Are you sure the assignment to $cookies is correct as self::get_cookies() targeting phpspider\core\requests::get_cookies() seems to always return null.

        $domain_cookies = self::get_cookies($domain);

Are you sure the assignment to $domain_cookies is correct as self::get_cookies($domain) targeting phpspider\core\requests::get_cookies() seems to always return null.

        $cookies =  array_merge($cookies, $domain_cookies);

$cookies of type void is incompatible with the type array expected by parameter $array1 of array_merge().

$domain_cookies of type void is incompatible with the type array|null expected by parameter $array2 of array_merge().

        // 是否设置了cookie
        if (!empty($cookies)) 
        {
            foreach ($cookies as $key=>$value) 
            {
                $cookie_arr[] = $key.'='.$value;
            }
            $cookies = implode('; ', $cookie_arr);

The variable $cookie_arr seems to be defined by a foreach iteration on line 766. Are you sure the iterator is never empty, otherwise this variable is not defined?

            curl_setopt(self::$ch, CURLOPT_COOKIE, $cookies);
        }

        if (!empty(self::$useragents)) 
        {
            $key = rand(0, count(self::$useragents) - 1);
            self::$rawheaders['User-Agent'] = self::$useragents[$key];
        }

        if (!empty(self::$client_ips)) 
        {
            $key                                 = rand(0, count(self::$client_ips) - 1);
            self::$rawheaders['CLIENT-IP']       = self::$client_ips[$key];
            self::$rawheaders['X-FORWARDED-FOR'] = self::$client_ips[$key];
        }

        if (self::$rawheaders)

The expression self::rawheaders of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        {
            $http_headers = array();
            foreach (self::$rawheaders as $k=>$v) 
            {
                $http_headers[] = $k.': '.$v;
            }
            curl_setopt( self::$ch, CURLOPT_HTTPHEADER, $http_headers );
        }

        curl_setopt( self::$ch, CURLOPT_ENCODING, 'gzip' );

        // 关闭验证
        if ($scheme == 'https') 
        {
            curl_setopt(self::$ch, CURLOPT_SSL_VERIFYPEER, false);
            curl_setopt(self::$ch, CURLOPT_SSL_VERIFYHOST, false);
        }

        if (self::$proxies)

The expression self::proxies of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        {
            $key = rand(0, count(self::$proxies) - 1);
            $proxy = self::$proxies[$key];
            curl_setopt( self::$ch, CURLOPT_PROXY, $proxy );
        }

        // header + body，header 里面有 cookie
        curl_setopt( self::$ch, CURLOPT_HEADER, true );
        // 请求跳转后的内容
        if ($allow_redirects)
        {
            curl_setopt( self::$ch, CURLOPT_FOLLOWLOCATION, true);
        }

        self::$raw = curl_exec ( self::$ch );
        // 真实url
        //$location = curl_getinfo( self::$ch, CURLINFO_EFFECTIVE_URL);
        self::$info = curl_getinfo( self::$ch );
        //print_r(self::$info);
        self::$status_code = self::$info['http_code'];
        if (self::$raw === false)
        {
            self::$error = 'Curl error: ' . curl_error( self::$ch );
            //trigger_error(self::$error, E_USER_WARNING);
        }

        // 关闭句柄
        curl_close( self::$ch );

        // 请求成功之后才把URL存起来
        list($header, $text) = self::split_header_body();

Are you sure the assignment to list($header, $text) is correct as self::split_header_body() targeting phpspider\core\requests::split_header_body() seems to always return null.

        self::$history = self::get_history($header);
        self::$headers = self::get_response_headers($header);

Are you sure the assignment to self::headers is correct as self::get_response_headers($header) targeting phpspider\core\requests::get_response_headers() seems to always return null.

        self::get_response_cookies($header, $domain);
        //$data = substr($data, 10);
        //$data = gzinflate($data);
        return $text;
    }