RicardoFiorani\Matcher\VideoServiceMatcher::parse()

Complexity

Conditions	5
Paths	5

Size

Total Lines

24

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

0

<?php declare(strict_types=1);
    public function parse($url): VideoAdapterInterface
    {
        if (isset($this->parsedUrls[$url])) {
            return $this->parsedUrls[$url];
        }

        /** @var array $patterns */
        /** @var string $serviceName */
        foreach ($this->getServiceContainer()->getPatterns() as $serviceName => $patterns) {
            /** @var string $pattern */
            foreach ($patterns as $pattern) {
                if (false != preg_match($pattern, $url)) {

It seems like you are loosely comparing preg_match($pattern, $url) of type integer to the boolean false. If you are specifically checking for non-zero, consider using something more explicit like > 0 or !== 0 instead.

                    $factory = $this->getServiceContainer()->getFactory($serviceName);

                    return $this->parsedUrls[$url] = $factory($url, $pattern,
                        $this->getServiceContainer()->getRenderer());
                }
            }
        }

        throw new VideoServiceNotCompatibleException(
            sprintf('The url "%s" could not be parsed by any of the services available.', $url)
        );
    }