YoutubeServiceAdapter::generateQuerystring() - Code Metrics - Inspection of "Merge pull request #7 from ricardofiorani/keep_que..." - ricardofiorani/php-video-url-parser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c49de5...415647 )

by Ricardo

created 2018-04-16 16:29 UTC

YoutubeServiceAdapter::generateQuerystring() A

↳ Parent: YoutubeServiceAdapter

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0932

Importance

Changes

Metric	Value
dl	0
loc	11
ccs	5
cts	7
cp	0.7143
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	1
crap	2.0932

<?php
/**
 * Created by PhpStorm.
 * User: Ricardo Fiorani
 * Date: 29/08/2015
 * Time: 14:53.
 */

namespace RicardoFiorani\Adapter\Youtube;

use RicardoFiorani\Adapter\AbstractServiceAdapter;
use RicardoFiorani\Exception\InvalidThumbnailSizeException;
use RicardoFiorani\Renderer\EmbedRendererInterface;

class YoutubeServiceAdapter extends AbstractServiceAdapter
{
    const THUMBNAIL_DEFAULT = 'default';
$a = "a";
$ab = "ab";
$abc = "abc";
    const THUMBNAIL_STANDARD_DEFINITION = 'sddefault';
    const THUMBNAIL_MEDIUM_QUALITY = 'mqdefault';
$a = "a";
$ab = "ab";
$abc = "abc";
    const THUMBNAIL_HIGH_QUALITY = 'hqdefault';
$a = "a";
$ab = "ab";
$abc = "abc";
    const THUMBNAIL_MAX_QUALITY = 'maxresdefault';
$a = "a";
$ab = "ab";
$abc = "abc";

    /**
     * @param string $url
     * @param string $pattern
     * @param EmbedRendererInterface $renderer
     */
    public function __construct($url, $pattern, EmbedRendererInterface $renderer)
    {
        preg_match($pattern, $url, $match);
        if (isset($match[2])) {
            $videoId = $match[2];
        }
        if (empty($videoId)) {
            $videoId = $match[1];
        }
        $this->setVideoId($videoId);

        return parent::__construct($url, $pattern, $renderer);

    }

    /**
     * Returns the service name (ie: "Youtube" or "Vimeo").
     *
     * @return string
     */
    public function getServiceName()
    {
        return 'Youtube';
    }

    /**
     * Returns if the service has a thumbnail image.
     *
     * @return bool
     */
    public function hasThumbnail()
    {
        return true;
    }

    /**
     * @param string $size
     * @param bool $forceSecure
     * @return string
     * @throws InvalidThumbnailSizeException
     */
    public function getThumbnail($size, $forceSecure = false)

    {
        if (false == in_array($size, $this->getThumbNailSizes())) {

            throw new InvalidThumbnailSizeException();
        }

        return $this->getScheme($forceSecure) . '://img.youtube.com/vi/' . $this->getVideoId() . '/' . $size . '.jpg';
    }

    /**
     * @return array

     */
    public function getThumbNailSizes()
    {
        return array(
            self::THUMBNAIL_DEFAULT,
            self::THUMBNAIL_STANDARD_DEFINITION,
            self::THUMBNAIL_MEDIUM_QUALITY,
            self::THUMBNAIL_HIGH_QUALITY,
            self::THUMBNAIL_MAX_QUALITY,
        );
    }

    /**
     * @param bool $forceAutoplay
     * @param bool $forceSecure
     * @return string
     */
    public function getEmbedUrl($forceAutoplay = false, $forceSecure = false)
    {
        $queryString = $this->generateQuerystring($forceAutoplay);

        return sprintf(
            '%s://www.youtube.com/embed/%s?%s',
            $this->getScheme($forceSecure),
            $this->getVideoId(),
            http_build_query($queryString)
        );
    }

    /**
     * Returns the small thumbnail's url.
     *
     * @return string
     */
    public function getSmallThumbnail($forceSecure = false)
    {
        return $this->getThumbnail(self::THUMBNAIL_STANDARD_DEFINITION, $forceSecure);
    }

    /**
     * Returns the medium thumbnail's url.
     *
     * @return string
     */
    public function getMediumThumbnail($forceSecure = false)
    {
        return $this->getThumbnail(self::THUMBNAIL_MEDIUM_QUALITY, $forceSecure);
    }

    /**
     * Returns the large thumbnail's url.
     *
     * @return string
     */
    public function getLargeThumbnail($forceSecure = false)
    {
        return $this->getThumbnail(self::THUMBNAIL_HIGH_QUALITY, $forceSecure);
    }

    /**
     * Returns the largest thumnbnaail's url.
     *
     * @return string
     */
    public function getLargestThumbnail($forceSecure = false)
    {
        return $this->getThumbnail(self::THUMBNAIL_MAX_QUALITY, $forceSecure);
    }

    /**
     * @return bool
     */
    public function isEmbeddable()
    {
        return true;
    }

    /**
     * @param bool $forceAutoplay
     * @return array

     */
    private function generateQuerystring($forceAutoplay = false)
    {
        parse_str(parse_url($this->rawUrl, PHP_URL_QUERY), $queryString);
        unset($queryString['v']);

        if ($forceAutoplay) {
            $queryString['autoplay'] = (int) $forceAutoplay;
        }

        return $queryString;
    }
}



1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: Ricardo Fiorani
5			* Date: 29/08/2015
6			* Time: 14:53.
7			*/
8
9			namespace RicardoFiorani\Adapter\Youtube;
10
11			use RicardoFiorani\Adapter\AbstractServiceAdapter;
12			use RicardoFiorani\Exception\InvalidThumbnailSizeException;
13			use RicardoFiorani\Renderer\EmbedRendererInterface;
14
15			class YoutubeServiceAdapter extends AbstractServiceAdapter
16			{
17			const THUMBNAIL_DEFAULT = 'default';
			0 ignored issues – show Coding Style introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
18			const THUMBNAIL_STANDARD_DEFINITION = 'sddefault';
19			const THUMBNAIL_MEDIUM_QUALITY = 'mqdefault';
			0 ignored issues – show Coding Style introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
20			const THUMBNAIL_HIGH_QUALITY = 'hqdefault';
			0 ignored issues – show Coding Style introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
21			const THUMBNAIL_MAX_QUALITY = 'maxresdefault';
			0 ignored issues – show Coding Style introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
22
23			/**
24			* @param string $url
25			* @param string $pattern
26			* @param EmbedRendererInterface $renderer
27			*/
28	14		public function __construct($url, $pattern, EmbedRendererInterface $renderer)
29			{
30	14		preg_match($pattern, $url, $match);
31	14		if (isset($match[2])) {
32	10		$videoId = $match[2];
33	10		}
34	14		if (empty($videoId)) {
35	4		$videoId = $match[1];
36	4		}
37	14		$this->setVideoId($videoId);
38
39	14		return parent::__construct($url, $pattern, $renderer);
			0 ignored issues – show Bug introduced 2016-07-20 01:32 UTC by Report Bug Copy Issue Report Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct? Loading history...
40			}
41
42			/**
43			* Returns the service name (ie: "Youtube" or "Vimeo").
44			*
45			* @return string
46			*/
47	1		public function getServiceName()
48			{
49	1		return 'Youtube';
50			}
51
52			/**
53			* Returns if the service has a thumbnail image.
54			*
55			* @return bool
56			*/
57	1		public function hasThumbnail()
58			{
59	1		return true;
60			}
61
62			/**
63			* @param string $size
64			* @param bool $forceSecure
65			* @return string
66			* @throws InvalidThumbnailSizeException
67			*/
68	2	View Code Duplication	public function getThumbnail($size, $forceSecure = false)
			0 ignored issues – show Duplication introduced 2018-04-16 10:19 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69			{
70	2		if (false == in_array($size, $this->getThumbNailSizes())) {
			0 ignored issues – show Coding Style Best Practice introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing two booleans. Considering using the strict comparison `===` instead. When comparing two booleans, it is generally considered safer to use the strict comparison operator. Loading history...
71	1		throw new InvalidThumbnailSizeException();
72			}
73
74	1		return $this->getScheme($forceSecure) . '://img.youtube.com/vi/' . $this->getVideoId() . '/' . $size . '.jpg';
75			}
76
77			/**
78			* @return array
			0 ignored issues – show Documentation introduced 2016-02-11 16:29 UTC by Report Bug Copy Issue Report Consider making the return type a bit more specific; maybe use `string[]`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
79			*/
80	3		public function getThumbNailSizes()
81			{
82			return array(
83	3		self::THUMBNAIL_DEFAULT,
84	3		self::THUMBNAIL_STANDARD_DEFINITION,
85	3		self::THUMBNAIL_MEDIUM_QUALITY,
86	3		self::THUMBNAIL_HIGH_QUALITY,
87	3		self::THUMBNAIL_MAX_QUALITY,
88	3		);
89			}
90
91			/**
92			* @param bool $forceAutoplay
93			* @param bool $forceSecure
94			* @return string
95			*/
96	2		public function getEmbedUrl($forceAutoplay = false, $forceSecure = false)
97			{
98	2		$queryString = $this->generateQuerystring($forceAutoplay);
99
100	2		return sprintf(
101	2		'%s://www.youtube.com/embed/%s?%s',
102	2		$this->getScheme($forceSecure),
103	2		$this->getVideoId(),
104	2		http_build_query($queryString)
105	2		);
106			}
107
108			/**
109			* Returns the small thumbnail's url.
110			*
111			* @return string
112			*/
113	1		public function getSmallThumbnail($forceSecure = false)
114			{
115	1		return $this->getThumbnail(self::THUMBNAIL_STANDARD_DEFINITION, $forceSecure);
116			}
117
118			/**
119			* Returns the medium thumbnail's url.
120			*
121			* @return string
122			*/
123	1		public function getMediumThumbnail($forceSecure = false)
124			{
125	1		return $this->getThumbnail(self::THUMBNAIL_MEDIUM_QUALITY, $forceSecure);
126			}
127
128			/**
129			* Returns the large thumbnail's url.
130			*
131			* @return string
132			*/
133	1		public function getLargeThumbnail($forceSecure = false)
134			{
135	1		return $this->getThumbnail(self::THUMBNAIL_HIGH_QUALITY, $forceSecure);
136			}
137
138			/**
139			* Returns the largest thumnbnaail's url.
140			*
141			* @return string
142			*/
143	1		public function getLargestThumbnail($forceSecure = false)
144			{
145	1		return $this->getThumbnail(self::THUMBNAIL_MAX_QUALITY, $forceSecure);
146			}
147
148			/**
149			* @return bool
150			*/
151	1		public function isEmbeddable()
152			{
153	1		return true;
154			}
155
156			/**
157			* @param bool $forceAutoplay
158			* @return array
			0 ignored issues – show Documentation introduced 2018-04-16 16:25 UTC by Report Bug Copy Issue Report Should the return type not be `null\|array`? Also, consider making the array more specific, something like `array<String>`, or `String[]`. This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. If the return type contains the type array, this check recommends the use of a more specific type like `String[]` or `array<String>`. Loading history...
159			*/
160	2		private function generateQuerystring($forceAutoplay = false)
161			{
162	2		parse_str(parse_url($this->rawUrl, PHP_URL_QUERY), $queryString);
163	2		unset($queryString['v']);
164
165	2		if ($forceAutoplay) {
166			$queryString['autoplay'] = (int) $forceAutoplay;
167			}
168
169	2		return $queryString;
170			}
171			}
			0 ignored issues – show Coding Style introduced 2018-04-16 16:25 UTC by Report Bug Copy Issue Report As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
172

ricardofiorani / php-video-url-parser

Push — master ( c49de5...415647 )

YoutubeServiceAdapter::generateQuerystring() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like