RicardoFiorani\Adapter\Youtube\YoutubeServiceAdapter

Complexity

Total Complexity

16

Size/Duplication

Total Lines	157
Duplicated Lines	5.1 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

96%

Importance

Changes	1
Bugs	0	Features	0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	3
A	getServiceName()	0	4	1
A	hasThumbnail()	0	4	1
A	getThumbnail()	8	8	2
A	getThumbNailSizes()	0	10	1
A	getEmbedUrl()	0	11	1
A	getSmallThumbnail()	0	4	1
A	getMediumThumbnail()	0	4	1
A	getLargeThumbnail()	0	4	1
A	getLargestThumbnail()	0	4	1
A	isEmbeddable()	0	4	1
A	generateQuerystring()	0	11	2

<?php
/**
 * Created by PhpStorm.
 * User: Ricardo Fiorani
 * Date: 29/08/2015
 * Time: 14:53.
 */

namespace RicardoFiorani\Adapter\Youtube;

use RicardoFiorani\Adapter\AbstractServiceAdapter;
use RicardoFiorani\Exception\InvalidThumbnailSizeException;
use RicardoFiorani\Renderer\EmbedRendererInterface;

class YoutubeServiceAdapter extends AbstractServiceAdapter
{
    const THUMBNAIL_DEFAULT = 'default';

Equals sign not aligned with surrounding assignments; expected 13 spaces but found 1 space

    const THUMBNAIL_STANDARD_DEFINITION = 'sddefault';
    const THUMBNAIL_MEDIUM_QUALITY = 'mqdefault';

Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space

    const THUMBNAIL_HIGH_QUALITY = 'hqdefault';

Equals sign not aligned with surrounding assignments; expected 8 spaces but found 1 space

    const THUMBNAIL_MAX_QUALITY = 'maxresdefault';

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 1 space

    /**
     * @param string $url
     * @param string $pattern
     * @param EmbedRendererInterface $renderer
     */
    public function __construct($url, $pattern, EmbedRendererInterface $renderer)
    {
        preg_match($pattern, $url, $match);
        if (isset($match[2])) {
            $videoId = $match[2];
        }
        if (empty($videoId)) {
            $videoId = $match[1];
        }
        $this->setVideoId($videoId);

        return parent::__construct($url, $pattern, $renderer);

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }

    /**
     * Returns the service name (ie: "Youtube" or "Vimeo").
     *
     * @return string
     */
    public function getServiceName()
    {
        return 'Youtube';
    }

    /**
     * Returns if the service has a thumbnail image.
     *
     * @return bool
     */
    public function hasThumbnail()
    {
        return true;
    }

    /**
     * @param string $size
     * @param bool $forceSecure
     * @return string
     * @throws InvalidThumbnailSizeException
     */
    public function getThumbnail($size, $forceSecure = false)

This method seems to be duplicated in your project.

    {
        if (false == in_array($size, $this->getThumbNailSizes())) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            throw new InvalidThumbnailSizeException();
        }

        return $this->getScheme($forceSecure) . '://img.youtube.com/vi/' . $this->getVideoId() . '/' . $size . '.jpg';
    }

    /**
     * @return array

Consider making the return type a bit more specific; maybe use string[].

     */
    public function getThumbNailSizes()
    {
        return array(
            self::THUMBNAIL_DEFAULT,
            self::THUMBNAIL_STANDARD_DEFINITION,
            self::THUMBNAIL_MEDIUM_QUALITY,
            self::THUMBNAIL_HIGH_QUALITY,
            self::THUMBNAIL_MAX_QUALITY,
        );
    }

    /**
     * @param bool $forceAutoplay
     * @param bool $forceSecure
     * @return string
     */
    public function getEmbedUrl($forceAutoplay = false, $forceSecure = false)
    {
        $queryString = $this->generateQuerystring($forceAutoplay);

        return sprintf(
            '%s://www.youtube.com/embed/%s?%s',
            $this->getScheme($forceSecure),
            $this->getVideoId(),
            http_build_query($queryString)
        );
    }

    /**
     * Returns the small thumbnail's url.
     *
     * @return string
     */
    public function getSmallThumbnail($forceSecure = false)
    {
        return $this->getThumbnail(self::THUMBNAIL_STANDARD_DEFINITION, $forceSecure);
    }

    /**
     * Returns the medium thumbnail's url.
     *
     * @return string
     */
    public function getMediumThumbnail($forceSecure = false)
    {
        return $this->getThumbnail(self::THUMBNAIL_MEDIUM_QUALITY, $forceSecure);
    }

    /**
     * Returns the large thumbnail's url.
     *
     * @return string
     */
    public function getLargeThumbnail($forceSecure = false)
    {
        return $this->getThumbnail(self::THUMBNAIL_HIGH_QUALITY, $forceSecure);
    }

    /**
     * Returns the largest thumnbnaail's url.
     *
     * @return string
     */
    public function getLargestThumbnail($forceSecure = false)
    {
        return $this->getThumbnail(self::THUMBNAIL_MAX_QUALITY, $forceSecure);
    }

    /**
     * @return bool
     */
    public function isEmbeddable()
    {
        return true;
    }

    /**
     * @param bool $forceAutoplay
     * @return array

Should the return type not be null|array? Also, consider making the array more specific, something like array<String>, or String[].

     */
    private function generateQuerystring($forceAutoplay = false)
    {
        parse_str(parse_url($this->rawUrl, PHP_URL_QUERY), $queryString);
        unset($queryString['v']);

        if ($forceAutoplay) {
            $queryString['autoplay'] = (int) $forceAutoplay;
        }

        return $queryString;
    }
}

As per coding style, files should not end with a newline character.