Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
14 | class DailymotionServiceAdapter extends AbstractServiceAdapter |
||
15 | { |
||
16 | const THUMBNAIL_DEFAULT = 'thumbnail'; |
||
17 | |||
18 | /** |
||
19 | * AbstractVideoAdapter constructor. |
||
20 | * |
||
21 | * @param string $url |
||
22 | * @param string $pattern |
||
23 | * @param EmbedRendererInterface $renderer |
||
24 | */ |
||
25 | public function __construct($url, $pattern, EmbedRendererInterface $renderer) |
||
32 | |||
33 | /** |
||
34 | * Returns the service name (ie: "Youtube" or "Vimeo"). |
||
35 | * |
||
36 | * @return string |
||
37 | */ |
||
38 | public function getServiceName() |
||
42 | |||
43 | /** |
||
44 | * Returns if the service has a thumbnail image. |
||
45 | * |
||
46 | * @return bool |
||
47 | */ |
||
48 | public function hasThumbnail() |
||
52 | |||
53 | /** |
||
54 | * Returns all thumbnails available sizes. |
||
55 | * |
||
56 | * @return array |
||
57 | */ |
||
58 | public function getThumbNailSizes() |
||
64 | |||
65 | /** |
||
66 | * @param string $size |
||
67 | * @param bool $forceSecure |
||
68 | * |
||
69 | * @return string |
||
70 | * @throws InvalidThumbnailSizeException |
||
71 | * @throws \RicardoFiorani\Adapter\Exception\InvalidUrlException |
||
72 | */ |
||
73 | View Code Duplication | public function getThumbnail($size, $forceSecure = false) |
|
81 | |||
82 | /** |
||
83 | * Returns the small thumbnail's url. |
||
84 | * |
||
85 | * @param bool $forceSecure |
||
86 | * @return string |
||
87 | * @throws InvalidThumbnailSizeException |
||
88 | * @throws \RicardoFiorani\Adapter\Exception\InvalidUrlException |
||
89 | */ |
||
90 | public function getSmallThumbnail($forceSecure = false) |
||
95 | |||
96 | /** |
||
97 | * Returns the medium thumbnail's url. |
||
98 | * |
||
99 | * @param bool $forceSecure |
||
100 | * @return string |
||
101 | * @throws InvalidThumbnailSizeException |
||
102 | * @throws \RicardoFiorani\Adapter\Exception\InvalidUrlException |
||
103 | */ |
||
104 | public function getMediumThumbnail($forceSecure = false) |
||
109 | |||
110 | /** |
||
111 | * Returns the large thumbnail's url. |
||
112 | * |
||
113 | * @param bool $forceSecure |
||
114 | * @return string |
||
115 | * @throws InvalidThumbnailSizeException |
||
116 | * @throws \RicardoFiorani\Adapter\Exception\InvalidUrlException |
||
117 | */ |
||
118 | public function getLargeThumbnail($forceSecure = false) |
||
123 | |||
124 | /** |
||
125 | * Returns the largest thumnbnaail's url. |
||
126 | * @param bool $forceSecure |
||
127 | * @return string |
||
128 | * @throws InvalidThumbnailSizeException |
||
129 | * @throws \RicardoFiorani\Adapter\Exception\InvalidUrlException |
||
130 | */ |
||
131 | public function getLargestThumbnail($forceSecure = false) |
||
136 | |||
137 | /** |
||
138 | * @param bool $forceAutoplay |
||
139 | * @param bool $forceSecure |
||
140 | * @return string |
||
141 | * @throws \RicardoFiorani\Adapter\Exception\InvalidUrlException |
||
142 | */ |
||
143 | public function getEmbedUrl($forceAutoplay = false, $forceSecure = false) |
||
147 | |||
148 | /** |
||
149 | * @return bool |
||
150 | */ |
||
151 | public function isEmbeddable() |
||
155 | } |
||
156 |