ValidationResponseFactory::createFromGuzzleResponse() - Code Metrics - Inspection of "Add General HTTP improvements" - ricardofiorani/php-cloudflare-amp-validator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Ricardo

created 2018-09-10 09:24 UTC

createFromGuzzleResponse() A

↳ Parent: ValidationResponseFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	11
cts	11
cp	1
rs	9.7333
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2

<?php declare(strict_types=1);

namespace RicardoFiorani\Validator\Response;

use Psr\Http\Message\ResponseInterface;
use RicardoFiorani\Validator\Response\Error\Collection\ErrorCollection;
use RicardoFiorani\Validator\Response\Error\ValidationError;

class ValidationResponseFactory
{
    public function create(ResponseInterface $response): ValidationResponseInterface
    {
        $jsonResponse = (string)$response->getBody();
        $jsonResponseObject = json_decode($jsonResponse);

        $errorCollection = $jsonResponseObject->valid ?
            new ErrorCollection() :
            $this->createErrorCollectionFromJsonResponseObject($jsonResponseObject);

        return new ValidationResponse(
            $jsonResponseObject->source,
            $jsonResponseObject->version,
            $jsonResponseObject->valid,
            $errorCollection
        );
    }

    private function createErrorCollectionFromJsonResponseObject(\stdClass $jsonResponseObject): ErrorCollection
    {
        $collection = new ErrorCollection();

        foreach ($jsonResponseObject->errors as $error) {
            $collection->add(
                new ValidationError(
                    $error->code,
                    $error->error,
                    $error->help,
                    $error->line,
                    $error->col
                )
            );
        }

        return $collection;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace RicardoFiorani\Validator\Response;
4
5			use Psr\Http\Message\ResponseInterface;
6			use RicardoFiorani\Validator\Response\Error\Collection\ErrorCollection;
7			use RicardoFiorani\Validator\Response\Error\ValidationError;
8
9			class ValidationResponseFactory
10			{
11			public function create(ResponseInterface $response): ValidationResponseInterface
12			{
13			$jsonResponse = (string)$response->getBody();
14			$jsonResponseObject = json_decode($jsonResponse);
15
16			$errorCollection = $jsonResponseObject->valid ?
17			new ErrorCollection() :
18			$this->createErrorCollectionFromJsonResponseObject($jsonResponseObject);
19
20			return new ValidationResponse(
21			$jsonResponseObject->source,
22			$jsonResponseObject->version,
23			$jsonResponseObject->valid,
24			$errorCollection
25			);
26			}
27
28			private function createErrorCollectionFromJsonResponseObject(\stdClass $jsonResponseObject): ErrorCollection
29			{
30			$collection = new ErrorCollection();
31
32			foreach ($jsonResponseObject->errors as $error) {
33			$collection->add(
34			new ValidationError(
35			$error->code,
36			$error->error,
37			$error->help,
38			$error->line,
39			$error->col
40			)
41			);
42			}
43
44			return $collection;
45			}
46			}
47

ricardofiorani / php-cloudflare-amp-validator

Pull Request — master (#9)

createFromGuzzleResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like