rhosocial / yii2-user

grid/ActionColumn.php

<?php

/**
 *  _   __ __ _____ _____ ___  ____  _____
 * | | / // // ___//_  _//   ||  __||_   _|
 * | |/ // /(__  )  / / / /| || |     | |
 * |___//_//____/  /_/ /_/ |_||_|     |_|
 * @link https://vistart.me/
 * @copyright Copyright (c) 2016 - 2017 vistart
 * @license https://vistart.me/license/
 */

namespace rhosocial\user\grid;

use Yii;
use yii\helpers\Html;

/**
 * Class ActionColumn
 * @package rhosocial\user\grid
 * @version 1.0
 * @author vistart <i@vistart.me>
 */
class ActionColumn extends \yii\grid\ActionColumn
{
    /**
     * @var bool Indicate whether the default buttons use icon or not.
     */
    public $useIcon = true;

    /**
     * Initializes the default button rendering callbacks.
     */
    protected function initDefaultButtons()
    {
        $this->initDefaultButton('view', $this->useIcon ? 'eye-open' : false);

It seems like $this->useIcon ? 'eye-open' : false can also be of type false; however, rhosocial\user\grid\ActionColumn::initDefaultButton() does only seem to accept string, did you maybe forget to handle an error condition?

        $this->initDefaultButton('update', $this->useIcon ? 'pencil' : false);

It seems like $this->useIcon ? 'pencil' : false can also be of type false; however, rhosocial\user\grid\ActionColumn::initDefaultButton() does only seem to accept string, did you maybe forget to handle an error condition?

        $this->initDefaultButton('delete', $this->useIcon ? 'trash' : false, [

It seems like $this->useIcon ? 'trash' : false can also be of type false; however, rhosocial\user\grid\ActionColumn::initDefaultButton() does only seem to accept string, did you maybe forget to handle an error condition?

            'data-confirm' => Yii::t('yii', 'Are you sure you want to delete this item?'),
            'data-method' => 'post',
        ]);
    }

    /**
     * Initializes the default button rendering callback for single button
     * @param string $name Button name as it's written in template
     * @param string $iconName The part of Bootstrap glyphicon class that makes it unique
     * @param array $additionalOptions Array of additional options
     */
    protected function initDefaultButton($name, $iconName, $additionalOptions = [])
    {
        if (!isset($this->buttons[$name]) && strpos($this->template, '{' . $name . '}') !== false) {
            $this->buttons[$name] = function ($url, $model, $key) use ($name, $iconName, $additionalOptions) {

The parameter $model is not used and could be removed.

The parameter $key is not used and could be removed.

                switch ($name) {
                    case 'view':
                        $title = Yii::t('yii', 'View');
                        break;
                    case 'update':
                        $title = Yii::t('yii', 'Update');
                        break;
                    case 'delete':
                        $title = Yii::t('yii', 'Delete');
                        break;
                    default:
                        $title = ucfirst($name);
                }
                $options = array_merge([
                    'title' => $title,
                    'aria-label' => $title,
                    'data-pjax' => '0',
                ], $additionalOptions, $this->buttonOptions);
                if ($iconName == false) {

It seems like you are loosely comparing $iconName of type string to the boolean false. If you are specifically checking for an empty string, consider using the more explicit === '' instead.

                    $icon = $options['title'];
                } else {
                    $icon = Html::tag('span', '', ['class' => "glyphicon glyphicon-$iconName"]);
                }
                return Html::a($icon, $url, $options);
            };
        }
    }
}