rhosocial / yii2-user

forms/ChangePasswordForm.php

<?php

/**
 *  _   __ __ _____ _____ ___  ____  _____
 * | | / // // ___//_  _//   ||  __||_   _|
 * | |/ // /(__  )  / / / /| || |     | |
 * |___//_//____/  /_/ /_/ |_||_|     |_|
 * @link https://vistart.me/
 * @copyright Copyright (c) 2016 - 2017 vistart
 * @license https://vistart.me/license/
 */

namespace rhosocial\user\forms;

use rhosocial\user\User;
use Yii;
use yii\base\Model;

/**
 * @version 1.0
 * @author vistart <i@vistart.me>
 */
class ChangePasswordForm extends Model
{
    public $password;
    public $new_password;
    public $new_password_repeat;
    private $_user = false;

    const SCENARIO_ADMIN = 'admin';

    public function attributeLabels()
    {
        return [
            'password' => Yii::t('user', 'Password'),
            'new_password' => Yii::t('user', 'New Password'),
            'new_password_repeat' => Yii::t('user', 'New Password Repeat'),
        ];
    }

    public function rules()
    {
        return [
            ['password', 'required', 'on' =>self::SCENARIO_DEFAULT],
            [['new_password', 'new_password_repeat'], 'required'],
            ['password', 'string', 'min' => 6, 'max' => 32, 'on' => self::SCENARIO_DEFAULT],
            [['new_password', 'new_password_repeat'], 'string', 'min' => 6, 'max' => 32],
            ['password', 'validatePassword', 'on' => self::SCENARIO_DEFAULT],
            ['new_password', 'compare'],
        ];
    }

    public function clearAttributes()
    {
        $this->password = '';
        $this->new_password = '';
        $this->new_password_repeat = '';
    }

    /**
     * Validates the password.
     * This method serves as the inline validation for password.
     *
     * @param string $attribute the attribute currently being validated
     * @param array $params the additional name-value pairs given in the rule
     */
    public function validatePassword($attribute, $params)

The parameter $params is not used and could be removed.

    {
        if (!$this->hasErrors()) {
            $user = $this->getUser();

            if (!$user || !$user->validatePassword($this->password)) {

The method validatePassword cannot be called on $user (of type boolean).

                $this->addError($attribute, Yii::t('user', 'Incorrect password.'));
            }
        }
    }

    /**
     * Change password.
     * @return boolean Whether the password changed.
     */
    public function changePassword()
    {
        if ($this->validate()) {
            if (!($user = $this->getUser())) {
                return false;
            }
            if (!$user->applyForNewPassword()) {

The method applyForNewPassword cannot be called on $user (of type boolean).

                return false;
            }
            return $user->resetPassword($this->new_password, $user->getPasswordResetToken());

The method getPasswordResetToken cannot be called on $user (of type boolean).

The method resetPassword cannot be called on $user (of type boolean).

        }
        return false;
    }

    /**
     * Set user.
     * @param User $user
     * @return bool
     */
    public function setUser($user)
    {
        if ($user instanceof User) {
            $this->_user = $user;

It seems like $user of type object<rhosocial\user\User> is incompatible with the declared type boolean of property $_user.

            return true;
        }
        $this->_user = null;
        return false;
    }

    /**
     * Finds user.
     *
     * @return User|null
     */
    public function getUser()
    {
        return $this->_user;
    }

    /**
     * This method adds ADMIN scenario, because the administrator does not need
     * to know the original password when changing it.
     * @return array scenarios.
     */
    public function scenarios()
    {
        return array_merge(parent::scenarios(), [
            self::SCENARIO_ADMIN => ['new_password', 'new_password_repeat'],
        ]);
    }
}