rhosocial\user\security\UserPasswordHistoryTrait

Complexity

Total Complexity

24

Size/Duplication

Total Lines	133
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

97.92%

Importance

Changes	4
Bugs	1	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getPasswordHistories()	0	8	3
C	onAddPasswordToHistory()	0	23	8
A	addPasswordHistory()	0	8	3
A	addPasswordHashToHistory()	0	8	3
B	getPasswordHashRules()	0	14	5
A	checkPasswordNotUsed()	0	9	2

<?php

/**
 *  _   __ __ _____ _____ ___  ____  _____
 * | | / // // ___//_  _//   ||  __||_   _|
 * | |/ // /(__  )  / / / /| || |     | |
 * |___//_//____/  /_/ /_/ |_||_|     |_|
 * @link https://vistart.me/
 * @copyright Copyright (c) 2016 - 2017 vistart
 * @license https://vistart.me/license/
 */

namespace rhosocial\user\security;

use yii\base\ModelEvent;
use yii\base\InvalidParamException;

/**
 * This trait provides password history operation for User model.
 *
 * @property-read PasswordHistory[] $passwordHistories
 *
 * @version 1.0
 * @author vistart <i@vistart.me>
 */
trait UserPasswordHistoryTrait
{
    /**
     * @var string|false Password History class name. If you do not need password
     * history model, please set it false.
     */
    public $passwordHistoryClass = false;
    
    /**
     * @var boolean determine whether to allow the password that has been used to be stored.
     */
    public $allowUsedPassword = true;
    
    /**
     * Get all password histories sorted by creation time in descending order.
     * @return boolean|PasswordHistory[] False if password history class is invalid.
     */
    public function getPasswordHistories()
    {
        if (empty($this->passwordHistoryClass) || !class_exists($this->passwordHistoryClass)) {
            return false;
        }
        $class = $this->passwordHistoryClass;
        return $class::find()->createdBy($this)->orderByCreatedAt(SORT_DESC)->all();
    }
    
    /**
     * This event is ONLY used for adding password to history.
     * You SHOULD NOT call this method directly, or you know the consequences of doing so
     * @param ModelEvent $event
     * @return boolean False if no password was added to history.
     */
    public function onAddPasswordToHistory($event)
    {
        $password = $event->data;
        $sender = $event->sender;
        /* @var $sender static */
        if (empty($sender->passwordHistoryClass) ||
                !class_exists($sender->passwordHistoryClass) ||
                empty($sender->passwordHashAttribute) ||

The property passwordHashAttribute does not exist. Did you maybe forget to declare it?

                !is_string($sender->passwordHashAttribute)) {
            return false;
        }
        if (empty($password)) {
            $password = ['pass_hash' => $sender->{$sender->passwordHashAttribute}];
        }
        $class = $sender->passwordHistoryClass;
        if (array_key_exists('pass_hash', $password)) {
            return $class::addHash($password['pass_hash'], $sender);
        }
        if (array_key_exists('password', $password)) {
            return $class::add($password['password'], $sender);
        }
        return false;
    }

    /**
     * Add password to history.
     * Note: Please specify password history class before using this method.
     *
     * @param string $password the password to be added.
     * @return boolean whether the password added. False if password history class not specified.
     * @throws InvalidParamException throw if password existed.
     */
    public function addPasswordHistory($password)
    {
        if (!empty($this->passwordHistoryClass) && class_exists($this->passwordHistoryClass)) {
            $class = $this->passwordHistoryClass;
            return $class::add($password, $this);
        }
        return false;
    }
    
    /**
     * Add password hash to history.
     * Note: Please specify password history class before using this method.
     *
     * @param string $passHash Password hash to be added.
     * @return boolean whether the password hash added. False if password history class not specified.
     * @throws InvalidParamException throw if password existed.
     */
    public function addPasswordHashToHistory($passHash)
    {
        if (!empty($this->passwordHistoryClass) && class_exists($this->passwordHistoryClass)) {
            $class = $this->passwordHistoryClass;
            return $class::addHash($passHash, $this);
        }
        return false;
    }
    
    /**
     * @inheritdoc
     */
    public function getPasswordHashRules()
    {
        if (empty($this->passwordHashAttribute) || !is_string($this->passwordHashAttribute)) {
            return [];
        }
        $rules = parent::getPasswordHashRules();
        $rules[] = [
            [$this->passwordHashAttribute], 'checkPasswordNotUsed', 'when' => function () {
                return $this->isAttributeChanged($this->passwordHashAttribute)

It seems like isAttributeChanged() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                        && !$this->allowUsedPassword && !$this->getIsNewRecord();

It seems like getIsNewRecord() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
        ];
        return $rules;
    }
    
    /**
     * @var string The message for password used error.
     */
    public $passwordUsedMessage = 'The password has been used.';
    
    public static $eventPasswordUsed = 'passwordUsed';

    /**
     * This method is only used for password hash attribute validation.
     * If password is used, the `eventPasswordUsed` event will be triggered.
     *
     * @param string $attribute
     * @param mixed $params
     * @param type $validator
     */
    public function checkPasswordNotUsed($attribute, $params, $validator)

The parameter $params is not used and could be removed.

The parameter $validator is not used and could be removed.

    {
        $class = $this->passwordHistoryClass;
        $result = $class::isUsed($this->_password, $this);

The property _password does not exist. Did you maybe forget to declare it?

        if ($result != false) {
            $this->trigger(static::$eventPasswordUsed);

It seems like trigger() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->addError($attribute, $this->passwordUsedMessage);

It seems like addError() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }
    }
}