Member - Code Metrics - Inspection of "add queries & trait for user." - rhosocial/yii2-organization - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 42128a...09a28f )

by vistart

created 2017-03-27 16:08 UTC

Member A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes

Metric	Value
wmc	11
lcom	2
cbo	2
dl	0
loc	82
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	getNoInitMemberUser()	8	2
A	init()	10	3
A	getMemberUserRules()	7	1
A	setMemberUser()	4	1
A	getMemberUser()	4	1
A	getOrganization()	4	1
A	rules()	4	1
A	tableName()	4	1

<?php

/**
 *  _   __ __ _____ _____ ___  ____  _____
 * | | / // // ___//_  _//   ||  __||_   _|
 * | |/ // /(__  )  / / / /| || |     | |
 * |___//_//____/  /_/ /_/ |_||_|     |_|
 * @link https://vistart.me/
 * @copyright Copyright (c) 2016 - 2017 vistart
 * @license https://vistart.me/license/
 */

namespace rhosocial\organization;

use rhosocial\base\models\models\BaseBlameableModel;
use rhosocial\user\User;
use rhosocial\organization\queries\OrganizationQuery;
use rhosocial\organization\queries\MemberQuery;

/**
 * Organization member.
 *
 * @property string $organization_guid
 * @proprtyy string $user_guid
 * @property string $nickname
 * @property string $description
 * 
 * @property string $department_guid
 * @property string $member_guid
 * @property User $memberUser
 *
 * @version 1.0
 * @author vistart <[email protected]>
 */
class Member extends BaseBlameableModel
{
    public $createdByAttribute = 'organization_guid';
    public $updatedByAttribute = false;
    public $hostClass = Organization::class;

    public $memberAttribute = 'user_guid';
    public $memberUserClass = User::class;
    private $noInitMemberUser;
    /**
     * @return User
     */
    protected function getNoInitMemberUser()
    {
        if (!$this->noInitMemberUser) {
            $class = $this->memberUserClass;
            $this->noInitMemberUser = $class::buildNoInitModel();
        }
        return $this->noInitMemberUser;
    }

    /**
     * @inheritdoc
     */
    public function init()
    {
        if (!is_string($this->queryClass)) {
            $this->queryClass = MemberQuery::class;
        }
        if ($this->skipInit) {
            return;
        }
        parent::init();
    }

    public $descriptionAttribute = 'description';

    public function getMemberUserRules()
    {
        return [
            [$this->memberAttribute, 'required'],
            [$this->memberAttribute, 'string', 'max' => 36],
        ];
    }

    /**
     * 
     * @param User $user
     */
    public function setMemberUser($user)
    {
        $this->user_guid = $user->getGUID();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getMemberUser()
    {
        return $this->hasOne($this->memberUserClass, [$this->memberAttribute => $this->getNoInitMemberUser()->guidAttribute]);
    }

    /**
     * Get Organization Query.
     * Alias of `getHost` method.
     * @return OrganizationQuery
     */
    public function getOrganization()
    {
        return $this->getHost();
    }

    public function rules()
    {
        return array_merge($this->getMemberUserRules(), parent::rules());
    }

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%organization_member}}';
    }
}


1			<?php
2
3			/**
4			* _ __ __ _____ _____ ___ ____ _____
5			* \| \| / // // ___//_ _// \|\| __\|\|_ _\|
6			* \| \|/ // /(__ ) / / / /\| \|\| \| \| \|
7			* \|___//_//____/ /_/ /_/ \|_\|\|_\| \|_\|
8			* @link https://vistart.me/
9			* @copyright Copyright (c) 2016 - 2017 vistart
10			* @license https://vistart.me/license/
11			*/
12
13			namespace rhosocial\organization;
14
15			use rhosocial\base\models\models\BaseBlameableModel;
16			use rhosocial\user\User;
17			use rhosocial\organization\queries\OrganizationQuery;
18			use rhosocial\organization\queries\MemberQuery;
19
20			/**
21			* Organization member.
22			*
23			* @property string $organization_guid
24			* @proprtyy string $user_guid
25			* @property string $nickname
26			* @property string $description
27			*
28			* @property string $department_guid
29			* @property string $member_guid
30			* @property User $memberUser
31			*
32			* @version 1.0
33			* @author vistart <[email protected]>
34			*/
35			class Member extends BaseBlameableModel
36			{
37			public $createdByAttribute = 'organization_guid';
38			public $updatedByAttribute = false;
39			public $hostClass = Organization::class;
40
41			public $memberAttribute = 'user_guid';
42			public $memberUserClass = User::class;
43			private $noInitMemberUser;
44			/**
45			* @return User
46			*/
47			protected function getNoInitMemberUser()
48			{
49			if (!$this->noInitMemberUser) {
50			$class = $this->memberUserClass;
51			$this->noInitMemberUser = $class::buildNoInitModel();
52			}
53			return $this->noInitMemberUser;
54			}
55
56			/**
57			* @inheritdoc
58			*/
59			public function init()
60			{
61			if (!is_string($this->queryClass)) {
62			$this->queryClass = MemberQuery::class;
63			}
64			if ($this->skipInit) {
65			return;
66			}
67			parent::init();
68			}
69
70			public $descriptionAttribute = 'description';
71
72			public function getMemberUserRules()
73			{
74			return [
75			[$this->memberAttribute, 'required'],
76			[$this->memberAttribute, 'string', 'max' => 36],
77			];
78			}
79
80			/**
81			*
82			* @param User $user
83			*/
84			public function setMemberUser($user)
85			{
86			$this->user_guid = $user->getGUID();
			0 ignored issues – show Documentation introduced 2017-03-27 12:33 UTC by Report Bug Copy Issue Report The property `user_guid` does not exist on `object<rhosocial\organization\Member>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
87			}
88
89			public function getMemberUser()
90			{
91			return $this->hasOne($this->memberUserClass, [$this->memberAttribute => $this->getNoInitMemberUser()->guidAttribute]);
92			}
93
94			/**
95			* Get Organization Query.
96			* Alias of `getHost` method.
97			* @return OrganizationQuery
98			*/
99			public function getOrganization()
100			{
101			return $this->getHost();
102			}
103
104			public function rules()
105			{
106			return array_merge($this->getMemberUserRules(), parent::rules());
107			}
108
109			/**
110			* @inheritdoc
111			*/
112			public static function tableName()
113			{
114			return '{{%organization_member}}';
115			}
116			}
117

rhosocial / yii2-organization

Push — master ( 42128a...09a28f )

Member A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like