QueryTrait - Code Metrics - Inspection of "try to fix user identity issue." - rhosocial/yii2-base-models - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9249bd...d27445 )

by vistart

created 2017-01-13 19:09 UTC

QueryTrait A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

35.7%

Importance

Changes

Metric	Value
wmc	7
lcom	0
cbo	1
dl	0
loc	40
ccs	5
cts	14
cp	0.357
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	range()	0	10	3
A	likeCondition()	0	10	4

<?php

/**
 *   _   __ __ _____ _____ ___  ____  _____
 *  | | / // // ___//_  _//   ||  __||_   _|
 *  | |/ // /(__  )  / / / /| || |     | |
 *  |___//_//____/  /_/ /_/ |_||_|     |_|
 * @link https://vistart.me/
 * @copyright Copyright (c) 2016 - 2017 vistart
 * @license https://vistart.me/license/
 */

namespace rhosocial\base\models\traits;

use yii\db\ActiveQuery;

/**
 * This trait attach two base conditions.
 * 
 * @version 1.0
 * @author vistart <[email protected]>
 */
trait QueryTrait
{

    /**
     * Attach like condition.
     * @param mixed $value
     * @param string $attribute
     * @param string|false $like false, 'like', 'or like', 'not like', 'or not like'.
     * @return $this
     */
    protected function likeCondition($value, $attribute, $like = false)
    {
        if (!is_string($attribute) || empty($attribute)) {
            return $this;
        }
        if ($like) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            return $this->andWhere([$like, $attribute, $value]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
        return $this->andWhere([$attribute => $value]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Specify range with $attribute to $query.
     * @param ActiveQuery $query
     * @param string $attribute
     * @param string $start
     * @param string $end
     * @return $query

     */
    protected static function range($query, $attribute, $start = null, $end = null)
    {
        if (!empty($start)) {
            $query = $query->andWhere(['>=', $attribute, $start]);
        }
        if (!empty($end)) {
            $query = $query->andWhere(['<', $attribute, $end]);
        }
        return $query;
    }
}

1		<?php
2
3		/**
4		* _ __ __ _____ _____ ___ ____ _____
5		* \| \| / // // ___//_ _// \|\| __\|\|_ _\|
6		* \| \|/ // /(__ ) / / / /\| \|\| \| \| \|
7		* \|___//_//____/ /_/ /_/ \|_\|\|_\| \|_\|
8		* @link https://vistart.me/
9		* @copyright Copyright (c) 2016 - 2017 vistart
10		* @license https://vistart.me/license/
11		*/
12
13		namespace rhosocial\base\models\traits;
14
15		use yii\db\ActiveQuery;
16
17		/**
18		* This trait attach two base conditions.
19		*
20		* @version 1.0
21		* @author vistart <[email protected]>
22		*/
23		trait QueryTrait
24		{
25
26		/**
27		* Attach like condition.
28		* @param mixed $value
29		* @param string $attribute
30		* @param string\|false $like false, 'like', 'or like', 'not like', 'or not like'.
31		* @return $this
32		*/
33	10	protected function likeCondition($value, $attribute, $like = false)
34		{
35	10	if (!is_string($attribute) \|\| empty($attribute)) {
36		return $this;
37		}
38	10	if ($like) {
		0 ignored issues – show Bug Best Practice introduced 2017-01-12 08:52 UTC by Report Bug Copy Issue Report The expression `$like` of type `false\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== false` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
39	1	return $this->andWhere([$like, $attribute, $value]);
		0 ignored issues – show Bug introduced 2017-01-12 08:52 UTC by Report Bug Copy Issue Report It seems like `andWhere()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
40		}
41	10	return $this->andWhere([$attribute => $value]);
		0 ignored issues – show Bug introduced 2017-01-12 08:52 UTC by Report Bug Copy Issue Report It seems like `andWhere()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
42		}
43
44		/**
45		* Specify range with $attribute to $query.
46		* @param ActiveQuery $query
47		* @param string $attribute
48		* @param string $start
49		* @param string $end
50		* @return $query
		0 ignored issues – show Documentation introduced 2017-01-12 08:52 UTC by Report Bug Copy Issue Report The doc-type `$query` could not be parsed: Unknown type name "$query" at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
51		*/
52		protected static function range($query, $attribute, $start = null, $end = null)
53		{
54		if (!empty($start)) {
55		$query = $query->andWhere(['>=', $attribute, $start]);
56		}
57		if (!empty($end)) {
58		$query = $query->andWhere(['<', $attribute, $end]);
59		}
60		return $query;
61		}
62		}

rhosocial / yii2-base-models

Push — master ( 9249bd...d27445 )

QueryTrait A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like