Issues in BaseMongoMessageQuery.php - New Issues - Inspection of "Added `createdAtToday` and `updatedAtToday` method..." - rhosocial/yii2-base-models - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 36165a...48d6cb )

by vistart

created 2017-05-15 05:20 UTC

queries/BaseMongoMessageQuery.php (6 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 *   _   __ __ _____ _____ ___  ____  _____
 *  | | / // // ___//_  _//   ||  __||_   _|
 *  | |/ // /(__  )  / / / /| || |     | |
 *  |___//_//____/  /_/ /_/ |_||_|     |_|
 * @link https://vistart.me/
 * @copyright Copyright (c) 2016 - 2017 vistart
 * @license https://vistart.me/license/
 */

namespace rhosocial\base\models\queries;

use rhosocial\base\models\models\BaseMongoEntityModel;
use rhosocial\base\models\traits\MessageQueryTrait;

/**
 * @version 1.0
 * @author vistart <[email protected]>
 */
class BaseMongoMessageQuery extends BaseMongoBlameableQuery
{
    use MessageQueryTrait;

    /**
     * Get the opposite relation.
     * @param BaseUserModel|string $user initiator
     * @param BaseUserModel|string $other recipient.
     * @param Connection $database
     * @return mixed It's type depends on {$model->class}.
     */
    public function opposite($user, $other, $database = null)
    {
        $model = $this->noInitModel;
        return $this->andWhere(
            [$model->createdByAttribute => BaseMongoEntityModel::compositeGUIDs($other),
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $model->otherGuidAttribute => BaseMongoEntityModel::compositeGUIDs($user)])->orderByCreatedAt(SORT_DESC)

                ->one($database);
    }

    /**
     * Get all the opposites.
     * @param string $user initator.
     * @param array $others all recipients.
     * @param Connection $database
     * @return array instances.
     */
    public function opposites($user, $others = [], $database = null)
    {
        $model = $this->noInitModel;
        $query = $this->andWhere([$model->otherGuidAttribute => BaseMongoEntityModel::compositeGUIDs($user)]);

        /* @var $query static */
        if (!empty($others)) {
            $query = $query->andWhere([$model->createdByAttribute => BaseMongoEntityModel::compositeGUIDs($others)]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return $query->all($database);
    }

    /**
     * Specify initiators.
     * @param string|array $users the guid of initiator if string, or guid array
     * of initiators if array.
     * @return static $this
     */
    public function initiators($users = [])
    {
        if (empty($users)) {
            return $this;
        }
        $model = $this->noInitModel;
        return $this->andWhere([$model->createdByAttribute => BaseMongoEntityModel::compositeGUIDs($users)]);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Specify recipients.
     * @param string|array $users the guid of recipient if string, or guid array
     * of recipients if array.
     * @return static $this
     */
    public function recipients($users = [])
    {
        if (empty($users)) {
            return $this;
        }
        $model = $this->noInitModel;
        return $this->andWhere([$model->otherGuidAttribute => BaseMongoEntityModel::compositeGUIDs($users)]);

    }
}

1		<?php
2
3		/**
4		* _ __ __ _____ _____ ___ ____ _____
5		* \| \| / // // ___//_ _// \|\| __\|\|_ _\|
6		* \| \|/ // /(__ ) / / / /\| \|\| \| \| \|
7		* \|___//_//____/ /_/ /_/ \|_\|\|_\| \|_\|
8		* @link https://vistart.me/
9		* @copyright Copyright (c) 2016 - 2017 vistart
10		* @license https://vistart.me/license/
11		*/
12
13		namespace rhosocial\base\models\queries;
14
15		use rhosocial\base\models\models\BaseMongoEntityModel;
16		use rhosocial\base\models\traits\MessageQueryTrait;
17
18		/**
19		* @version 1.0
20		* @author vistart <[email protected]>
21		*/
22		class BaseMongoMessageQuery extends BaseMongoBlameableQuery
23		{
24		use MessageQueryTrait;
25
26		/**
27		* Get the opposite relation.
28		* @param BaseUserModel\|string $user initiator
29		* @param BaseUserModel\|string $other recipient.
30		* @param Connection $database
31		* @return mixed It's type depends on {$model->class}.
32		*/
33	1	public function opposite($user, $other, $database = null)
34		{
35	1	$model = $this->noInitModel;
36	1	return $this->andWhere(
37	1	[$model->createdByAttribute => BaseMongoEntityModel::compositeGUIDs($other),
		0 ignored issues – show Documentation introduced 2017-05-15 05:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `createdByAttribute` does not exist on `object<rhosocial\base\mo...models\BaseEntityModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38	1	$model->otherGuidAttribute => BaseMongoEntityModel::compositeGUIDs($user)])->orderByCreatedAt(SORT_DESC)
		0 ignored issues – show Bug introduced 2017-05-15 05:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `otherGuidAttribute` does not seem to exist. Did you mean `guidAttribute`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
39	1	->one($database);
40		}
41
42		/**
43		* Get all the opposites.
44		* @param string $user initator.
45		* @param array $others all recipients.
46		* @param Connection $database
47		* @return array instances.
48		*/
49	1	public function opposites($user, $others = [], $database = null)
50		{
51	1	$model = $this->noInitModel;
52	1	$query = $this->andWhere([$model->otherGuidAttribute => BaseMongoEntityModel::compositeGUIDs($user)]);
		0 ignored issues – show Bug introduced 2017-05-15 05:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `otherGuidAttribute` does not seem to exist. Did you mean `guidAttribute`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
53		/* @var $query static */
54	1	if (!empty($others)) {
55	1	$query = $query->andWhere([$model->createdByAttribute => BaseMongoEntityModel::compositeGUIDs($others)]);
		0 ignored issues – show Documentation introduced 2017-05-15 05:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `createdByAttribute` does not exist on `object<rhosocial\base\mo...models\BaseEntityModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
56		}
57	1	return $query->all($database);
58		}
59
60		/**
61		* Specify initiators.
62		* @param string\|array $users the guid of initiator if string, or guid array
63		* of initiators if array.
64		* @return static $this
65		*/
66	1	public function initiators($users = [])
67		{
68	1	if (empty($users)) {
69	1	return $this;
70		}
71	1	$model = $this->noInitModel;
72	1	return $this->andWhere([$model->createdByAttribute => BaseMongoEntityModel::compositeGUIDs($users)]);
		0 ignored issues – show Documentation introduced 2017-05-15 05:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `createdByAttribute` does not exist on `object<rhosocial\base\mo...models\BaseEntityModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
73		}
74
75		/**
76		* Specify recipients.
77		* @param string\|array $users the guid of recipient if string, or guid array
78		* of recipients if array.
79		* @return static $this
80		*/
81	3	public function recipients($users = [])
82		{
83	3	if (empty($users)) {
84	1	return $this;
85		}
86	3	$model = $this->noInitModel;
87	3	return $this->andWhere([$model->otherGuidAttribute => BaseMongoEntityModel::compositeGUIDs($users)]);
		0 ignored issues – show Bug introduced 2017-05-15 05:37 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `otherGuidAttribute` does not seem to exist. Did you mean `guidAttribute`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
88		}
89		}

rhosocial / yii2-base-models

Push — master ( 36165a...48d6cb )

queries/BaseMongoMessageQuery.php (6 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like