rhertogh / yii2-oauth2-server

src/models/traits/Oauth2ClientRelationTrait.php

<?php

namespace rhertogh\Yii2Oauth2Server\models\traits;

use League\OAuth2\Server\Entities\ClientEntityInterface;
use rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ClientInterface;
use rhertogh\Yii2Oauth2Server\interfaces\models\queries\Oauth2ClientQueryInterface;
use yii\base\InvalidConfigException;

trait Oauth2ClientRelationTrait
{
    /**
     * Wrapper for parent's getClient() relation to avoid name conflicts
     * @return Oauth2ClientQueryInterface
     * @since 1.0.0
     */
    public function getClientRelation()
    {
        return parent::getClient();
    }

    /**
     * @inheritDoc
     */
    public function __set($name, $value)
    {
        if ($name === 'client_id' && $this->isRelationPopulated('clientRelation')) {

It seems like isRelationPopulated() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            //@phpstan-ignore-next-line "Cannot unset offset", but checked with `isRelationPopulated`
            unset($this['clientRelation']);
        }
        parent::__set($name, $value);
    }

    /**
     * @inheritDoc
     */
    public function setAttribute($name, $value)
    {
        if ($name === 'client_id' && $this->isRelationPopulated('clientRelation')) {
            //@phpstan-ignore-next-line "Cannot unset offset", but checked with `isRelationPopulated`
            unset($this['clientRelation']);
        }
        parent::setAttribute($name, $value);
    }

    /**
     * @inheritDoc
     */
    public function setClient(ClientEntityInterface $client)
    {
        if (!($client instanceof Oauth2ClientInterface)) {
            throw new InvalidConfigException(get_class($client) . ' must implement ' . Oauth2ClientInterface::class);
        }

        $this->client_id = $client->getPrimaryKey();

The property client_id does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->populateRelation('clientRelation', $client);

It seems like populateRelation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Get the client for this model.
     * @return Oauth2ClientInterface
     * @since 1.0.0
     */
    public function getClient()
    {
        return $this->clientRelation;
    }
}