rhertogh\Yii2Oauth2Server\controllers\web\server\base\Oauth2BaseServerAction::processException()

Complexity

Conditions	13
Paths	110

Size

Total Lines	64
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	39
CRAP Score	13

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function processException($exception, $logCategory)
    {
        $module = $this->controller->module;

        if (Yii::$app->has('response')) {
            $response = Yii::$app->getResponse();
            // reset parameters of response to avoid interference with partially created response data
            // in case the error occurred while sending the response.
            $response->isSent = false;
            $response->stream = null;
            $response->data = null;

The property data does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            $response->content = null;
        } else {
            $response = new Response();
        }

        if ($exception instanceof OAuthServerException) {
            if ($exception->hasRedirect()) {
                return $this->controller->redirect(UrlHelper::addQueryParams($exception->getRedirectUri(), [
                    'error' => $exception->getErrorType()
                ]));
            }

            $response->setStatusCode($exception->getHttpStatusCode());

            $error = $exception->getErrorType();
            $hint = $exception->getHint();
            $description = $exception->getMessage() . ($hint ? ' ' . $hint : '');
        } else {
            $response->setStatusCodeByException($exception);

            $error = ($exception instanceof Exception || $exception instanceof ErrorException)
                ? $exception->getName()
                : 'Exception';

            $displayNonHttpExceptionMessages = $module->displayConfidentialExceptionMessages !== null
                ? $module->displayConfidentialExceptionMessages
                : YII_DEBUG;

            if (
                !$displayNonHttpExceptionMessages
                && !$exception instanceof UserException
                && !$exception instanceof HttpException
            ) {
                $description = Yii::t('yii', 'An internal server error occurred.');
            } else {
                $description = (string)$exception;
            }
        }

        $response->data = [
            'error' => $error,
            'error_description' => $description,
        ];

        if ($response->getIsClientError()) {
            if ($module->httpClientErrorsLogLevel) {

The expression $module->httpClientErrorsLogLevel of type integer|null is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

                Yii::getLogger()->log((string)$exception, $module->httpClientErrorsLogLevel, $logCategory);
            }
        } else {
            Yii::error((string)$exception, $logCategory);
        }

        return $response;
    }