rhertogh\Yii2Oauth2Server\helpers\DateIntervalHelper::toString()

Complexity

Conditions	3
Paths	3

Size

Total Lines	25
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	1

<?php
    public static function toString($interval)
    {

        if ($interval === null) {
            return null;
        }

        $dateParts = array_filter([
            'Y' => $interval->y,
            'M' => $interval->m,
            'D' => $interval->d,
        ]);
        $result = 'P' . implode(array_map(fn($v, $k) => $v . $k, $dateParts, array_keys($dateParts)));

        $timeParts = array_filter([
            'H' => $interval->h,
            'M' => $interval->i,
            'S' => $interval->s,
            'F' => $interval->f,
        ]);
        if ($timeParts) {

The expression $timeParts of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $result .= 'T' . implode(array_map(fn($v, $k) => $v . $k, $timeParts, array_keys($timeParts)));
        }

        return $result;
    }