rhertogh\Yii2Oauth2Server\controllers\console\client\Oauth2SetClientSecretAction::run()

Complexity

Conditions	10
Paths	30

Size

Total Lines	59
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function run()
    {
        $module = $this->controller->module;

        $identifier = $this->controller->identifier;
        $secret = $this->controller->secret;
        $oldSecretValidUntilInput = $this->controller->oldSecretValidUntil;

        if (empty($identifier)) {
            throw new InvalidCallException('The `identifier` option must be specified.');
        }

        /** @var Oauth2ClientInterface $client */
        $client = $module->getClientRepository()->findModelByIdentifier($identifier);
        if (!$client) {

$client is of type rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ClientInterface, thus it always evaluated to true.

            throw new InvalidCallException('No client with identifier "' . $identifier . '" found.');
        }

        if (empty($secret)) {
            $secret = $this->controller->prompt('Client Secret?', [
                'required' => true,
                'validator' => [$client, 'validateNewSecret'],
            ]);
        }

        $oldSecretValidUntil = null;
        if ($oldSecretValidUntilInput) {
            if (StringHelper::startsWith($oldSecretValidUntilInput, 'P')) {
                try {
                    $oldSecretValidUntil = new \DateInterval($oldSecretValidUntilInput);
                } catch (\Exception $e) {
                    $oldSecretValidUntil = false;
                }
            } else {
                try {
                    $oldSecretValidUntil = new \DateTimeImmutable($oldSecretValidUntilInput);
                } catch (\Exception $e) {
                    $oldSecretValidUntil = false;
                }
            }
            if (empty($oldSecretValidUntil)) {
                throw new InvalidArgumentException('Unable to parse "' . $oldSecretValidUntilInput
                    . '" as a DateTime or DateInterval.');
            }
        }

        $client->setSecret($secret, $module->getCryptographer(), $oldSecretValidUntil);

It seems like $oldSecretValidUntil can also be of type false; however, parameter $oldSecretValidUntil of rhertogh\Yii2Oauth2Server\interfaces\models\Oauth2ClientInterface::setSecret() does only seem to accept DateInterval|DateTimeImmutable|null, maybe add an additional type check?

        $client->persist();

        if ($oldSecretValidUntil) {
            $oldSecretValidUntilInfo = ' The previous secret will be valid until '
                . Yii::$app->formatter->asDatetime($client->getOldSecretValidUntil(), 'long');
        } else {
            $oldSecretValidUntilInfo = ' Any previous secret is cleared.';
        }
        $this->controller->stdout('Successfully updated client secret.' . $oldSecretValidUntilInfo
            . PHP_EOL, Console::FG_GREEN);

        return ExitCode::OK;
    }