SearchResultCrawler::getAds() - Code Metrics - Inspection of "Develop" - rfussien/leboncoin-crawler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Rémi

created 2017-04-06 19:49 UTC

SearchResultCrawler::getAds() A

↳ Parent: SearchResultCrawler

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	16
ccs	11
cts	11
cp	1
rs	9.4285
cc	1
eloc	10
nc	1
nop	0
crap	1

<?php

namespace Lbc\Crawler;

use Lbc\Parser\SearchResultUrlParser;

/**
 * Class SearchResultCrawler
 * @package Lbc\node
 */
class SearchResultCrawler extends CrawlerAbstract
{
    /**
     * @param $url
     * @return SearchResultUrlParser
     */
    protected function setUrlParser($url)
    {
        $this->url = new SearchResultUrlParser($url);
    }

    /**
     * Return the total number of ads of the search
     *
     * @return int
     */
    public function getNbAds()
    {
        $nbAds = $this->node
            ->filter('a.tabsSwitch span.tabsSwitchNumbers')
            ->first();

        if ($nbAds->count()) {
            $nbAds = preg_replace('/\s+/', '', $nbAds->text());
            return (int) $nbAds;
        }

        return 0;
    }

    /**
     * Return the number of ads per page.
     *
     * Could be dynamically guessed in future, if Leboncoin change it frequently
     * Or if they add the ability for user to change it on result pages.
     *
     *
     * @return int
     */
    public function getNbAdsPerPage()
    {
        return 35;
    }

    /**
     * Return the number of page
     *
     * @return int
     */
    public function getNbPages()
    {
        return (int) ceil($this->getNbAds() / $this->getNbAdsPerPage());
    }

    /**
     * Get an array containing the ads of the current result page
     *
     * @return array
     */
    public function getAds()
    {
        $ads = array();

        $this->node->filter('[itemtype="http://schema.org/Offer"]')
            ->each(function ($node) use (&$ads) {
                $ad = (new SearchResultAdCrawler(
                    $node,
                    $node->filter('a')->attr('href')
                ))->getAll();

                $ads [$ad->id] = $ad;
            });

        return $ads;
    }

    /**
     * Return the Ads's ID only
     *
     * @return array
     */
    public function getAdsId()
    {
        return array_keys($this->getAds());
    }
}


1		<?php
2
3		namespace Lbc\Crawler;
4
5		use Lbc\Parser\SearchResultUrlParser;
6
7		/**
8		* Class SearchResultCrawler
9		* @package Lbc\node
10		*/
11		class SearchResultCrawler extends CrawlerAbstract
12		{
13		/**
14		* @param $url
15		* @return SearchResultUrlParser
16		*/
17	12	protected function setUrlParser($url)
18		{
19	12	$this->url = new SearchResultUrlParser($url);
20	12	}
21
22		/**
23		* Return the total number of ads of the search
24		*
25		* @return int
26		*/
27	6	public function getNbAds()
28		{
29	6	$nbAds = $this->node
30	6	->filter('a.tabsSwitch span.tabsSwitchNumbers')
31	6	->first();
32
33	6	if ($nbAds->count()) {
34	6	$nbAds = preg_replace('/\s+/', '', $nbAds->text());
35	6	return (int) $nbAds;
36		}
37
38		return 0;
39		}
40
41		/**
42		* Return the number of ads per page.
43		*
44		* Could be dynamically guessed in future, if Leboncoin change it frequently
45		* Or if they add the ability for user to change it on result pages.
46		*
47		*
48		* @return int
49		*/
50	6	public function getNbAdsPerPage()
51		{
52	6	return 35;
53		}
54
55		/**
56		* Return the number of page
57		*
58		* @return int
59		*/
60	6	public function getNbPages()
61		{
62	6	return (int) ceil($this->getNbAds() / $this->getNbAdsPerPage());
63		}
64
65		/**
66		* Get an array containing the ads of the current result page
67		*
68		* @return array
69		*/
70	8	public function getAds()
71		{
72	8	$ads = array();
73
74	8	$this->node->filter('[itemtype="http://schema.org/Offer"]')
75	8	->each(function ($node) use (&$ads) {
76	8	$ad = (new SearchResultAdCrawler(
77	8	$node,
78	8	$node->filter('a')->attr('href')
79	8	))->getAll();
80
81	8	$ads [$ad->id] = $ad;
82	8	});
83
84	8	return $ads;
85		}
86
87		/**
88		* Return the Ads's ID only
89		*
90		* @return array
91		*/
92	4	public function getAdsId()
93		{
94	4	return array_keys($this->getAds());
95		}
96		}
97

rfussien / leboncoin-crawler

Pull Request — master (#16)

SearchResultCrawler::getAds() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like