CrawlerAbstract::getFieldValue() - Code Metrics - Inspection of "improve tests" - rfussien/leboncoin-crawler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 0d5516...ece576 )

by Rémi

created 2017-04-07 14:17 UTC

CrawlerAbstract::getFieldValue() A

↳ Parent: CrawlerAbstract

Complexity

Conditions	3
Paths	4

Size

Total Lines	19
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	19
ccs	0
cts	0
cp	0
rs	9.4285
cc	3
eloc	12
nc	4
nop	5
crap	12

<?php

namespace Lbc\Crawler;

use function foo\func;
use Lbc\Filter\DefaultSanitizer;
use Symfony\Component\DomCrawler\Crawler;

/**
 * Class CrawlerAbstract
 * @package Lbc\Crawler
 */
abstract class CrawlerAbstract
{
    /**
     * @var
     */
    protected $url;

    /**
     * @var string
     */
    protected $sheme = 'https';

    /**
     * @var Crawler
     */
    protected $node;

    /**
     * CrawlerAbstract constructor.
     * @param Crawler $node
     * @param $url
     */
    public function __construct(Crawler $node, $url)
    {
        $this->node = $node;

        $this->setUrlParser($url);
    }

    /**
     * Return the current node
     *
     * @return Crawler
     */
    public function getCrawler()
    {
        return $this->node;
    }

    /**
     * @return mixed
     */
    public function getUrlParser()
    {
        return $this->url;
    }

    /**
     * Return the field's value
     *
     * @param Crawler $node
     * @param mixed $defaultValue
     * @param \Closure $callback
     * @param string $funcName
     * @param string $funcParam
     *
     * @return mixed
     */
    protected function getFieldValue(
        Crawler $node,
        $defaultValue,
        $callback = null,
        $funcName = 'text',
        $funcParam = ''
    ) {
        if ($callback == null) {
            $callback = function ($value) {
                return DefaultSanitizer::clean($value);
            };
        }

        if ($node->count()) {
            return $callback($node->$funcName($funcParam));
        }

        return $defaultValue;
    }

    /**
     * @param $url
     * @return mixed
     */
    abstract protected function setUrlParser($url);
}


1		<?php
2
3		namespace Lbc\Crawler;
4
5		use function foo\func;
6		use Lbc\Filter\DefaultSanitizer;
7		use Symfony\Component\DomCrawler\Crawler;
8
9		/**
10		* Class CrawlerAbstract
11		* @package Lbc\Crawler
12		*/
13		abstract class CrawlerAbstract
14		{
15		/**
16		* @var
17		*/
18		protected $url;
19
20		/**
21		* @var string
22		*/
23		protected $sheme = 'https';
24
25		/**
26		* @var Crawler
27		*/
28		protected $node;
29
30		/**
31		* CrawlerAbstract constructor.
32		* @param Crawler $node
33	28	* @param $url
34		*/
35	28	public function __construct(Crawler $node, $url)
36		{
37	28	$this->node = $node;
38	28
39		$this->setUrlParser($url);
40		}
41
42		/**
43		* Return the current node
44		*
45	2	* @return Crawler
46		*/
47	2	public function getCrawler()
48		{
49		return $this->node;
50		}
51
52		/**
53	10	* @return mixed
54		*/
55	10	public function getUrlParser()
56		{
57		return $this->url;
58		}
59
60		/**
61		* Return the field's value
62		*
63		* @param Crawler $node
64		* @param mixed $defaultValue
65		* @param \Closure $callback
66		* @param string $funcName
67		* @param string $funcParam
68		*
69		* @return mixed
70		*/
71		protected function getFieldValue(
72		Crawler $node,
73		$defaultValue,
74		$callback = null,
75		$funcName = 'text',
76		$funcParam = ''
77		) {
78		if ($callback == null) {
79		$callback = function ($value) {
80		return DefaultSanitizer::clean($value);
81		};
82		}
83
84		if ($node->count()) {
85		return $callback($node->$funcName($funcParam));
86		}
87
88		return $defaultValue;
89		}
90
91		/**
92		* @param $url
93		* @return mixed
94		*/
95		abstract protected function setUrlParser($url);
96		}
97

rfussien / leboncoin-crawler

Push — develop ( 0d5516...ece576 )

CrawlerAbstract::getFieldValue() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like