SearchResultCrawler::getAds() - Code Metrics - Inspection of "Cleanup + AST + Migrate to League\Uri" - rfussien/leboncoin-crawler - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#13)

by Pierre

created 2017-03-10 20:43 UTC

SearchResultCrawler::getAds() A

↳ Parent: SearchResultCrawler

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	12
ccs	7
cts	7
cp	1
rs	9.4285
cc	1
eloc	7
nc	1
nop	0
crap	1

<?php

namespace Lbc\Crawler;

class SearchResultCrawler extends CrawlerAbstract
{
    /**
     * Return the total number of ads of the search
     *
     * @return int
     */
    public function getNbAds()
    {
        $nbAds = $this->crawler
            ->filter('a.tabsSwitch span.tabsSwitchNumbers')
            ->first();

        if ($nbAds->count()) {
            $nbAds = preg_replace('/\s+/', '', $nbAds->text());
            return (int) $nbAds;
        }

        return 0;
    }

    /**
     * Return the number of ads per page.
     *
     * Could be dynamically guessed in future, if Leboncoin change it frequently
     * Or if they add the ability for user to change it on result pages.
     *
     *
     * @return int
     */
    public function getNbAdsPerPage()
    {
        return 35;
    }

    /**
     * Return the number of page
     *
     * @return int
     */
    public function getNbPages()
    {
        return (int) ceil($this->getNbAds() / $this->getNbAdsPerPage());
    }

    /**
     * Get an array containing the ads of the current result page
     *
     * @return array
     */
    public function getAds()
    {
        $ads = array();

        $this->crawler->filter('[itemtype="http://schema.org/Offer"] > a')
            ->each(function ($node) use (&$ads) {
                $ad = (new SearchResultAdCrawler($node))->getAll();
                $ads [$ad->id] = $ad;
            });

        return $ads;
    }

    /**
     * Return the Ad's ID
     *
     * @return array
     */
    public function getAdsId()
    {
        $adsID = array();

        $this->crawler->filter('[itemtype="http://schema.org/Offer"] > a')
            ->each(function ($node) use (&$adsID) {
                $adsID [] = (new SearchResultAdCrawler($node))->getId();
            });

        return $adsID;
    }
}


1		<?php
2
3		namespace Lbc\Crawler;
4
5		class SearchResultCrawler extends CrawlerAbstract
6		{
7		/**
8		* Return the total number of ads of the search
9		*
10		* @return int
11		*/
12	6	public function getNbAds()
13		{
14	6	$nbAds = $this->crawler
15	6	->filter('a.tabsSwitch span.tabsSwitchNumbers')
16	6	->first();
17
18	6	if ($nbAds->count()) {
19	6	$nbAds = preg_replace('/\s+/', '', $nbAds->text());
20	6	return (int) $nbAds;
21		}
22
23		return 0;
24		}
25
26		/**
27		* Return the number of ads per page.
28		*
29		* Could be dynamically guessed in future, if Leboncoin change it frequently
30		* Or if they add the ability for user to change it on result pages.
31		*
32		*
33		* @return int
34		*/
35	6	public function getNbAdsPerPage()
36		{
37	6	return 35;
38		}
39
40		/**
41		* Return the number of page
42		*
43		* @return int
44		*/
45	6	public function getNbPages()
46		{
47	6	return (int) ceil($this->getNbAds() / $this->getNbAdsPerPage());
48		}
49
50		/**
51		* Get an array containing the ads of the current result page
52		*
53		* @return array
54		*/
55	4	public function getAds()
56		{
57	4	$ads = array();
58
59	4	$this->crawler->filter('[itemtype="http://schema.org/Offer"] > a')
60		->each(function ($node) use (&$ads) {
61	4	$ad = (new SearchResultAdCrawler($node))->getAll();
62	4	$ads [$ad->id] = $ad;
63	4	});
64
65	4	return $ads;
66		}
67
68		/**
69		* Return the Ad's ID
70		*
71		* @return array
72		*/
73	4	public function getAdsId()
74		{
75	4	$adsID = array();
76
77	4	$this->crawler->filter('[itemtype="http://schema.org/Offer"] > a')
78	4	->each(function ($node) use (&$adsID) {
79	4	$adsID [] = (new SearchResultAdCrawler($node))->getId();
80	4	});
81
82	4	return $adsID;
83		}
84		}
85

rfussien / leboncoin-crawler

Pull Request — master (#13)

SearchResultCrawler::getAds() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like