HasTickets   A
last analyzed

Complexity

Total Complexity 1

Size/Duplication

Total Lines 14
Duplicated Lines 0 %

Coupling/Cohesion

Components 0
Dependencies 0

Importance

Changes 0
Metric Value
wmc 1
lcom 0
cbo 0
dl 0
loc 14
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A tickets() 0 4 1
1
<?php
2
3
4
namespace RexlManu\LaravelTickets\Traits;
5
6
7
use Illuminate\Database\Eloquent\Relations\HasMany;
8
use RexlManu\LaravelTickets\Models\Ticket;
9
10
/**
11
 * Trait HasTickets
12
 *
13
 * Extends the user model with functions
14
 *
15
 * @package RexlManu\LaravelTickets\Traits
16
 */
17
trait HasTickets
18
{
19
20
    /**
21
     * Gives every ticket that belongs to user
22
     *
23
     * @return HasMany
24
     */
25
    function tickets()
0 ignored issues
show
Best Practice introduced by
It is generally recommended to explicitly declare the visibility for methods.

Adding explicit visibility (private, protected, or public) is generally recommend to communicate to other developers how, and from where this method is intended to be used.

Loading history...
26
    {
27
        return $this->hasMany(Ticket::class);
0 ignored issues
show
Bug introduced by
It seems like hasMany() must be provided by classes using this trait. How about adding it as abstract method to this trait?

This check looks for methods that are used by a trait but not required by it.

To illustrate, let’s look at the following code example

trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

The trait Idable provides a method equalsId that in turn relies on the method getId(). If this method does not exist on a class mixing in this trait, the method will fail.

Adding the getId() as an abstract method to the trait will make sure it is available.

Loading history...
28
    }
29
30
}
31