Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
17 | View Code Duplication | class TicketReference extends Model |
|
|
|||
18 | { |
||
19 | |||
20 | use HasConfigModel; |
||
21 | |||
22 | public function getTable() |
||
26 | |||
27 | /** |
||
28 | * Gives the ticket that belongs to it |
||
29 | * |
||
30 | * @return \Illuminate\Database\Eloquent\Relations\BelongsTo |
||
31 | */ |
||
32 | public function ticket() |
||
36 | |||
37 | /** |
||
38 | * Gives the model that is declared as reference |
||
39 | * |
||
40 | * @return \Illuminate\Database\Eloquent\Relations\MorphTo |
||
41 | */ |
||
42 | public function referenceable() |
||
46 | |||
47 | } |
||
48 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.