Issues in LaravelBlogController.php (master) - Issues in master - retosteffen/laravel-blog - Measure and Improve Code Quality continuously with Scrutinizer

Issues (30)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Http/Controllers/LaravelBlogController.php (16 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Retosteffen\LaravelBlog\Http\Controllers;

use App\User;
use Illuminate\Http\Request;
use Retosteffen\LaravelBlog\Models\Category;
use Retosteffen\LaravelBlog\Models\LaravelBlog;
use Spatie\Tags\Tag;

class LaravelBlogController
{
    public function index()
    {
        $posts = LaravelBlog::where('published', '=', true)->orderBy('published_at', 'desc')->get();

        return view('laravel-blog::blog.index', compact('posts'));
    }

    public function create(Request $request)

    {
        //$this->authorize('create',[LaravelBlog::class]);

        $tags = Tag::all()->sortBy('name', SORT_NATURAL | SORT_FLAG_CASE);
        $categories = Category::all()->sortBy('name', SORT_NATURAL | SORT_FLAG_CASE);

        return view('laravel-blog::blog.create', compact('tags', 'categories'));
    }

    public function store(Request $request)
    {
        //$this->authorize('create',[LaravelBlog::class]);
        $attributes = request()->validate([
            'title'=>['required', 'regex:/^(?![0-9]*$)[a-zA-Z0-9 \-]+$/'],
            'content'=>['required'],
            'excerpt'=>['max:158'],
            'image' => ['image', 'mimes:jpeg,png,jpg,gif,svg', 'max:2048'],
            'alt_text'=>[],
        ]);
        $attributes['published'] = request()->has('published');

        if (request()->has('published')) {
            $attributes['published_at'] = date('Y-m-d H:i:s');
        }

        $blog_post = LaravelBlog::create($attributes);
        $blog_post->author()->associate(auth()->user());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        $blog_post->category()->associate(request()->get('category'));
        $blog_post->save();

        $image_path = null;
        if ($request->file('image')) {

            $original_file_name = $request->file('image')->getClientOriginalName();
            $image_path = $request->file('image')->storeAs('blog_posts/'.$blog_post->id, $original_file_name, 'public');
        }
        $blog_post->image = $image_path;
        $blog_post->save();

        $tags_array = $request->get('tags');
        $tags_names_array = [];
        if ($tags_array) {

            foreach ($tags_array as $tag_id) {
                $tag_object = Tag::find($tag_id);
                $tags_names_array[] = $tag_object->name;
            }
            $blog_post->syncTagsWithType($tags_names_array);
        } else {
            $blog_post->syncTags([]);
        }

        return redirect()->route('blog_admin');
    }

    public function showSlug(LaravelBlog $blogPost)
    {
        if (! $blogPost->published && ! auth()->user()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            abort(404);
        }

        if (config('laravel-blog.permalink') == 'year/month/slug') {
            return redirect()->route('showYearMonthSlug', ['year'=>\Carbon\Carbon::parse($blogPost->published_at)->year, 'month'=>\Carbon\Carbon::parse($blogPost->published_at)->month, 'blogPost' => $blogPost->slug]
      );
        }
        if (config('laravel-blog.permalink') == 'year/month/day/slug') {

            return redirect()->route('showYearMonthDaySlug', ['year'=>\Carbon\Carbon::parse($blogPost->published_at)->year, 'month'=>\Carbon\Carbon::parse($blogPost->published_at)->month, 'day'=>\Carbon\Carbon::parse($blogPost->published_at)->day, 'blogPost' => $blogPost->slug]
      );
        }
        if (config('laravel-blog.permalink') == 'id') {
            return redirect()->route('showID', ['id' => $blogPost->id]
      );
        }

        return view('laravel-blog::blog.show', compact('blogPost'));
    }

    public function showYearMonthSlug($year, $month, LaravelBlog $blogPost)

    {
        if (! $blogPost->published && ! auth()->user()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            abort(404);
        }

        if (config('laravel-blog.permalink') == 'slug') {
            return redirect()->route('showSlug', ['blogPost' => $blogPost->slug]
      );
        }
        if (config('laravel-blog.permalink') == 'id') {
            return redirect()->route('showID', ['id' => $blogPost->id]
      );
        }
        if (config('laravel-blog.permalink') == 'year/month/day/slug') {
            return redirect()->route('showYearMonthDaySlug', ['year'=>$year, 'month'=>$month, 'day'=>\Carbon\Carbon::parse($blogPost->published_at)->day, 'blogPost' => $blogPost->slug]
      );
        }

        return view('laravel-blog::blog.show', compact('blogPost'));
    }

    public function showYearMonthDaySlug($year, $month, $day, LaravelBlog $blogPost)

    {
        if (! $blogPost->published && ! auth()->user()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            abort(404);
        }
        if (config('laravel-blog.permalink') == 'slug') {
            return redirect()->route('showSlug', ['blogPost' => $blogPost->slug]
      );
        }
        if (config('laravel-blog.permalink') == 'id') {
            return redirect()->route('showID', ['id' => $blogPost->id]
      );
        }
        if (config('laravel-blog.permalink') == 'year/month/slug') {
            return redirect()->route('showYearMonthSlug', ['year'=>$year, 'month'=>$month, 'blogPost' => $blogPost->slug]
      );
        }

        return view('laravel-blog::blog.show', compact('blogPost'));
    }

    public function showID($id)
    {
        $blogPost = LaravelBlog::find($id);
        if ($blogPost && ! $blogPost->published && ! auth()->user()) {
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            abort(404);
        }

        if (config('laravel-blog.permalink') == 'slug') {
            return redirect()->route('showSlug', ['blogPost' => $blogPost->slug]
      );
        }
        if (config('laravel-blog.permalink') == 'year/month/slug') {
            return redirect()->route('showYearMonthSlug', ['year'=>\Carbon\Carbon::parse($blogPost->published_at)->year, 'month'=>\Carbon\Carbon::parse($blogPost->published_at)->month, 'blogPost' => $blogPost->slug]
      );
        }
        if (config('laravel-blog.permalink') == 'year/month/day/slug') {

            return redirect()->route('showYearMonthDaySlug', ['year'=>\Carbon\Carbon::parse($blogPost->published_at)->year, 'month'=>\Carbon\Carbon::parse($blogPost->published_at)->month, 'day'=>\Carbon\Carbon::parse($blogPost->published_at)->day, 'blogPost' => $blogPost->slug]
      );
        }

        return view('laravel-blog::blog.show', compact('blogPost'));
    }

    public function edit(LaravelBlog $blogPost)
    {
        //$this->authorize('update',$blogPost);

        $tags = Tag::all()->sortBy('name', SORT_NATURAL | SORT_FLAG_CASE);
        $categories = Category::all()->sortBy('name', SORT_NATURAL | SORT_FLAG_CASE);

        return view('laravel-blog::blog.edit', compact('blogPost', 'tags', 'categories'));
    }

    public function update(Request $request, LaravelBlog $blogPost)
    {
        //$this->authorize('update',$blogPost);
        $attributes = request()->validate([
            'title'=>['required', 'regex:/^(?![0-9]*$)[a-zA-Z0-9 \-]+$/'],
            'content'=>['required'],
            'excerpt'=>['max:158'],
            'image' => ['image', 'mimes:jpeg,png,jpg,gif,svg', 'max:2048'],
            'alt_text'=>[],
        ]);
        $attributes['published'] = request()->has('published');

        if ($request->file('image')) {

            $original_file_name = $request->file('image')->getClientOriginalName();
            $image_path = $request->file('image')->storeAs('blog_posts/'.$blogPost->id, $original_file_name, 'public');
        } else {
            $image_path = $blogPost->image;
        }

        if ($blogPost->published == false && request()->has('published')) {
            $attributes['published_at'] = date('Y-m-d H:i:s');
        }

        $blogPost->category()->associate(request()->get('category'));

        $tags_array = $request->get('tags');
        $tags_names_array = [];
        if ($tags_array) {

            foreach ($tags_array as $tag_id) {
                $tag_object = Tag::find($tag_id);
                $tags_names_array[] = $tag_object->name;
            }
            $blogPost->syncTagsWithType($tags_names_array);
        } else {
            $blogPost->syncTags([]);
        }

        $blogPost->update($attributes);

        $blogPost->image = $image_path;
        $blogPost->save();

        return redirect()->route('blog_admin');
    }

    public function destroy(LaravelBlog $blogPost)
    {
        //$this->authorize('destroy',$blogPost);
        $blogPost->delete();

        return redirect()->route('blog_admin');
    }

    public function admin_page()
    {
        $posts = LaravelBlog::orderBy('published_at', 'desc')->get();

        return view('laravel-blog::blog_admin', compact('posts'));
    }

    public function indexAuthor($user_name)

    {
        $item = User::where('name', '=', $user_name)->first();
        $posts = LaravelBlog::where('published', '=', true)->where('user_id', '=', $item->id)->orderBy('published_at', 'desc')->get();

        return view('laravel-blog::archive', compact('item', 'posts'));
    }
}


Issues (30)

Security Analysis not enabled

src/Http/Controllers/LaravelBlogController.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace Retosteffen\LaravelBlog\Http\Controllers;
4
5		use App\User;
6		use Illuminate\Http\Request;
7		use Retosteffen\LaravelBlog\Models\Category;
8		use Retosteffen\LaravelBlog\Models\LaravelBlog;
9		use Spatie\Tags\Tag;
10
11		class LaravelBlogController
12		{
13		public function index()
14		{
15		$posts = LaravelBlog::where('published', '=', true)->orderBy('published_at', 'desc')->get();
16
17		return view('laravel-blog::blog.index', compact('posts'));
18		}
19
20		public function create(Request $request)
		0 ignored issues – show Unused Code introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
21		{
22		//$this->authorize('create',[LaravelBlog::class]);
23
24		$tags = Tag::all()->sortBy('name', SORT_NATURAL \| SORT_FLAG_CASE);
25		$categories = Category::all()->sortBy('name', SORT_NATURAL \| SORT_FLAG_CASE);
26
27		return view('laravel-blog::blog.create', compact('tags', 'categories'));
28		}
29
30		public function store(Request $request)
31		{
32		//$this->authorize('create',[LaravelBlog::class]);
33		$attributes = request()->validate([
34		'title'=>['required', 'regex:/^(?![0-9]*$)[a-zA-Z0-9 \-]+$/'],
35		'content'=>['required'],
36		'excerpt'=>['max:158'],
37		'image' => ['image', 'mimes:jpeg,png,jpg,gif,svg', 'max:2048'],
38		'alt_text'=>[],
39		]);
40		$attributes['published'] = request()->has('published');
41
42		if (request()->has('published')) {
43		$attributes['published_at'] = date('Y-m-d H:i:s');
44		}
45
46		$blog_post = LaravelBlog::create($attributes);
47		$blog_post->author()->associate(auth()->user());
		0 ignored issues – show Bug introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
48		$blog_post->category()->associate(request()->get('category'));
49		$blog_post->save();
50
51		$image_path = null;
52	View Code Duplication	if ($request->file('image')) {
		0 ignored issues – show Duplication introduced 2020-02-21 09:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		$original_file_name = $request->file('image')->getClientOriginalName();
54		$image_path = $request->file('image')->storeAs('blog_posts/'.$blog_post->id, $original_file_name, 'public');
55		}
56		$blog_post->image = $image_path;
57		$blog_post->save();
58
59		$tags_array = $request->get('tags');
60		$tags_names_array = [];
61	View Code Duplication	if ($tags_array) {
		0 ignored issues – show Duplication introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		foreach ($tags_array as $tag_id) {
63		$tag_object = Tag::find($tag_id);
64		$tags_names_array[] = $tag_object->name;
65		}
66		$blog_post->syncTagsWithType($tags_names_array);
67		} else {
68		$blog_post->syncTags([]);
69		}
70
71		return redirect()->route('blog_admin');
72		}
73
74		public function showSlug(LaravelBlog $blogPost)
75		{
76		if (! $blogPost->published && ! auth()->user()) {
		0 ignored issues – show Bug introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
77		abort(404);
78		}
79
80		if (config('laravel-blog.permalink') == 'year/month/slug') {
81		return redirect()->route('showYearMonthSlug', ['year'=>\Carbon\Carbon::parse($blogPost->published_at)->year, 'month'=>\Carbon\Carbon::parse($blogPost->published_at)->month, 'blogPost' => $blogPost->slug]
82		);
83		}
84	View Code Duplication	if (config('laravel-blog.permalink') == 'year/month/day/slug') {
		0 ignored issues – show Duplication introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
85		return redirect()->route('showYearMonthDaySlug', ['year'=>\Carbon\Carbon::parse($blogPost->published_at)->year, 'month'=>\Carbon\Carbon::parse($blogPost->published_at)->month, 'day'=>\Carbon\Carbon::parse($blogPost->published_at)->day, 'blogPost' => $blogPost->slug]
86		);
87		}
88		if (config('laravel-blog.permalink') == 'id') {
89		return redirect()->route('showID', ['id' => $blogPost->id]
90		);
91		}
92
93		return view('laravel-blog::blog.show', compact('blogPost'));
94		}
95
96	View Code Duplication	public function showYearMonthSlug($year, $month, LaravelBlog $blogPost)
		0 ignored issues – show Duplication introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
97		{
98		if (! $blogPost->published && ! auth()->user()) {
		0 ignored issues – show Bug introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
99		abort(404);
100		}
101
102		if (config('laravel-blog.permalink') == 'slug') {
103		return redirect()->route('showSlug', ['blogPost' => $blogPost->slug]
104		);
105		}
106		if (config('laravel-blog.permalink') == 'id') {
107		return redirect()->route('showID', ['id' => $blogPost->id]
108		);
109		}
110		if (config('laravel-blog.permalink') == 'year/month/day/slug') {
111		return redirect()->route('showYearMonthDaySlug', ['year'=>$year, 'month'=>$month, 'day'=>\Carbon\Carbon::parse($blogPost->published_at)->day, 'blogPost' => $blogPost->slug]
112		);
113		}
114
115		return view('laravel-blog::blog.show', compact('blogPost'));
116		}
117
118	View Code Duplication	public function showYearMonthDaySlug($year, $month, $day, LaravelBlog $blogPost)
		0 ignored issues – show Unused Code introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$day` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Duplication introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
119		{
120		if (! $blogPost->published && ! auth()->user()) {
		0 ignored issues – show Bug introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
121		abort(404);
122		}
123		if (config('laravel-blog.permalink') == 'slug') {
124		return redirect()->route('showSlug', ['blogPost' => $blogPost->slug]
125		);
126		}
127		if (config('laravel-blog.permalink') == 'id') {
128		return redirect()->route('showID', ['id' => $blogPost->id]
129		);
130		}
131		if (config('laravel-blog.permalink') == 'year/month/slug') {
132		return redirect()->route('showYearMonthSlug', ['year'=>$year, 'month'=>$month, 'blogPost' => $blogPost->slug]
133		);
134		}
135
136		return view('laravel-blog::blog.show', compact('blogPost'));
137		}
138
139		public function showID($id)
140		{
141		$blogPost = LaravelBlog::find($id);
142		if ($blogPost && ! $blogPost->published && ! auth()->user()) {
		0 ignored issues – show Bug introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
143		abort(404);
144		}
145
146		if (config('laravel-blog.permalink') == 'slug') {
147		return redirect()->route('showSlug', ['blogPost' => $blogPost->slug]
148		);
149		}
150		if (config('laravel-blog.permalink') == 'year/month/slug') {
151		return redirect()->route('showYearMonthSlug', ['year'=>\Carbon\Carbon::parse($blogPost->published_at)->year, 'month'=>\Carbon\Carbon::parse($blogPost->published_at)->month, 'blogPost' => $blogPost->slug]
152		);
153		}
154	View Code Duplication	if (config('laravel-blog.permalink') == 'year/month/day/slug') {
		0 ignored issues – show Duplication introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
155		return redirect()->route('showYearMonthDaySlug', ['year'=>\Carbon\Carbon::parse($blogPost->published_at)->year, 'month'=>\Carbon\Carbon::parse($blogPost->published_at)->month, 'day'=>\Carbon\Carbon::parse($blogPost->published_at)->day, 'blogPost' => $blogPost->slug]
156		);
157		}
158
159		return view('laravel-blog::blog.show', compact('blogPost'));
160		}
161
162		public function edit(LaravelBlog $blogPost)
163		{
164		//$this->authorize('update',$blogPost);
165
166		$tags = Tag::all()->sortBy('name', SORT_NATURAL \| SORT_FLAG_CASE);
167		$categories = Category::all()->sortBy('name', SORT_NATURAL \| SORT_FLAG_CASE);
168
169		return view('laravel-blog::blog.edit', compact('blogPost', 'tags', 'categories'));
170		}
171
172		public function update(Request $request, LaravelBlog $blogPost)
173		{
174		//$this->authorize('update',$blogPost);
175		$attributes = request()->validate([
176		'title'=>['required', 'regex:/^(?![0-9]*$)[a-zA-Z0-9 \-]+$/'],
177		'content'=>['required'],
178		'excerpt'=>['max:158'],
179		'image' => ['image', 'mimes:jpeg,png,jpg,gif,svg', 'max:2048'],
180		'alt_text'=>[],
181		]);
182		$attributes['published'] = request()->has('published');
183
184	View Code Duplication	if ($request->file('image')) {
		0 ignored issues – show Duplication introduced 2020-02-21 09:16 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
185		$original_file_name = $request->file('image')->getClientOriginalName();
186		$image_path = $request->file('image')->storeAs('blog_posts/'.$blogPost->id, $original_file_name, 'public');
187		} else {
188		$image_path = $blogPost->image;
189		}
190
191		if ($blogPost->published == false && request()->has('published')) {
192		$attributes['published_at'] = date('Y-m-d H:i:s');
193		}
194
195		$blogPost->category()->associate(request()->get('category'));
196
197		$tags_array = $request->get('tags');
198		$tags_names_array = [];
199	View Code Duplication	if ($tags_array) {
		0 ignored issues – show Duplication introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
200		foreach ($tags_array as $tag_id) {
201		$tag_object = Tag::find($tag_id);
202		$tags_names_array[] = $tag_object->name;
203		}
204		$blogPost->syncTagsWithType($tags_names_array);
205		} else {
206		$blogPost->syncTags([]);
207		}
208
209		$blogPost->update($attributes);
210
211		$blogPost->image = $image_path;
212		$blogPost->save();
213
214		return redirect()->route('blog_admin');
215		}
216
217		public function destroy(LaravelBlog $blogPost)
218		{
219		//$this->authorize('destroy',$blogPost);
220		$blogPost->delete();
221
222		return redirect()->route('blog_admin');
223		}
224
225		public function admin_page()
226		{
227		$posts = LaravelBlog::orderBy('published_at', 'desc')->get();
228
229		return view('laravel-blog::blog_admin', compact('posts'));
230		}
231
232	View Code Duplication	public function indexAuthor($user_name)
		0 ignored issues – show Duplication introduced 2020-02-20 09:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
233		{
234		$item = User::where('name', '=', $user_name)->first();
235		$posts = LaravelBlog::where('published', '=', true)->where('user_id', '=', $item->id)->orderBy('published_at', 'desc')->get();
236
237		return view('laravel-blog::archive', compact('item', 'posts'));
238		}
239		}
240

retosteffen / laravel-blog

Issues (30)

Security Analysis not enabled

src/Http/Controllers/LaravelBlogController.php (16 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like