Retosteffen\LaravelBlog\Http\Controllers\CategoryController

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	30.36 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	6	1
A	create()	0	4	1
A	store()	0	10	1
A	show()	7	7	1
A	edit()	0	4	1
A	update()	10	10	1
A	destroy()	0	6	1

<?php

namespace Retosteffen\LaravelBlog\Http\Controllers;

use Illuminate\Http\Request;
use Retosteffen\LaravelBlog\Models\Category;
use Retosteffen\LaravelBlog\Models\LaravelBlog;

class CategoryController
{
    public function index(Request $request)

The parameter $request is not used and could be removed.

    {
        $categories = Category::all()->sortBy('name', SORT_NATURAL | SORT_FLAG_CASE);

        return view('laravel-blog::category.index', compact('categories'));
    }

    public function create(Request $request)

The parameter $request is not used and could be removed.

    {
        return view('laravel-blog::category.create');
    }

    public function store(Request $request)

The parameter $request is not used and could be removed.

    {
        $attributes = request()->validate([
            'name'=>['required'],
        ]);

        $category = Category::create($attributes);

$category is not used, you could remove the assignment.

        return redirect()->route('categories');
    }

    public function show(Category $category)

This method seems to be duplicated in your project.

    {
        $item = $category;
        $posts = LaravelBlog::where('published', '=', true)->where('category_id', '=', $item->id)->orderBy('published_at', 'desc')->get();

        return view('laravel-blog::archive', compact('item', 'posts'));
    }

    public function edit(Category $category)
    {
        return view('laravel-blog::category.edit', compact('category'));
    }

    public function update(Request $request, Category $category)

The parameter $request is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $attributes = request()->validate([
            'name'=>['required'],
        ]);

        $category->update($attributes);

        return redirect()->route('categories');
    }

    public function destroy(Category $category)
    {
        $category->delete();

        return redirect()->route('categories');
    }
}